Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TinyMCE to 4.4.0 #10979

Merged
merged 4 commits into from Jul 16, 2016

Conversation

Projects
None yet
6 participants
@brianteeman
Copy link
Contributor

commented Jul 1, 2016

Summary of Changes

Version 4.4.0 (2016-06-30)

  • Added new inlite theme this is a more lightweight inline UI.
  • Added smarter paste logic that auto detects urls in the clipboard and inserts images/links based on that.
  • Added a better image resize algorithm for better image quality in the imagetools plugin.
  • Fixed bug where it wasn't possible to drag/dropping cE=false elements on FF.
  • Fixed bug where backspace/delete before/after a cE=false block would produce a new paragraph.
  • Fixed bug where list style type css property wasn't preserved when indenting lists.
  • Fixed bug where merging of lists where done even if the list style type was different.
  • Fixed bug where the image_dataimg_filter function wasn't used when pasting images.
  • Fixed bug where nested editable within a non editable element would cause scroll on focus in Chrome.
  • Fixed so invalid targets for inline mode is blocked on initialization. We only support elements that can have children.

Version 4.3.13 (2016-06-08)

  • Added characters with a diacritical mark to charmap plugin. Patch contributed by Dominik Schilling.
  • Added better error handling if the image proxy service would produce errors.
  • Fixed issue with pasting list items into list items would produce nested list rather than a merged list.
  • Fixed bug where table selection could get stuck in selection mode for inline editors.
  • Fixed bug where it was possible to place the caret inside the resize grid elements.
  • Fixed bug where it wasn't possible to place in elements horizontally adjacent cE=false blocks.
  • Fixed bug where multiple notifications wouldn't be properly placed on screen.
  • Fixed bug where multiple editor instance of the same id could be produces in some specific integrations.

NOTES

I have not included the new inlite theme as that requires bigger changes to our implementation so thats for another PR if someone wants to make it

TEST

Apply PR and ensure that the editor works as expected

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2016

@brianteeman there are permission chnages 100644 → 100755 is that expected?

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2016

No - it is me messing up again :(

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2016

I have tested this item successfully on 5d09458

Looks good from here in Backend and Frontend. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10979.

@viocassel

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

I have tested this item successfully on 5d09458


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10979.

@brianteeman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10979.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 2, 2016

@Twincarb

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

I have tested this item successfully on 5d09458


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10979.

@brianteeman brianteeman modified the milestone: Joomla 3.6.1 Jul 11, 2016

@roland-d roland-d merged commit fca2b0c into joomla:staging Jul 16, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Jul 16, 2016

@brianteeman brianteeman deleted the brianteeman:tinymce44 branch Jul 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.