Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression][fix]Migration from 2.5.28 to 3.6 returns Fatal errors & reverts #9655 #11282

Merged
merged 1 commit into from Jul 24, 2016

Conversation

Projects
None yet
10 participants
@zero-24
Copy link
Contributor

commented Jul 23, 2016

Pull Request for Issue #11117 .

Summary of Changes

Reverts #9655

There reason is simple. The new file that calls the post update deletion of the files get not called if you update from 2.5 to 3.6 ther for this needs to stay in the script.php too.

Testing Instructions

install 2.5
Update to 3.6
see the issue

Notice: Undefined property: LoginController::$input in ...administrator\components\com_login\controller.php on line 36
Fatal error: Call to a member function set() on null in ...administrator\components\com_login\controller.php on line 36

roll back to 2.5
install the update to 3.6 with the changes in this patch (or use this update server: http://www.jah-tz.de/downloads/core/list.xml)
there should be no issues on updating.

@wilsonge please have a look here if this can go into 3.6.1 too as exactly that happen what you guess in the original thread: c864a01

@AlexRed

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2016

I have tested this item successfully on 8c9b0f8

ok, no more error.
Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11282.

@infograf768

This comment has been minimized.

Copy link
Member

commented Jul 24, 2016

I have tested this item successfully on 8c9b0f8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11282.

@joomla-cms-bot joomla-cms-bot changed the title [fix]Migration from 2.5.28 to 3.6 returns Fatal errors & reverts #9655 [Regression][fix]Migration from 2.5.28 to 3.6 returns Fatal errors & reverts #9655 Jul 24, 2016

@infograf768

This comment has been minimized.

Copy link
Member

commented Jul 24, 2016

RTC. This solves the issue.

@wilsonge

This has to go imho in 3.6.1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11282.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 24, 2016

@N8Solutions

This comment has been minimized.

Copy link

commented Jul 24, 2016

I just wanted to thank @zero-24 for this information and provide the error message I was receiving which was different. I was doing a migration today for an old site from j2.5.28 to j3.6 and ran in to a similar problem. The only difference was I received the following error message:
Fatal error: Call to a member function isAdmin() on null in /plugins/system/stats/stats.php on line 87
When I used your update server the migration worked successfully!
I was not using the Statistics module but it was enabled in the extension manager. I first tried disabling it and then when that didn't work I restored the site from backup, disabled it once again, then uninstalled it, and still the problem remained. That is until I used this fix for the migration! Thank you again!

@wilsonge wilsonge merged commit 82dd2b9 into joomla:staging Jul 24, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge added this to the Joomla 3.6.1 milestone Jul 24, 2016

@joomla-cms-bot joomla-cms-bot removed the RTC label Jul 24, 2016

@zero-24 zero-24 deleted the zero-24:revert9655 branch Jul 25, 2016

@markberk

This comment has been minimized.

Copy link

commented Jul 27, 2016

if i use this update server("http://www.jah-tz.de/downloads/core/list.xml"), joomla says: "Download of update package failed".
Is it correct that in the Options pane, i select "Custom url", and in the custom url textbox, i type: "http://www.jah-tz.de/downloads/core/list.xml"?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11282.

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2016

@markberk yes that is correct. Please try again. If it still not work (i can't reproduce the error) please wait for 3.6.1 which fixes the issue. Please switch back to the core supported update chanels!

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2016

FYI. I have uploaded this just 13 days ago and now we have more than 100 Downloads on that package that was for testing this PR only?! I'm going to remove this update server now. I hope you all have swiched back to the default update server after using mine else you will never get any update anymore!

@gpenglase

This comment has been minimized.

Copy link

commented Aug 17, 2016

Thanks @zero-24 that worked a treat. all update issues resolved.

@andrepereiradasilva

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2016

@zero-24 aren't people forced to go to 3.6.0 now? but this fix is only included in 3.6.1+ right?

So any updating from 2.5.28 to 3.6.0 will still have error, right?

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2016

Correct. So we changed it so that 2.5.x goes to 3.5.1 then 3.5.1 to 3.6.0 then 3.6.0 to whatever after updating joomla update. It's in the notes here: https://www.joomla.org/announcements/release-news/5666-the-joomla-3-6-1-update.html

It's super horrible. But it's the best we can do :(

@andrepereiradasilva

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2016

yes, it seems so.

so the migrate/upgrade path from 2.5.28 is:

  • 2.5.28 > 3.5.1
  • 3.5.1 > 3.6.0
  • update joomla update component
  • 3.6.0 > latest version
@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2016

Correct. There for i have add this one #11493 that anyone will notice to first update the update component in the future ;)

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

@wilsonge just came across this problem but reading this here the fix is in 3.6 but as the update goes to 3.5.1 then this pr doesnt fix anything

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2017

@brianteeman can you give us more details? And move that to a new issue so we can debug and fix the issue? ;)

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

it didnt happen when i tried again ;)

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2017

hmm can you share the details in a new issue or via mail regardless so I can double check that case. As the updater is a important thing in our system I think we should analyse any errors that comes up even if we decide / found out that it is not a issue we can / need fix or it just popup random. 😄

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.