New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email cloaking #11460

Merged
merged 2 commits into from Aug 4, 2016

Conversation

Projects
None yet
5 participants
@wilsonge
Contributor

wilsonge commented Aug 4, 2016

Pull Request for Issue #11456 .

Summary of Changes

Fixes email cloaking plugin loosing html data

Testing Instructions

Create an article with body <a href="mailto:toto@toto.com" class="nameofmyclass">email</a> and email cloak plugin enabled. Before note the class is stripped after the class exists

wilsonge added some commits Aug 4, 2016

@Lavsteph

This comment has been minimized.

Show comment
Hide comment
@Lavsteph

Lavsteph Aug 4, 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

Lavsteph commented Aug 4, 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

@Sandra97

This comment has been minimized.

Show comment
Hide comment
@Sandra97

Sandra97 Aug 4, 2016

I have tested this item successfully on

I tested the patch on a localhost, using Joomla! 3.6.1 Stable [ Noether ] 2-August-2016 22:59 GMT, on a site I'm working on it for a few weeks now.

I confirm the initial issue.
After applying #11460 , everything is back to normal, the class is back and works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

Sandra97 commented Aug 4, 2016

I have tested this item successfully on

I tested the patch on a localhost, using Joomla! 3.6.1 Stable [ Noether ] 2-August-2016 22:59 GMT, on a site I'm working on it for a few weeks now.

I confirm the initial issue.
After applying #11460 , everything is back to normal, the class is back and works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 4, 2016

Contributor

I have tested this item successfully on

replicated issue as reported in the instructions and confirmed it worked


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

Contributor

brianteeman commented Aug 4, 2016

I have tested this item successfully on

replicated issue as reported in the instructions and confirmed it worked


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

@wilsonge wilsonge merged commit 65500d0 into joomla:staging Aug 4, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details

@wilsonge wilsonge added this to the Joomla 3.6.2 milestone Aug 4, 2016

@wilsonge wilsonge deleted the wilsonge:email-cloaking branch Aug 4, 2016

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.6.2 milestone Aug 4, 2016

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 4, 2016

Contributor

cms bot do your thing please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

Contributor

brianteeman commented Aug 4, 2016

cms bot do your thing please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11460.

@wilsonge wilsonge added this to the Joomla 3.6.2 milestone Aug 4, 2016

Edu20 pushed a commit to Edu20/joomla-cms that referenced this pull request Aug 11, 2016

Email cloaking (#11460)
* Revert back to inline scripts for now

* Fix comment

roland-d added a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016

Email cloaking (#11460)
* Revert back to inline scripts for now

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment