Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_joomlaupdate] Allow a different reinstall URL than the update URL #11497

Closed
wants to merge 197 commits into from

Conversation

Projects
None yet
@zero-24
Copy link
Contributor

commented Aug 6, 2016

Pull Request for Issue #11488

Notice

Don't do that never on your Live Site please install a dev / test install!

Summary of Changes

With this patch applyed you can use a different reinstall URL than the update url.

For Updating you need just the Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip package for reinstall you need the Joomla_3.6.2-Stable-Update_Package.zip.

So now if we have a reinstall URL configured lets use it.

Testing Instructions

Tip: Do not hit the Update or Reinstall button on testing else the applyed PR gets reverted!

  • install 3.6.2
  • go to com_joomlaupdate
  • see the reinstall URL is Joomla_3.6.2-Stable-Update_Package.zip
  • apply this patch
  • switch the update server to http://www.jah-tz.de/downloads/core/list2.xml
  • go to com_joomlaupdate again
  • see the reinstall URL is Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip
  • switch back to the core Update server
  • see that now we have Joomla_3.6.2-Stable-Update_Package.zip back.
  • switch the update server to http://www.jah-tz.de/downloads/core/list3.xml
  • notice there is a update that points to Joomla_3.6.2-Stable-Update_Package.zip

Documentation Changes Required

There is a core used only new entry for the extension.xml used by the core updater.

Additional Information

The Joomla Core Update Server needs to be extended to use the function with this line. if that line is missing reinstallurl is the same as the update url:

<reinstallurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.2-Stable-Update_Package.zip</reinstallurl>

A complete example:

<?xml version="1.0" ?>
<updates>
    <update>
        <name>Joomla! 3.6</name>
        <description>Joomla! 3.6 CMS</description>
        <element>joomla</element>
        <type>file</type>
        <version>3.6.2</version>
        <infourl title="Joomla!">https://www.joomla.org/announcements/release-news/5667-joomla-3-6-2-released.html</infourl>
        <downloads>
            <downloadurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip</downloadurl>
            <reinstallurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.2-Stable-Update_Package.zip</reinstallurl>
        </downloads>
        <tags>
            <tag>stable</tag>
        </tags>
        <maintainer>Joomla! PLT</maintainer>
        <maintainerurl>https://www.joomla.org</maintainerurl>
        <section>STS</section>
        <targetplatform name="joomla" version="3.6" />
        <php_minimum>5.3.10</php_minimum>
    </update>
</updates>
@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2016

Why would we want to do this - what is the use case


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11497.

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2016

On request by @jeckodevelopment and @wilsonge so there is no need to update with a 10mb package from 3.6.1 to 3.6.2 ;)

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2016

@zero-24 sorry if I misunderstood but I read this as allowing an install from a different domain

@jeckodevelopment

This comment has been minimized.

Copy link
Member

commented Aug 7, 2016

@brianteeman it does, but only to test this PR since we cannot use the official release URL to test the PR.

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2016

that cannot be in the final version then -

On 7 August 2016 at 14:25, Luca Marzo notifications@github.com wrote:

@brianteeman https://github.com/brianteeman it does, but only to test
this PR since we cannot use the official release URL to test the PR.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11497 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fdKP7MGF6KdwxvqOVFbzuXVpgztks5qddyygaJpZM4JeT8m
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@jeckodevelopment

This comment has been minimized.

Copy link
Member

commented Aug 7, 2016

it should be fixed after tests.

@AlexRed

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2016

In Joomla 3.6.1 after patch applyed and switch the update server (http://www.jah-tz.de/downloads/core/list2.xml) the com_joomlaupdate show the wrong package URL Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip and not the correct Joomla_3.6.1_to_3.6.2-Stable-Patch_Package.zip

In Joomla 3.6.0 after patch applyed and switch the update server (http://www.jah-tz.de/downloads/core/list2.xml) the com_joomlaupdate show the correct package URL Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2016

That is the expected behavior. The 3.6.1 to 3.6.2 package is not implemented yet. @AlexRed

@AlexRed

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2016

ok, I can test it when implemented

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2016

There is no plan to implement that here as this can be done with the current code just with another update definition ;)

@@ -50,9 +50,6 @@
<?php echo $this->loadTemplate('update'); ?>
<?php endif; ?>

<input type="hidden" name="task" value="update.download" />
<input type="hidden" name="option" value="com_joomlaupdate" />

This comment has been minimized.

Copy link
@yvesh

yvesh Aug 7, 2016

Member

@zero-24 You could have kept the option here, as it is the same for both templates :-)

This comment has been minimized.

Copy link
@zero-24

zero-24 Aug 7, 2016

Author Contributor

No. The update template uses download and the reinstall template use reinstall ;)

This comment has been minimized.

Copy link
@zero-24

zero-24 Aug 7, 2016

Author Contributor

Ok double checked. Yes i'm ging to fix this if im back on my pc :)

@zero-24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2016

can we have the labels here @joomla-cms-bot ?

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2016

@zero-24 bot not working so brian-bot did it

Bakual and others added some commits Nov 15, 2016

Add "show global value" feature to com_contact (#12861)
* Add "show global value" feature to com_contact

* Missed text fields

* Reverting order of show_info options in com_contact component config.
Add "show global value" feature to com_content frontend edit (#12863)
* Add "show global value" feature to com_content frontend edit

* Enable show global value for "Show Associations"
Add "show global value" feature to com_tags (#12865)
* Add "show global value" feature to com_tags

* Show global value for "Maximum Characters"
[unit tests] Remove empty acl rules (#12915)
* clean unit tests assets table

* Update jos_assets_composite.csv

* jaccesstest
Adding the ability to use the global value for character count in new…
…sfeeds (#12869)

* Adding the ability to use the global value for character count in newsfeeds

* Missing views
[JHtmlNumber::bytes] Format number according to language (#12929)
* return translated number

* ups

* cs

* fix unit tests

* fix last unit tests

* minor cs
remove tab on meta charset (#12895)
* remove tab on meta charset

* Update code
Fix for Undefined offset in Content History preview popup (#12791)
* Fix Undefined offset

* tabs/spacing

* If someone has faked an article id - dont show trace, show an error

* make travis happy

* make travis happy

* travis I hate you

* tab/space hell

* tab/spaces hell

* changes as requested

* remove the $language var as per comment
Set correct component id for system links (#12938)
* Update menu.php

* Update item.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.