Add a plugin with a nag message to update PHP #11498

mbabker · 2016-08-06T20:57:30Z

Summary of Changes

Far too many people run Joomla on outdated PHP versions (per the stats only 37% of Joomla! 3.5+ installs are on a currently supported PHP version). To help alleviate this, I propose a nag message to tell people to upgrade.

This plugin checks three conditions: whether the PHP version is still fully supported, whether it has entered security support only, or whether it is unsupported by the PHP project. I don't particularly care whether the user is running a PHP version custom compiled by some Linux distro that claims they are still supporting it; if PHP isn't supporting the branch anymore they need to update.

Testing Instructions

Apply the pull request; discover, install, and enable the plugin. For PHP 5.3 thru 5.5 you should get a red error message telling you the PHP version is unsupported and you should upgrade yesterday. PHP 5.6 and 7.0 won't emit anything because neither has reached a security only state, however if you want to test that aspect of things go into the plugin and change the date for when security support ends in the data array to a date before today (today being whatever day you test this).

Documentation Changes Required

None. No new API is introduced.

Maintenance Efforts Added

As the support dates for PHP branches change (new versions added, dates postponed), the data array in this plugin will need to be updated. Generally this is a once a year requirement when a new version is added only.

Joomla, Stop Nagging Me!!!

Upgrade, plain and simple. Oh, not an option? As long as you understand you are running unsupported software, you can disable the plugin and stop being nagged. But you should still upgrade yesterday.

brianteeman · 2016-08-06T21:02:21Z

administrator/language/en-GB/en-GB.plg_system_phpversioncheck.ini

+; Note : All ini files need to be saved as UTF-8
+
+PLG_SYSTEM_PHPVERSIONCHECK="System - PHP Version Check"
+PLG_SYSTEM_PHPVERSIONCHECK_SECURITY_ONLY="Your PHP version, %1$s, is only receiving security fixes at this time. This means your PHP version will soon no longer be supported. We recommend planning to upgrade to a newer PHP version before it reaches end of support on %2$s. Please contact your host for upgrade instructions."


i am concerned that non technical users dont know what php is. in the other message you say "by the PHP project."
Can you change this message to
"s only receiving security fixes at this time from the PHP project."

brianteeman · 2016-08-06T21:02:38Z

i am concerned that non technical users dont know what php is.

brianteeman · 2016-08-06T21:03:38Z

It would be beneficial if this explained the benefits of upgrading the php version and how easy it usually is

mbabker · 2016-08-06T21:08:13Z

i am concerned that non technical users dont know what php is.

Well without turning this into a full screen notification, hard to really explain it. Totally valid concern, but not easy to deal with. Unlike other projects who encourage users to not need to be technical, I think it's borderline irresponsible to not at least know what platform(s) your site is running on.

brianteeman · 2016-08-06T21:10:39Z

I live in the real world not the technical world. ;)

If you dont explain the benefits or how easy it usually is to upgrade we will lose users who just assume their hosting doesnt support joomla.

I am not against this concept just the implementation

mbabker · 2016-08-06T21:11:58Z

Suggestions welcome. I'm just trying to keep this from becoming a full screen notification.

brianteeman · 2016-08-06T21:15:28Z

We highly recommend upgrading your server to a newer PHP version. Please contact your host for upgrade instructions."

==>

Joomla will be faster and more secure if you upgrade to a newer PHP version (preferably 7.x). Contact your host - they can usually do this for you very easily.

brianteeman · 2016-08-06T21:21:22Z

For reference our previous message was

COM_CPANEL_MSG_PHPVERSION_BODY="Beginning with Joomla! 3.3, the version of PHP this site is using will no longer be supported. Joomla! 3.3 will require at least <a href="QQ"http://community.joomla.org/blogs/leadership/1798-raising-the-bar-on-security.html"_QQ_">PHP version 5.3.10 in order to provide enhanced security features to its users."

brianteeman · 2016-08-06T21:23:12Z

administrator/language/en-GB/en-GB.plg_system_phpversioncheck.ini

+; Note : All ini files need to be saved as UTF-8
+
+PLG_SYSTEM_PHPVERSIONCHECK="System - PHP Version Check"
+PLG_SYSTEM_PHPVERSIONCHECK_SECURITY_ONLY="Your PHP version, %1$s, is only receiving security fixes at this time from the PHP project. This means your PHP version will soon no longer be supported. We recommend planning to upgrade to a newer PHP version before it reaches end of support on %2$s. Please contact your host for upgrade instructions."


can you add this sentence to this string as well

Joomla will be faster and more secure if you upgrade to a newer PHP version (PHP 7.x is recommended).

zero-24 · 2016-08-06T21:44:44Z

The new language files needs to be added to the install.xml ;)

zero-24 · 2016-08-06T21:57:09Z

And the update sql ;P

mbabker · 2016-08-06T21:59:48Z

And the update sql ;P

What update SQL?

zero-24 · 2016-08-06T22:01:22Z

That it get enabled on update. The update sql in com_admin :)

zero-24 · 2016-08-06T22:02:07Z

Ignore that i have just not saw it. Sorry

roland-d · 2016-08-06T22:03:43Z

Should this message be shown to super users/administrators only perhaps? We may assume they know what PHP is.

mbabker · 2016-08-06T22:06:51Z

Should this message be shown to super users/administrators only perhaps? We may assume they know what PHP is.

Even that's an overly broad assumption.

brianteeman · 2016-08-06T22:07:21Z

I don't think that's a valid assumption at all.

roland-d · 2016-08-06T22:12:10Z

In that case just show it to everyone and they can google what PHP is.

brianteeman · 2016-08-06T22:16:21Z

I hope that was a joke

mbabker · 2016-08-06T22:21:16Z

Right now it shows on the backend to everyone similarly to the 2.5 EOS plugin.

andrepereiradasilva · 2016-08-06T23:46:57Z

i don't have any server to test this since my servers php version are all 7.x ... ok. that it's probably good news 😄

infograf768 · 2016-08-07T06:23:29Z

Should be tagged to New Feature I guess.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

alikon · 2016-08-07T06:27:10Z

its a little bit too much nag in this way

AlexRed · 2016-08-07T08:10:17Z

I have tested this item ✅ successfully on 866376b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

nikosdion · 2016-08-07T17:31:48Z

+1 on Michael's approach (or you will all bitterly regret being stubborn in a year or so, as always).

PhilETaylor · 2016-08-07T17:34:28Z

Just have balls and commit this without watering it down - listen to those of us that have to deal with the idiots on PHP 5.3 on a daily basis...

It should be in your face, in red and bold, on every page and un-dismissable.

ggppdk · 2016-08-07T17:36:17Z

If that will preclude this being merged I'll just close this.

this plugin / message is needed for reasons already discussed, nobody said not to add this

I will NOT add a session counter.

Only a suggestion if this is to be displayed in non-control panel pages

why i suggested it , because imagine that a website is upgraded to newer PHP e.g. after 2 days or 2 weeks, people will see it for 2days or 2 weeks in all backend pages ? while working in site's backend for hours everyday ? or did you say to only show it at control panel area ?

andrepereiradasilva · 2016-08-07T17:36:50Z

Ok, i see you all prefer the error aproach. since this is the current practice (2.5 EOL, joomla update notification, extension updates notification) is consistent, so fine by me.

@mbabker i have just one question, what happens when php 7.1 is released/used.

wilsonge · 2016-08-07T17:38:57Z

plugins/quickicon/phpversioncheck/phpversioncheck.php

@@ -135,6 +135,7 @@ private function getPhpSupport()

 		// Check the PHP version's support status using the minor version
 		$activePhpVersion = PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION;
+		$activePhpVersion = '5.3';


mbabker · 2016-08-07T17:40:01Z

@mbabker i have just one question, what happens when php 7.1 is lanched/used.

The checks default to the PHP version being supported so messages aren't rendered for unknown versions. When a PHP version isn't found in the array, then it takes no action (we don't have data on the PHP version so we err on the side of caution and do nothing), specifically this line.

mbabker · 2016-08-07T17:41:16Z

because imagine that a website is upgraded to newer PHP e.g. after 2 weeks, people will see it for 2 weeks in all backend pages ?

It's a plugin, disable it if you're tired of Joomla nagging. At least I'm giving you that option and not hardcoding it directly into JApplicationAdministrator's constructor.

andrepereiradasilva · 2016-08-07T17:41:17Z

ok thanks, will test faking the php versions.

andrepereiradasilva · 2016-08-07T17:46:37Z

I have tested this item ✅ successfully on 3681966

works as described

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

ggppdk · 2016-08-07T17:52:24Z

It's a plugin, disable it if you're tired of Joomla nagging. At least I'm giving you that option and not hardcoding it directly into JApplicationAdministrator's constructor.

yes, after googling
"how i disable annoying message about php version in joomla",

they will find a web page with instructions to disable the plugin,
and then they will forget about it,
and that will defeat the purpose of upgrading the PHP

Too annoying messages are usually turned off and then forgotten

but i looked at the code you have already limitted the display to control panel,
which is very good, because

people will see it once at every login
now it is unlikely that they will disable the plugin !

in fact i think it is great now !!, i ll test

mbabker · 2016-08-07T17:54:31Z

but i looked at the code you have already limitted the display to control panel,

Which I think is the wrong move but politics seems to dictate that we can't be excessively annoying in telling users they should be responsible and update their stuff. ¯\_(ツ)_/¯

elkuku · 2016-08-07T18:21:41Z

plugins/quickicon/phpversioncheck/phpversioncheck.php

+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	private function displayMessage()


It looks strange that a display* method returns a boolean, I'd call it getDisplayStatus() maybe 😉

Otherwise: Great idea 100👍

elkuku · 2016-08-07T20:15:01Z

I have tested this item ✅ successfully on 3681966

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

dgrammatiko · 2016-08-07T20:32:17Z

I have tested this item ✅ successfully on 3681966

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

jeckodevelopment · 2016-08-08T12:54:43Z

I have tested this item ✅ successfully on 3681966

RTC Please

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

mbabker · 2016-08-08T12:57:16Z

The only thing that last commit does is change the method name per @elkuku suggestion. Shouldn't need re-testing.

andrepereiradasilva · 2016-08-08T13:10:37Z

I have tested this item ✅ successfully on f236d70

only method name changed.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11498.}

wilsonge · 2016-08-08T22:55:04Z

Merged to 3.7.x with e4894d2 Thanks Michael!

brianteeman · 2016-08-11T16:20:13Z

Doing the job of the lazy bot and removing the rtc flag

joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 6, 2016

Add a plugin with a nag message to update PHP

0df937f

brianteeman reviewed Aug 6, 2016
View changes

Language tweaks

217b826

Language

674e2ec

brianteeman reviewed Aug 6, 2016
View changes

Add sentence

866376b

Weaken plugin's message

b07454a

Correct check

b6660e2

wilsonge reviewed Aug 7, 2016
View changes

Well, I had to fake it to check it...

3681966

wilsonge added this to the Joomla 3.7.0 milestone Aug 7, 2016

elkuku reviewed Aug 7, 2016
View changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 8, 2016

Change private method name per suggestion

f236d70

wilsonge pushed a commit that referenced this issue Aug 8, 2016

Add a plugin with a nag message to update PHP. Fixes #11498

e4894d2

wilsonge closed this Aug 8, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 11, 2016

mbabker deleted the php-version-check branch Aug 11, 2016

brianteeman mentioned this pull request May 26, 2021

[ALL] PHP Version Check #34225

Closed

Add a plugin with a nag message to update PHP #11498

Add a plugin with a nag message to update PHP #11498

Conversation

mbabker commented Aug 6, 2016 • edited by joomla-cms-bot

Summary of Changes

Testing Instructions

Documentation Changes Required

Maintenance Efforts Added

Joomla, Stop Nagging Me!!!

brianteeman Aug 6, 2016

Choose a reason for hiding this comment

brianteeman commented Aug 6, 2016

brianteeman commented Aug 6, 2016

mbabker commented Aug 6, 2016

brianteeman commented Aug 6, 2016

mbabker commented Aug 6, 2016

brianteeman commented Aug 6, 2016 • edited

brianteeman commented Aug 6, 2016

brianteeman Aug 6, 2016 • edited

Choose a reason for hiding this comment

zero-24 commented Aug 6, 2016

zero-24 commented Aug 6, 2016

mbabker commented Aug 6, 2016

zero-24 commented Aug 6, 2016

zero-24 commented Aug 6, 2016

roland-d commented Aug 6, 2016

mbabker commented Aug 6, 2016

brianteeman commented Aug 6, 2016

roland-d commented Aug 6, 2016

brianteeman commented Aug 6, 2016

mbabker commented Aug 6, 2016

andrepereiradasilva commented Aug 6, 2016

infograf768 commented Aug 7, 2016

alikon commented Aug 7, 2016

AlexRed commented Aug 7, 2016

nikosdion commented Aug 7, 2016

PhilETaylor commented Aug 7, 2016 • edited

ggppdk commented Aug 7, 2016 • edited

andrepereiradasilva commented Aug 7, 2016 • edited

wilsonge Aug 7, 2016

Choose a reason for hiding this comment

mbabker commented Aug 7, 2016

mbabker commented Aug 7, 2016

andrepereiradasilva commented Aug 7, 2016

andrepereiradasilva commented Aug 7, 2016

ggppdk commented Aug 7, 2016

mbabker commented Aug 7, 2016

elkuku Aug 7, 2016

Choose a reason for hiding this comment

elkuku commented Aug 7, 2016

dgrammatiko commented Aug 7, 2016

jeckodevelopment commented Aug 8, 2016

mbabker commented Aug 8, 2016

andrepereiradasilva commented Aug 8, 2016

wilsonge commented Aug 8, 2016

brianteeman commented Aug 11, 2016

mbabker commented Aug 6, 2016 •

edited by joomla-cms-bot

brianteeman commented Aug 6, 2016 •

edited

brianteeman Aug 6, 2016 •

edited

PhilETaylor commented Aug 7, 2016 •

edited

ggppdk commented Aug 7, 2016 •

edited

andrepereiradasilva commented Aug 7, 2016 •

edited