added show/hide introtext parameter to mod_articles_news #11564

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
10 participants
@coolcat-creations
Contributor

coolcat-creations commented Aug 11, 2016

Summary of Changes

Added a show_introtext parameter to the newsflash module

Testing Instructions

Before applying the patch publish a Newsflashmodule

  1. After applying the patch look if the introtext is still shown as default
  2. Set Introtext to Hide -> Introtext should be hidden
  3. Set Introtext to Show -> Introtext should be shown

Documentation Changes Required

image

@@ -23,6 +23,8 @@ MOD_ARTICLES_NEWS_FIELD_SEPARATOR_DESC="Show separator after last Article."
MOD_ARTICLES_NEWS_FIELD_SEPARATOR_LABEL="Show Last Separator"
MOD_ARTICLES_NEWS_FIELD_TITLE_DESC="Show or hide the Article title."
MOD_ARTICLES_NEWS_FIELD_TITLE_LABEL="Show Article Title"
+MOD_ARTICLES_NEWS_FIELD_SHOWINTROTEXT_DESC="Select Show if you would like the introtext to be displayed."

This comment has been minimized.

@jeckodevelopment

jeckodevelopment Aug 11, 2016

Member

For consistency with the string MOD_ARTICLES_NEWS_FIELD_TITLE_DESC you could consider to change the description in this way:

Show or hide the introtext

@jeckodevelopment

jeckodevelopment Aug 11, 2016

Member

For consistency with the string MOD_ARTICLES_NEWS_FIELD_TITLE_DESC you could consider to change the description in this way:

Show or hide the introtext

This comment has been minimized.

@jeckodevelopment

jeckodevelopment Aug 11, 2016

Member

in administrator/language/en-GB/en-GB.com_content.ini
we use "Intro Text" as separate words

@jeckodevelopment

jeckodevelopment Aug 11, 2016

Member

in administrator/language/en-GB/en-GB.com_content.ini
we use "Intro Text" as separate words

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Aug 11, 2016

Contributor

please have a look here: coolcat-creations#4 the option needs to be enabled by default for B/C 😄

Contributor

zero-24 commented Aug 11, 2016

please have a look here: coolcat-creations#4 the option needs to be enabled by default for B/C 😄

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Aug 11, 2016

Contributor

@zero-24 i enabled it by default ?

Contributor

coolcat-creations commented Aug 11, 2016

@zero-24 i enabled it by default ?

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Aug 11, 2016

Contributor

@jeckodevelopment that´s why i copied the text/translation and the parameter name from the mod_articles_category ?
I can change it of course, but should i change it then in mod_articles_category also ?

Contributor

coolcat-creations commented Aug 11, 2016

@jeckodevelopment that´s why i copied the text/translation and the parameter name from the mod_articles_category ?
I can change it of course, but should i change it then in mod_articles_category also ?

@zero-24

This comment has been minimized.

Show comment
Hide comment
Contributor

zero-24 commented Aug 11, 2016

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Aug 11, 2016

Contributor

@zero-24 sorry seems i enabled it without comitting :-D (facepalm) ;)

Contributor

coolcat-creations commented Aug 11, 2016

@zero-24 sorry seems i enabled it without comitting :-D (facepalm) ;)

Merge pull request #4 from zero-24/patch-14
default needs to be enabled by default for B/C
@jeckodevelopment

This comment has been minimized.

Show comment
Hide comment
@jeckodevelopment

jeckodevelopment Aug 11, 2016

Member

@designbengel let's wait for @brianteeman 's opinion :)

Member

jeckodevelopment commented Aug 11, 2016

@designbengel let's wait for @brianteeman 's opinion :)

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 12, 2016

Contributor

Can you change the label to
"Show Intro Text"
and the description to
"Show or hide the article intro text."

I've been trying to standardise on that and have an RTC pull request to fix most of the remaining instances

(note to self to review our usage of "intro text" and "introtext"

Contributor

brianteeman commented Aug 12, 2016

Can you change the label to
"Show Intro Text"
and the description to
"Show or hide the article intro text."

I've been trying to standardise on that and have an RTC pull request to fix most of the remaining instances

(note to self to review our usage of "intro text" and "introtext"

@1apweb

This comment has been minimized.

Show comment
Hide comment
@1apweb

1apweb Aug 12, 2016

I have tested this item 🔴 unsuccessfully on 59efa71

Hi,
Show: the whole article appears
Hide: the article does not appear


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

1apweb commented Aug 12, 2016

I have tested this item 🔴 unsuccessfully on 59efa71

Hi,
Show: the whole article appears
Hide: the article does not appear


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Aug 12, 2016

Contributor

@1apweb is that not the expected behavior? What did not work?

Contributor

zero-24 commented Aug 12, 2016

@1apweb is that not the expected behavior? What did not work?

@1apweb

This comment has been minimized.

Show comment
Hide comment
@1apweb

1apweb Aug 12, 2016

I have tested this item successfully on 59efa71

Sorry, its ok now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

1apweb commented Aug 12, 2016

I have tested this item successfully on 59efa71

Sorry, its ok now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

@truptikagathara

This comment has been minimized.

Show comment
Hide comment
@truptikagathara

truptikagathara Aug 13, 2016

I have tested this item successfully on 8c0e15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

I have tested this item successfully on 8c0e15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Aug 13, 2016

Contributor

@1apweb & @truptikagathara thank you for testing

Contributor

coolcat-creations commented Aug 13, 2016

@1apweb & @truptikagathara thank you for testing

@mikeveeckmans

This comment has been minimized.

Show comment
Hide comment
@mikeveeckmans

mikeveeckmans Aug 13, 2016

I have tested this item successfully on 8c0e15a

patch tested and works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

I have tested this item successfully on 8c0e15a

patch tested and works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 13, 2016

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

Contributor

brianteeman commented Aug 13, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 13, 2016

@brianteeman brianteeman added this to the Joomla 3.7.0 milestone Aug 13, 2016

@yvesh

This comment has been minimized.

Show comment
Hide comment
@yvesh

yvesh Aug 13, 2016

Member

I have tested this item successfully on 8c0e15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

Member

yvesh commented Aug 13, 2016

I have tested this item successfully on 8c0e15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
Contributor

coolcat-creations commented Aug 13, 2016

Thank you @yvesh @mikeveeckmans @brianteeman @jeckodevelopment @1apweb @truptikagathara @zero-24 - for supporting my first PR ;)

@jeckodevelopment

This comment has been minimized.

Show comment
Hide comment
@jeckodevelopment

jeckodevelopment Aug 13, 2016

Member

you're welcome @designbengel , thank you for your PR :)

Member

jeckodevelopment commented Aug 13, 2016

you're welcome @designbengel , thank you for your PR :)

wilsonge added a commit that referenced this pull request Sep 3, 2016

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Sep 3, 2016

Contributor

Merged to the 3.7.x branch with 84b6c70. Thanks Elisa!

Contributor

wilsonge commented Sep 3, 2016

Merged to the 3.7.x branch with 84b6c70. Thanks Elisa!

@wilsonge wilsonge closed this Sep 3, 2016

@brianteeman brianteeman removed the RTC label Sep 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment