Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE drag&drop toolbar editing #11926

Merged
merged 41 commits into from Dec 6, 2016

Conversation

Projects
None yet
9 participants
@Fedik
Copy link
Contributor

commented Sep 4, 2016

Summary of Changes

The pull request add ability to drag&drop toolbar editing to help to configure TinyMCE editor.

How it works

screen 2016-09-11 13 50 00 1374x694

  1. Available buttons, and menu (Source panel). Which can be used for build your own toolbar.
  2. Your toolbar (Target panel). Drop here an available buttons.
  3. The tabs of Sets. By default it is 3 set. but it can be unlimited. Number of the sets can be changed in advanced tab:
    screen 2016-09-11 13 50 17 573x202
  4. The Builder have 3 preset: Simple, Medium, Advanced, which can be used for quick setup. The Clear button will clear the canvas.
  5. Access level for a current Set.
  6. The form with additional options for a current Set.
  7. Drop zone for Menubar.
  8. Drop zone for Toolbar1.
  9. Drop zone for Toolbar2.

How to add button to my toolbar?
Drag the button from Source panel (1) to Target panel (2), and drop it there.

How to remove the button?
Drag&drop unneeded button out of the Target panel (2).

I want more Sets!!!
Set the amount of sets in the advanced tab. A new sets will appears after save.

Testing Instructions

it does not ready for final test

First of all make sure if the drag&drop editing works.
Then need to check that all existing features still works, as here is huge code changes.

Documentation Changes Required

Update info about how to configure TinyMCE plugin (if there any).

B. C.

It can break half of user settings for TinyMCE plugin. So need to test each case: new installation, update.

After upgrade or on clear installation the editor will use next default presets:

  • Advanced => for Special access level
  • Medium => for Registered
  • Simple => for everyone else

Help needed

I made 3 presets: Simple, Medium, Advanced.

Would be cool if someone will improve them, and make it more real for what user need.
Also would be cool if they will be similar to "old toolbar", so we will keep B/C a little bit 馃槈
It is easy to edit, just add needed buttons in: https://github.com/Fedik/joomla-cms/blob/0b4d803c35c3995934b017f74496d0c3c26f8bb0/plugins/editors/tinymce/tinymce.php#L1064-L1106

P.S.
I found that make editing depend from "view level" is not as good as I thought on start 馃槃
So I have an idea to change it a bit. And make a "Presets" so user can set access level for each "Preset". Also it will allow to use separated "Preset" for each user It is already implemented 馃槈

I would like to hear the feedback 馃槈

The pull depending from #11157. But can be tested stand alone.

Fedik added some commits Jul 3, 2016

Sync. Merge branch 'master' into tinymce-scriptoptions
Conflicts:
	plugins/editors/tinymce/tinymce.php
Sync. Merge branch 'master' into tinymce-scriptoptions
Conflicts:
	plugins/editors/tinymce/tinymce.php
Sync. Merge branch 'master' into tinymce-config
Conflicts:
	plugins/editors/tinymce/tinymce.php
	plugins/editors/tinymce/tinymce.xml
@Fedik

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2016

@brianteeman @infograf768 is it what you asked in #10996?

Sync. Merge branch 'master' into tinymce-config
 Conflicts:
	plugins/editors/tinymce/tinymce.php
@Fedik

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2016

fixed

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2016

@infograf768

This comment has been minimized.

Copy link
Member

commented Nov 17, 2016

One question:
what happens when a user group has multiple viewing access?

Example:
screen shot 2016-11-17 at 10 39 20

Will managers get the Special access setting or one of the others (Registered, Customer Access Level)?

@Fedik

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2016

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2016

Alternatively and If you are using a flat acl because you are doing role based acl you can also just create new editor groups. Basic editor, advanced editor etc

@infograf768

This comment has been minimized.

Copy link
Member

commented Nov 17, 2016

it will take higher, or last in the order

Does that mean that in the case above, Managers would get the Special access setting?

@Fedik

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2016

it will take the last one from the array of the user view levels, that come from $user->getAuthorisedViewLevels()
so it will depend from the ordering, for your example

@brianteeman brianteeman changed the title [RFC] TinyMCE drag&drop toolbar editing TinyMCE drag&drop toolbar editing Dec 4, 2016

@dgrammatiko

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

I have tested this item successfully on 58eb3bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11926.

@dgrammatiko

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

Thank you @Fedik
RTC

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 6, 2016

@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Dec 6, 2016

@rdeutz rdeutz merged commit cd33086 into joomla:staging Dec 6, 2016

3 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Dec 6, 2016

@Fedik Fedik deleted the Fedik:tinymce-config branch Dec 7, 2016

@infograf768

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

@Fedik
REGRESSION: Looks like this broke automatic language detection
See #13343
also see
#13344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.