Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin-definable fields in login modules / views #12061

Closed

Conversation

Projects
None yet
4 participants
@nikosdion
Copy link
Contributor

commented Sep 17, 2016

This PR contains the PLT-accepted portion of gh-11778 See that PR for the history of this feature.

Pinging @wilsonge and @jeckodevelopment

The changes made allow authentication plugins to render their own fields in the login modules and the login views of com_users. This is necessary for social network authentication, single sign on integration and generally any authentication method which does not rely on a Joomla-provided username/password pair.

No further instructions provided as this feature has already been approved by the PLT.

Plugin-definable fields in login modules / views
This PR contains the PLT-accepted portion of gh-11778

The changes made allow authentication plugins to render their own fields in the login modules and the login views of com_users. This is necessary for social network authentication, single sign on integration and generally any authentication method which does not rely on a Joomla-provided username/password pair.
@zero-24

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2016

Thank you for doing this! I can have a look into the travis problems and provide a PR if i'm back from #jd16de 👍 Thanks.

@jeckodevelopment

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

Thank you very much @nikosdion
I'd be very happy to see the other part of the PR as "official extension". Let me know if you are interested! :)

Obviously, even if PLT approved this new feature, this PR needs tests.

@nikosdion

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2016

@jeckodevelopment Yes, I am interested in doing that. I won't have time before mid-October as I'm about to do the single most important commit of my life: getting married :D Please let me know what is the best way to contact you when I'm back to normal so we can set up a repository and I can start committing code there.

@jeckodevelopment

This comment has been minimized.

Copy link
Member

commented Sep 18, 2016

@nikosdion happy to read both that news: leading the extension and the wedding 😄
Best way to get in touch with me? email luca.marzo[at]community.joomla.org or via Glip.
We'll setup the repository so you can work at the extension.
Thank you for the help!

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2016

nikosdion and others added some commits Sep 20, 2016

@nikosdion

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2016

I refuse to participate in this project due to lack of transparency and respect to its contributors. I forbid you from using the code in this PR in future versions of Joomla!.

@nikosdion nikosdion closed this Dec 11, 2016

@nikosdion nikosdion deleted the nikosdion:feature/login-improvements branch Dec 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.