Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating modes in JRouter #12165

Merged
merged 1 commit into from Sep 25, 2016
Merged

Deprecating modes in JRouter #12165

merged 1 commit into from Sep 25, 2016

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Sep 24, 2016

This deprecates modes in JRouter. This simply marks the methods and members as deprecated for 4.0. We will not need modes in Joomla 4.0 anymore, The idea is to have this behavior replicated with specific rules and adding or removing those rules based on configuration.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Sep 24, 2016
@zero-24 zero-24 added this to the Joomla 3.6.3 milestone Sep 24, 2016
@rdeutz rdeutz merged commit 4ade612 into joomla:staging Sep 25, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 25, 2016
@zero-24
Copy link
Member

zero-24 commented Sep 25, 2016

@Hackwar can you send the needed changes to remove that code against the 4.0-dev branch?

@Hackwar
Copy link
Member Author

Hackwar commented Sep 25, 2016

Feel free to follow my progress on J4 routing here: https://github.com/Hackwar/joomla-cms/tree/j4routing

@zero-24
Copy link
Member

zero-24 commented Sep 25, 2016

👍

csthomas pushed a commit to csthomas/joomla-cms that referenced this pull request Sep 26, 2016
@Hackwar Hackwar deleted the patch-7 branch April 27, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants