New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla 4.0: Removing JNode and JTree #12305

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
3 participants
@Hackwar
Member

Hackwar commented Oct 4, 2016

This PR removes JNode and JTree. Both classes have been broken basically since Joomla 1.5.

I'm actually a bit torn on this one. Yes, the current code is crap and should not be used, but at the same time I would love to have a proper interface for a tree structure and its nodes. It would be nice to have the categories and menu system use such a class and maybe even the user groups. However that seems to be out of the scope for 4.0 and might even be a performance issue.

Long story short: Scrap this and be done with it.

Oh, and I took the liberty of removing the reference to JSimpleCrypt.

@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 4, 2016

@wilsonge wilsonge merged commit 302f757 into joomla:4.0-dev Oct 4, 2016

2 checks passed

continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wilsonge

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment