Joomla 4.0: Removing JNode and JTree #12305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs removed without replacement https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4#Classes_Removed_Without_Replacement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes JNode and JTree. Both classes have been broken basically since Joomla 1.5.
I'm actually a bit torn on this one. Yes, the current code is crap and should not be used, but at the same time I would love to have a proper interface for a tree structure and its nodes. It would be nice to have the categories and menu system use such a class and maybe even the user groups. However that seems to be out of the scope for 4.0 and might even be a performance issue.
Long story short: Scrap this and be done with it.
Oh, and I took the liberty of removing the reference to JSimpleCrypt.