[com_joomlaupdate] Check for minimum supported database type and version #12355

Merged
merged 7 commits into from Oct 18, 2016

Conversation

Projects
None yet
7 participants
@zero-24
Contributor

zero-24 commented Oct 8, 2016

Pull Request for Issue #12351

Summary of Changes

This implements a minimum database feature into com_joomlaupdate so we can check for minimum supported database version per type

Testing Instructions

First Please review the code.

Test the Core

  • Install 3.7.x (https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
  • set this as custom update server http://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
  • confirm that com_joomlaupdate still points to 3.7.0-dev2
  • apply this patch
  • confirm that com_joomlaupdate still points to 3.7.0-dev2
  • Do NOT install this update
  • change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml
  • confirm that you get the We can't find a download URL .... message in com_joomlaupdate
  • change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list3.xml
  • confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)

Test Extensions

Documentation Changes Required

Document the new tag if implemented as this can also be used by 3party extensions

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Oct 8, 2016

Member

JText::_($db->name)

We have language strings for all the database names.

JText::_($db->name)

We have language strings for all the database names.

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

Thanks fixed with 5c07334

Contributor

zero-24 replied Oct 8, 2016

Thanks fixed with 5c07334

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Oct 8, 2016

Member

You don't need to change this variable name. It's only getting used to create the message.

You don't need to change this variable name. It's only getting used to create the message.

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

fixed with: 5c07334

Contributor

zero-24 replied Oct 8, 2016

fixed with: 5c07334

@@ -527,6 +527,8 @@ JLIB_INSTALLER_ABORT_TPL_INSTALL_FAILED_CREATE_DIRECTORY="Template Install: Fail
JLIB_INSTALLER_ABORT_TPL_INSTALL_ROLLBACK="Template Install: %s"
JLIB_INSTALLER_ABORT_TPL_INSTALL_UNKNOWN_CLIENT="Template Install: Unknown client type [%s]"
JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s is available, but it requires at least PHP version %3$s while your system only has %4$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s in version %4$s is not supported please contact your host in to update you Databseversion at least to version %5$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_TYPE="For the extension %1$s version %2$s is available, but your current database %3$s is not supported anymore"

This comment has been minimized.

@brianteeman

brianteeman Oct 8, 2016

Contributor

Add a full stop at the end

@brianteeman

brianteeman Oct 8, 2016

Contributor

Add a full stop at the end

@@ -527,6 +527,8 @@ JLIB_INSTALLER_ABORT_TPL_INSTALL_FAILED_CREATE_DIRECTORY="Template Install: Fail
JLIB_INSTALLER_ABORT_TPL_INSTALL_ROLLBACK="Template Install: %s"
JLIB_INSTALLER_ABORT_TPL_INSTALL_UNKNOWN_CLIENT="Template Install: Unknown client type [%s]"
JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s is available, but it requires at least PHP version %3$s while your system only has %4$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s in version %4$s is not supported please contact your host in to update you Databseversion at least to version %5$s"

This comment has been minimized.

@brianteeman

brianteeman Oct 8, 2016

Contributor

Lets fix the germish ;)

+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s is version %4$s and is not supported. Please contact your web host to update you Database version to at least version %5$s."

@brianteeman

brianteeman Oct 8, 2016

Contributor

Lets fix the germish ;)

+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s is version %4$s and is not supported. Please contact your web host to update you Database version to at least version %5$s."

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

Thanks fixed @brianteeman

Contributor

zero-24 commented Oct 8, 2016

Thanks fixed @brianteeman

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 8, 2016

Contributor

Tried to test this but at this point
change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml
confirm that you get the You don't support the minimum .... message in com_joomlaupdate

I get the "We can't find a download URL" message

Contributor

brianteeman commented Oct 8, 2016

Tried to test this but at this point
change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml
confirm that you get the You don't support the minimum .... message in com_joomlaupdate

I get the "We can't find a download URL" message

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

@brianteeman yes this is the correct message. On writing the instructions i did not had the title in my mind.

Contributor

zero-24 commented Oct 8, 2016

@brianteeman yes this is the correct message. On writing the instructions i did not had the title in my mind.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 8, 2016

Contributor

confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)

Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?

Contributor

brianteeman commented Oct 8, 2016

confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)

Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

i have just fixed the instructions thanks!

Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?

99.5.3 is used in test 2. ;) -> The reason you don't get the update

The 3. is just a test to make sure nothing breaks and you get the update if you meat the requirements

Contributor

zero-24 commented Oct 8, 2016

i have just fixed the instructions thanks!

Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?

99.5.3 is used in test 2. ;) -> The reason you don't get the update

The 3. is just a test to make sure nothing breaks and you get the update if you meat the requirements

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 8, 2016

Contributor

Extension update. The message I get is

onrz

This is confusing - the first sentence will lead me to think that the problem is that I can not connect to the update server

Contributor

brianteeman commented Oct 8, 2016

Extension update. The message I get is

onrz

This is confusing - the first sentence will lead me to think that the problem is that I can not connect to the update server

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

That are 2 different errors ;) The first one is from the test report extension (see: #12258) and the seccond warning is my warning so everything works as expected.

Contributor

zero-24 commented Oct 8, 2016

That are 2 different errors ;) The first one is from the test report extension (see: #12258) and the seccond warning is my warning so everything works as expected.

@@ -527,6 +527,8 @@ JLIB_INSTALLER_ABORT_TPL_INSTALL_FAILED_CREATE_DIRECTORY="Template Install: Fail
JLIB_INSTALLER_ABORT_TPL_INSTALL_ROLLBACK="Template Install: %s"
JLIB_INSTALLER_ABORT_TPL_INSTALL_UNKNOWN_CLIENT="Template Install: Unknown client type [%s]"
JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s is available, but it requires at least PHP version %3$s while your system only has %4$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s is version %4$s and is not supported. Please contact your web host to update you Database version to at least version %5$s."

This comment has been minimized.

@brianteeman

brianteeman Oct 8, 2016

Contributor

oops - my fault - missed one

to update you Database version
==>
to update your Database version

@brianteeman

brianteeman Oct 8, 2016

Contributor

oops - my fault - missed one

to update you Database version
==>
to update your Database version

This comment has been minimized.

@zero-24

zero-24 Oct 8, 2016

Contributor

fixed: a2647cd

@zero-24

zero-24 Oct 8, 2016

Contributor

fixed: a2647cd

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 8, 2016

Contributor

OK - all good then. - But they are warnings - should they be errors?

Also I missed a typo

On 8 October 2016 at 21:55, zero-24 notifications@github.com wrote:

That are 2 different errors ;) The first one is from the test report
extension (see: #12258 #12258)
and the seccond warning is my warning so everything works as expected.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RfrxpHDyULUFVikbhfo-MY97sKGks5qyANDgaJpZM4KR0KZ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Contributor

brianteeman commented Oct 8, 2016

OK - all good then. - But they are warnings - should they be errors?

Also I missed a typo

On 8 October 2016 at 21:55, zero-24 notifications@github.com wrote:

That are 2 different errors ;) The first one is from the test report
extension (see: #12258 #12258)
and the seccond warning is my warning so everything works as expected.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RfrxpHDyULUFVikbhfo-MY97sKGks5qyANDgaJpZM4KR0KZ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 8, 2016

Contributor

OK - all good then.

Thanks!

But they are warnings - should they be errors?

I can do both i have set is at warning as the PHP Minimum message is also just a warning.

Contributor

zero-24 commented Oct 8, 2016

OK - all good then.

Thanks!

But they are warnings - should they be errors?

I can do both i have set is at warning as the PHP Minimum message is also just a warning.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 8, 2016

Contributor

I have tested this item successfully on a2647cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

Contributor

brianteeman commented Oct 8, 2016

I have tested this item successfully on a2647cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 8, 2016

Contributor

OK - I am not bothered myself if its a warning or error

On 8 October 2016 at 22:02, zero-24 notifications@github.com wrote:

OK - all good then.

Thanks!

But they are warnings - should they be errors?

I can do both i have set is at warning as the PHP Minimum message is also
just a warning.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8afmto0MtIZdiV3nmn-bYOdGgGWmks5qyATJgaJpZM4KR0KZ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Contributor

brianteeman commented Oct 8, 2016

OK - I am not bothered myself if its a warning or error

On 8 October 2016 at 22:02, zero-24 notifications@github.com wrote:

OK - all good then.

Thanks!

But they are warnings - should they be errors?

I can do both i have set is at warning as the PHP Minimum message is also
just a warning.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8afmto0MtIZdiV3nmn-bYOdGgGWmks5qyATJgaJpZM4KR0KZ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

+ );
+
+ JFactory::getApplication()->enqueueMessage($dbMsg, 'warning');
+

This comment has been minimized.

@yvesh

yvesh Oct 9, 2016

Member

One empty line too much ;)

@yvesh

yvesh Oct 9, 2016

Member

One empty line too much ;)

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Oct 10, 2016

@jeckodevelopment

This comment has been minimized.

Show comment
Hide comment
@jeckodevelopment

jeckodevelopment Oct 17, 2016

Member

I have tested this item successfully on ce23227


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

Member

jeckodevelopment commented Oct 17, 2016

I have tested this item successfully on ce23227


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 18, 2016

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

Contributor

brianteeman commented Oct 18, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Oct 18, 2016

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

Contributor

brianteeman commented Oct 18, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.

@joomla-cms-bot joomla-cms-bot added the RTC label Oct 18, 2016

@rdeutz rdeutz merged commit 0af7caf into joomla:staging Oct 18, 2016

3 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 18, 2016

Contributor

Thanks!

Contributor

zero-24 commented Oct 18, 2016

Thanks!

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Mar 18, 2017

Contributor

I have just added the option supported_databases to this doku: https://docs.joomla.org/Deploying_an_Update_Server

Contributor

zero-24 commented Mar 18, 2017

I have just added the option supported_databases to this doku: https://docs.joomla.org/Deploying_an_Update_Server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment