New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Contact urls for linked authors (New) #12629

Merged
merged 2 commits into from Nov 5, 2016

Conversation

Projects
None yet
8 participants
@Hackwar
Member

Hackwar commented Oct 30, 2016

Pull Request for Issue #12603, redo of #12616

Summary of Changes

Used the right method to generate that URL.

Testing Instructions

Create a contact for the super user
Create some articles
Create a menu item to display one or multiple articles, do NOT make it the home page.
Create a menu item displaying the Contact category to which belongs the super user contact: alias is english-contacts in this case.
Do NOT create a menu item displaying the single contact.
Display the article in frontend.
Click on the Super User link in the article intro
See that the link is not correct.
Apply patch and see that the link is correct.

Documentation Changes Required

none

@infograf768

This comment has been minimized.

Member

infograf768 commented Oct 30, 2016

I have tested this item successfully on 21a2787


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12629.

@Hackwar

This comment has been minimized.

Member

Hackwar commented Oct 30, 2016

Sorry, still had to add the JLoader call.

@infograf768

This comment has been minimized.

Member

infograf768 commented Oct 30, 2016

I have tested this item successfully on d78a276


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12629.

@conconnl

This comment has been minimized.

conconnl commented Nov 4, 2016

I have tested this item successfully on d78a276

Tested successfully at PBF NL


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12629.

@roland-d roland-d added this to the Joomla 3.7.0 milestone Nov 4, 2016

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.0 milestone Nov 4, 2016

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 4, 2016

@zero-24

This comment has been minimized.

Contributor

zero-24 commented Nov 4, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12629.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 4, 2016

@rdeutz rdeutz merged commit 76c215f into joomla:staging Nov 5, 2016

3 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Nov 5, 2016

nvyush added a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016

Fixing Contact urls for linked authors (New) (joomla#12629)
* Fixing URLs in plg_content_contact

* Replacing require_once with class loader
@Meavin

This comment has been minimized.

Meavin commented on d78a276 Apr 14, 2018

Hello There!
Could you please help me by providing little information on what exact files to be replaced? or if possible please let me have the changed file to upload. Thank you in advance!
-Meavin

This comment has been minimized.

Contributor

zero-24 replied Apr 15, 2018

@Meavin please do not comment on commits and also that commit is from 2016 please open a new issue so we can keep track of any issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment