Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in sr-YU installation ini file #12984

Merged
merged 1 commit into from Nov 23, 2016
Merged

Error in sr-YU installation ini file #12984

merged 1 commit into from Nov 23, 2016

Conversation

infograf768
Copy link
Member

Corrected EOL and a wrong string.
Can be merged on review.
@Bakual

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Nov 23, 2016
@Bakual Bakual merged commit 354d178 into joomla:staging Nov 23, 2016
@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Nov 23, 2016
@Bakual Bakual added this to the Joomla 3.7.0 milestone Nov 23, 2016
@infograf768 infograf768 deleted the sr-YU_correction branch November 23, 2016 08:11
@PhilETaylor

This comment was marked as abuse.

Sign in to view
@infograf768
Copy link
Member Author

@PhilETaylor

Only one string is changed !
The rest is EOL

@infograf768
Copy link
Member Author

The Serbian TT is OK!
Re: correction sr-YU ini installation file
Sent: 23 Nov 2016 08:42
From: cicans
Recipient: infograf768
Thank you JM I corrected this

@Bakual
Copy link
Contributor

Bakual commented Nov 23, 2016

@PhilETaylor Usually, they are commited directly by me, not even going though a PR. Apparently I have messed up a file and thus JM made a PR to correct it. All fine 😄

@PhilETaylor

This comment was marked as abuse.

Sign in to view
@jeckodevelopment
Copy link
Member

jeckodevelopment commented Nov 23, 2016 •
edited

We either have a policy of 2 successful tests of a PR - or we dont.

We do. But when the PR is obviously easy, maintainers sometimes merge on review.
This is just a string and EOL fix. Don't think we should waste time on testing it. Code is public.

@PhilETaylor

This comment was marked as abuse.

Sign in to view
@Bakual
Copy link
Contributor

Bakual commented Nov 23, 2016

We either have a policy of 2 successful tests of a PR - or we dont.

We don't have a policy of 2 successful tests at all. It's a rule of thumb, but for some PRs we expect more tests and some less (eg codestyle ones).
Installation language files always are commited directly, there never was an issue with that approach so far. Chance that something breaks here is slim anyway. It's only INI files 😄

@PhilETaylor

This comment was marked as abuse.

Sign in to view
@Bakual
Copy link
Contributor

Bakual commented Nov 23, 2016

And you dont see a problem here...

No. Because it doesn't make sense to require two tests for a doc block change.

so im falling on deaf ears again. and again.

I hear you loud and clear and respect you very much, but I don't agree with your opinion in this case. That's not being deaf.

roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016
@roland-d
Merge branch 'staging' into shareable-draft-content-feature
4823b55 
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010)
  Removing duplicated AS in sql query (joomla#13006)
  Fixed typo in comment (joomla#12992)
  Correcting strings in TFA Google plugin (joomla#12980)
  code style changes (joomla#12986)
  Error in sr-YU installation ini file (joomla#12984)
  New DateTime picker (replaces calendar) (joomla#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (joomla#12763)
  Added Feature items filter to mod_articles_news (joomla#12547)
  fix them all (joomla#12943)
  a11y regression fix (joomla#12935)
  Set correct component id for system links (joomla#12938)
  Fix for Undefined offset in Content History preview popup (joomla#12791)
  remove tab on meta charset (joomla#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928)
  [JHtmlNumber::bytes] Format number according to language (joomla#12929)
  Update edit.php (joomla#12818)
  Update default.xml (joomla#12917)
  Adding the ability to use the global value for character count in newsfeeds (joomla#12869)
  ...
wilsonge pushed a commit that referenced this pull request Dec 15, 2016
@infograf768
Error in sr-YU installation ini file (#12984)
dae6da5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@infograf768 @PhilETaylor @Bakual @jeckodevelopment @joomla-cms-bot