Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla 4.0: Removing modern SEF option #13021

Merged
merged 7 commits into from Dec 18, 2016
Merged

Joomla 4.0: Removing modern SEF option #13021

merged 7 commits into from Dec 18, 2016

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Nov 25, 2016

This removes the option for modern routing from the components configuration.

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 26, 2016

@Hackwar i think you also need to remove showon="sef_advanced:1" in sef ids field

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Nov 26, 2016

Yes, you are right. Done.

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 26, 2016

@Hackwar since 4.0 is a B/C break version shouldn't the default for sef_ids be 1 ?
Not sure what's the level of B/C allowed here ...

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 26, 2016

I have tested this item successfully on de045c1

anyway this is not what this PR does, so tested with success on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13021.

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Nov 26, 2016

I don't want to remove the IDs by default. We are just using the modern routing in all cases, but otherwise that is just another option that people can select. So keeping that 0 is correct for me. 😄

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 26, 2016

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 26, 2016

I have tested this item 🔴 unsuccessfully on de045c1

as comments above


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13021.

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Nov 27, 2016

Removed the option in com_users, too.

@wilsonge wilsonge merged commit fd5aca5 into joomla:4.0-dev Dec 18, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zero-24 zero-24 added this to the Joomla 4.0 milestone Dec 18, 2016
@Hackwar Hackwar deleted the Hackwar:patch-14 branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants