Menu manager for Joomla Backend Menu #13036

Merged
merged 37 commits into from Jan 17, 2017

Projects

None yet
@izharaazmi
Contributor
izharaazmi commented Nov 27, 2016 edited

Pull Request for issue joomla/joomla-cms#5492

Summary of Changes

Currently we have menu and menu items for front-end that we manage via Menu Manager. However, for the Backend Menu we do not have any choice. We are bound to use that statically hardcoded menu since long time now.

With this PR I am proposing the flexibility and control over the menu and menu items for Joomla Backend like we have for the Front-end. You can now create, edit, move and organise the menu links the way you like. And if like you can still use the "preset menu" shipped by default with Joomla without any customisation at all.

After this patch you'll have one extra dropdown in Menu manager lists viz. "Client" that can be used to switch between whether you are managing menu and menu items for Front-end or Backend.

When you have client filter "Administrator" selected in the list, clicking on "New" will take you to the Backend Menu Item creation page only. Having "Site" selected will get you a form to create Front-end menu/menu item likewise. This behavior is certainly not new for us, this can be seen in the existing Module Manager already.

The list of available menu type options are taken the same way that it did for front-end menu type options earlier. All the menu items that exists currently can be created using the Menu Manager in a custom Menu. Then it can be published in the mod_menu for backend, which currently is using a hardcoded menu.

Notes

  • How will my administrator interface looks change after this?
    It will look exactly the same as before. The appearance is only affected if you choose to customise your backend menu via Menu Manager.

  • What do I need to learn to use this new Menu Manager?
    Almost Nothing! If you are familiar with the existing Menu Manager and have used it to create menu and menu items for front-end, then you will feel at home. Everything remains the same. When creating a menu item for backend you will see the options related to backend only. Similarly, you will see only front-end options when you create a menu item for front-end.

  • Where do the menu links gets created for NEW components that I install?
    The menu links are created in the same way as before for every new component installation. You can create a "Heading" type menu item (say, "New Components") and set the flag "Components Root" to "Yes". This will pull all those menu items under "New Components".
    Please note, that this component root is NOT required to be a Top level menu item, it can be any level down.

  • How can I remove an auto created component menu item from the Component Root parent after I have created my own menu item for it at desired location?
    In the menu items list view, set the menu type filter to "Main (Protected)". You will see all those automatically generated menu items there. Just unpublish the desired items. If the component root has not children to show, the component root will also be hidden automatically.

    Deleting them should not cause any side effect, however its not recommended to do so. Editing these items is disabled to avoid undesirable consequences.

    Please note that if you decide to switch back to the "preset" menu anytime, these auto-generated Menu items will show up under "components" again. Due to B/C reasons preset menu does not obey published/unpublished state.

  • How can I create Multilingual versions of those backend menu items?
    Language based associations are disabled for backend menu items for consistency and simplicity. The menu title is translated during their rendering, therefore you can use LANGUAGE_KEYS and their translations to use it on multilingual websites. 1

  • Will Joomla! be shipped with a default menu created?
    Joomla! will come with built-in preset(s) which will not show up in menu manager. That would be the set as the default menu. You can use it by selecting in the Module manager mod_menu settings. If you want to create and use your own custom menu you can create an new Menu at "Menus > Add New Menu" and build your desired links under it. Next you will choose your own Menu in the Menu module settings via Module Manager.

  • What if I do not have a component root defined in my custom menu when I install new components?
    The "component root" does NOT tell Joomla where to create those menu items. It just says, where to show them. So relax, the automatic menu items will still be created in the same way as now (even without this PR) irrespective of your component root selection. If you have one it will pull them in, and if not they won't show up.
    This way we can always ensure that they will be shown exactly the same when you switch back to the preset menu for any reason.

  • I messed up my menu structure and it will take time to build it over. Can I get the default Joomla menu back?
    Absolutely! Its in there already. Just go to module manager and edit mod_menu for administrator. Choose the System Preset as your active menu. Keep it forever, or as long as you need.

  • I am an extension developer. What do I need to change in my components to make use of this new feature?
    This update will NOT cause your components to lose any links in the backend menu. If you have any Menu/Submenu under "Components" then your user will still be able to create those links in their custom menu.
    Well, Ideally you should create layout manifests for all your view/layouts that can be linked to a menu item so as to offer your users better control and flexibility over customisation.

Testing Instructions

  1. Install this patch to the latest 3.7.x branch.
  2. You may need to check database and update it from Extensions > Manage > Database and Fix. In some cases you may need to manually add client_id column to your #__menu_types table.
  3. Create a new Menu, say "Admin Menu"
  4. Go to Module Manager and Open Menu Module. Choose your new Menu as the Active Menu. The Menu from the top should disappear.
  5. Switch back to "System Preset" and the Menu should come back.
  6. Make sure the Current Menu (Preset one) is Exactly the same as before this patch. Same access checks should apply.
  7. When creating a front-end menu item no backend options should be visible. Same for the other way around.
  8. Create a few Menu Items under your "Admin Menu" and then try to set it as your Default Menu in Menu Module. Your created Links should appear.
  9. Create a Heading type menu item somewhere in your Menu. Set it as Component Root. All items that came under "Components" earlier should show under this heading now. You may need to publish them from Menu items list first.
  10. Install a new component, e.g. "JCE" and see if its menu and sub menu are populated under this component root.
  11. Try creating those menu links yourself under some other menu item or even as top level menu item. You should be able to create all those links.
  12. Do some more tests around as I may not have listed all possible test cases here.

Documentation Changes Required

Add information about this feature in the documentation.

Thanks @brianteeman for his support and valuable inputs.

1 In the edit form we can have a set of text inputs for alternative texts per installed language.

izharaazmi and others added some commits Oct 11, 2016
@izharaazmi izharaazmi Added client id column to menu_type table.
Allow creating and editing of "menutype" records with client_id = 1
Add client_id filters in menu and menu items list views
Sync menu type filter and client_id filter allowing only menu type in the URL query parameter (B/C)
Both Lists now also filtered by client id.
Client id selection updates the menu type list options to show choices only for that client id

TBD:
Reserved menu types: main & menu
5b7d6cd
@izharaazmi izharaazmi In modal list view we currently hide client_id filter and show only s…
…ite menu types, will be updated once we have more clear vision.

Menu type assignment to backend mod_menu config from both menu manager and module manager. Though that is not functional within the module itself.
e64771a
@izharaazmi izharaazmi Add/edit menu item redirect with clientId from list filter.
Load menu item form based on active client id
Menu type dropdown choices limited to active client id value
Show menu-item-type choices (modal) trigger with client id parameter in the url
Switch edit layout based on client id
22232ce
@izharaazmi izharaazmi Menu item type loading from component metadata xml or mvc not identif…
…ies backend and frontend application separately. Not yet able to load menu item type from backend so returns empty list. Front-end is still intact and unaffected.
b943a34
@izharaazmi izharaazmi Edit menu item and create menu item set to follow client id and menu …
…type value consistenty.

When creating menu item alias, the referenced menu must also belong to same client id.
Client id field removed from form, this should be auto-calculated from the menu type when saving.
574081d
@izharaazmi izharaazmi Adding layout metadata xml in backend to reference menu item types as…
… it was in front-end.

Removed unnecessary admin specific layout added earlier as it is so far same as original edit.php, may be added back when needed.
Remove page specific meta data fields from backend component type menu items.
For now disable/unsupport association for backend menu items.
Disallow change of client id for existing menu items, unexpected conflicts may occur if allowed so better be safe.

Ref to #2
e410797
@izharaazmi izharaazmi Created each backend menu items using menu manager as a replica of ex…
…isting Joomla backend menu. These are to be used for testing during upgrading menu module.

language keys are not yet translated. Translation will be done as we are ready with most new or modified language keys application wide.
Backend menu items does not require all those parameters as that with front-end menu items. Therefore segregated entire menu item xml for backend/frontend.

Ref #2
8d2ae9f
@brianteeman @rdeutz brianteeman [a11y] Protostar back to top (#12446)
* [a11y] Protostar - back to top link

* Oops Andre was right

* add anchor for non-js enabled browsers
4d44c25
@izharaazmi izharaazmi Restructure mod_menu to load preset menu items as an option (default)…
…. Other options will be the menu-type and will cause us to load from database. Ref #2
bf59761
@izharaazmi izharaazmi Disallow editing and set to home of protected menu type menu items vi…
…z. 'main' and 'menu'

Allow explicit filtering by protected menu type choices in menu items list view. Not limited to #__menutypes table entries only. Unfiltered list still excludes those menu items. (B/C ok)
Menu items created during installation of a component are now saved as published. When unpublished we won't load it in customised menu's component menu container. They will still be loaded irrespective of state as previously when preset is in use. (B/C ok)
Home page can now be set one per client instead of one overall.
Menu module only loads item from 'main' and 'menu' type menu items when requested for component menu items. This filter is now required because we are now going to have other custom menu types for backend which should not be included.

Ref #2
5e36ec2
@izharaazmi izharaazmi Load menu items from databases in correct hierarchy. Remove any extra…
… separator type menu items created due to exclusion of certain menu items based on various conditions.

Populate menu items loaded from db into the AdminCssMenu object for final rendering.
Load new installed components menu items dynamically under the specified menu item with “components container” flag. Any unpublished menu items from the protected menutypes (viz. “main” and “menu”) will be skipped.
When loading from system preset menu items, these components menu items are all included regardless of their published state. (B/C ok).

Ref #2
ff2353c
@izharaazmi izharaazmi View manifests for menu item type and related language key updates. ref 0214d76
@izharaazmi izharaazmi Minor mistake fix. 34dcfb0
@izharaazmi izharaazmi Merge branch '3.7.x' into admin-menu-manager
Ref #2
8e54a46
@izharaazmi izharaazmi Translate menu item titles in list view. Ref #2 402c7c0
@izharaazmi izharaazmi Reset the preset menu structure to be same as the current J37 branch …
…state, dropping implicit inclusion of joomla/joomla-cms#10657 improvement. Ref #2
40f913a
@izharaazmi izharaazmi Allow the existing components to leverage the menu/submenu entries in…
… their install manifest for admin menu manager menu link types.

This provides ability to create links for then without requiring them to add layout manifests. Hence, full B/C solution. Ref #2
f4a9fb6
@izharaazmi izharaazmi Minor fix 7986f86
@izharaazmi izharaazmi Remove temporary dev phase files 694614e
@izharaazmi izharaazmi Preparing for PR, database and install script updates.
Ref #2
059c9b6
@izharaazmi izharaazmi Minor fix
3286409
@infograf768
Member

This PR should be targetted at staging, not 3.7.x

@izharaazmi izharaazmi changed the base branch to joomla:staging from joomla:3.7.x Nov 27, 2016
@zero-24 zero-24 removed the PR-3.7.x label Nov 27, 2016
@izharaazmi
Contributor

Closing as I have not tested it myself against staging branch. Will reopen after tests and changes if any.

@izharaazmi izharaazmi closed this Nov 27, 2016
@izharaazmi izharaazmi changed the base branch to joomla:3.7.x from joomla:staging Nov 27, 2016
@dgt41
Member
dgt41 commented Nov 27, 2016

@izharaazmi if you press the edit button next to the title, you are able to rebase from 3.7 to staging

@izharaazmi
Contributor
@dgt41
Member
dgt41 commented Nov 27, 2016

if no conflicts come up, I guess the code will be ok

@izharaazmi
Contributor
@izharaazmi izharaazmi changed the base branch to joomla:staging from joomla:3.7.x Dec 7, 2016
@izharaazmi
Contributor

Reopening after conflicts merge and a basic testing.

@izharaazmi izharaazmi reopened this Dec 7, 2016
@brianteeman
Contributor

Something isnt correct as you have 357 changed files

@izharaazmi
Contributor
@izharaazmi izharaazmi Merge branch 'staging' into admin-menu-manager
9b8a99d
+ * Load the menu items from database for the given menutype
+ *
+ * @param string $menutype The selected menu type
+ * @param boolean $authCheck An optional switch to turn off the auth check (to support custom layouts 'grey out' behaviour).
@izharaazmi
izharaazmi Dec 7, 2016 Contributor

Travis says 2 spaces after longest variable needed, I see its already! Am I missing something?

@mbabker
mbabker Dec 7, 2016 Member

Check if there are tab characters in use.

@izharaazmi
Contributor

@brianteeman Can you please check if everything is alright now?

izharaazmi added some commits Dec 7, 2016
@izharaazmi izharaazmi CS fix
16ff8c4
@izharaazmi izharaazmi Don’t sort menu items
2454925
@infograf768
Member

Not for the fainted at heart but looks like working. ;)

Tip: when creating the new menu items for the new admin menu, always create at least 2 of them first: Menu Items and Modules

First set of remarks, in no special order:

NOTE 1: Creating modules menu gets:
screen shot 2016-12-12 at 11 01 07

Strings are wrong in modules default.xml. Missing a S
Should be
+COM_MODULES_MODULES_VIEW_DEFAULT_DESC="Shows a list of modules to manage"
+COM_MODULES_MODULES_VIEW_DEFAULT_TITLE="Module Manager"

NOTE 2: Default Page should not be present when creating an admin menu item

NOTE 3: All new lang strings should be alpha ordered

NOTE 4: Link Image will not work in Isis or Hathor

NOTE 5: Is it on purpose that one can use multiple admin menus at the same time by just publishing their respective modules?

NOTE 6: The alias limitation to not use a root folder name or component should NOT apply to admin menu items as aliases are not used here.

@izharaazmi izharaazmi Sort lang keys
Allow ‘component’ as first level alias in admin menu items
Fix lang key
Remove ‘home’ setting from admin menu items
e8de57a
@infograf768
Member

Concerning lang keys, not sure you got it.
They should be alpha ordered with the existing ones.
Example, you do

COM_CONFIG="Configuration Manager"
COM_CONFIG_XML_DESCRIPTION="Configuration Manager"

COM_CONFIG_COMPONENT_VIEW_DEFAULT_DESC="Dislay the configuration options for the selected component."
COM_CONFIG_COMPONENT_VIEW_DEFAULT_TITLE="Component Configuration Options"
COM_CONFIG_CONFIG_VIEW_DEFAULT_DESC="Displays basic site configuration options."
COM_CONFIG_CONFIG_VIEW_DEFAULT_TITLE="Site Configuration Options"
COM_CONFIG_TEMPLATES_VIEW_DEFAULT_DESC="Displays template parameter options if the template allows this."
COM_CONFIG_TEMPLATES_VIEW_DEFAULT_TITLE="Display Template Options"

it should be

COM_CONFIG="Configuration Manager"
COM_CONFIG_COMPONENT_VIEW_DEFAULT_DESC="Dislay the configuration options for the selected component."
COM_CONFIG_COMPONENT_VIEW_DEFAULT_TITLE="Component Configuration Options"
COM_CONFIG_CONFIG_VIEW_DEFAULT_DESC="Displays basic site configuration options."
COM_CONFIG_CONFIG_VIEW_DEFAULT_TITLE="Site Configuration Options"
COM_CONFIG_TEMPLATES_VIEW_DEFAULT_DESC="Displays template parameter options if the template allows this."
COM_CONFIG_TEMPLATES_VIEW_DEFAULT_TITLE="Display Template Options"
COM_CONFIG_XML_DESCRIPTION="Configuration Manager"

Thanks

libraries/legacy/table/menu.php
@@ -149,7 +149,7 @@ public function store($updateNulls = false)
$this->alias = JApplicationHelper::stringURLSafe(trim($this->alias), $this->language);
// Verify that a first level menu item alias is not 'component'.
- if ($this->parent_id == 1 && $this->alias == 'component')
+ if ($this->parent_id == 1 && $this->client_id == 0 && $this->alias == 'component')
@infograf768
infograf768 Dec 12, 2016 Member

I rather suggest to check the client for both component and folders, i.e.

		if ($this->client_id == 0)
		{
			// Verify that a first level menu item alias is not 'component'.
			if ($this->parent_id == 1 && $this->alias == 'component')
			{
				$this->setError(JText::_('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_COMPONENT'));

				return false;
			}

			// Verify that a first level menu item alias is not the name of a folder.
			jimport('joomla.filesystem.folder');

			if ($this->parent_id == 1 && in_array($this->alias, JFolder::folders(JPATH_ROOT)))
			{
				$this->setError(JText::sprintf('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_FOLDER', $this->alias, $this->alias));

				return false;
			}
		}
izharaazmi added some commits Dec 12, 2016
@izharaazmi izharaazmi apply in hathor defdcdc
@izharaazmi izharaazmi menu item alias check for site only
c1e711a
@izharaazmi
Contributor

I only moved my new keys to appropriate place alpha-orderd. Others were already there. Let us fix all those in a separate PR.

I have fixed other issues.

- $this->setError(JText::_('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_COMPONENT'));
+ // Verify that a first level menu item alias is not 'component'.
+ if ( $this->alias == 'component')
+ {
@infograf768
infograf768 Dec 12, 2016 Member

space too much after parenthesis

@infograf768
Member

I only moved my new keys to appropriate place alpha-orderd. Others were already there. Let us fix all those in a separate PR.

this is a new feature. if it is accepted, all should be fine. but this is only my opinion.
@whoever can please mark this as New feature.

@izharaazmi
Contributor

Tip: when creating the new menu items for the new admin menu, always create at least 2 of them first: Menu Items and Modules

Was that for me? If so, sorry I didn't get it.

Default Page should not be present when creating an admin menu item

Removed for now. However I intend to make it do what it says if possible, but some other day.

Is it on purpose that one can use multiple admin menus at the same time by just publishing their respective modules?

Yes, I don't see a reason not to let the users do that if they really want to.

Fixed other mentioned issues. Thanks @infograf768


PS: Not sure how this reply did not get posted. Ref to e8de57a

@infograf768
Member
Tip: when creating the new menu items for the new admin menu, always create at least 2 of them first: Menu Items and Modules

Was that for me? If so, sorry I didn't get it.

That was for testers and future users. It is easy to lose all admin menus and be forced to modify db to recover access.

@izharaazmi
Contributor

@infograf768 Thanks for your reviews and feedbacks. If you have tested this can you please mark your test status here!

@infograf768
Member

Although this apparently works, I have not yet reviewed all code and eventual consequences of the changes on other aspects of the CMS.

@izharaazmi izharaazmi Merge ‘staging’ into admin-menu-manager
28a835b
@infograf768
Member

@izharaazmi
I have asked to release responsible to decide if this could go into 3.7.0
If yes, then I will test more as there are some aspects that still need some care.

@izharaazmi
Contributor

Thanks @infograf768. Looking forward. Excited to see it soon!

@rdeutz
Contributor
rdeutz commented Dec 19, 2016

Very tempted to include it in 3.7, we need a bit more testing

@infograf768
Member

@izharaazmi
Can you think of a way to prevent such situation:

Tip: when creating the new menu items for the new admin menu, always create at least 2 of them first: Menu Items and Modules

That was for testers and future users. It is easy to lose all admin menus and be forced to modify db to recover access.

@csthomas
Contributor
csthomas commented Dec 19, 2016 edited

This link administrator/index.php?option=com_menus&view=menu&layout=edit does not work on mssql.

[Microsoft][ODBC Driver 13 for SQL Server][SQL Server]No column name was specified for column 1 of 'A'. SQL=SELECT * FROM ( SELECT count(id), ROW_NUMBER() OVER (ORDER BY (select 0)) AS RowNumber FROM j37_usergroups) A WHERE A.RowNumber BETWEEN 1 AND 1 

After added patch from #13262 start working:)

@izharaazmi
Contributor

Well, I initially did that by creating an entirely new menu module mod_adminmenu so that the user can unpublish the mod_menu only after ensuring their new setup works fine.

But I quickly dropped that idea it was essentially code duplicate of mod_menu and user may still unpublish the old one earlier, nothing would stop them.

Another approach that comes to my mind is we fallback to preset when their is no menu items in the selected menutype. This behavior too can then be turned off by a setting in mod_menu.

@infograf768
Member
infograf768 commented Dec 19, 2016 edited

Another approach that comes to my mind is we fallback to preset when their is no menu items in the selected menutype. This behavior too can then be turned off by a setting in mod_menu.

Alas, one could create another type of menu item than Menu Items menu and Modules manager. Including only the Article menu would not help.
We also have to deal with access and permissions here.
A default installation gives permissions to Managers and up full access to Menu Manager and Modules Manager. These users are set to the Special Access group, which is also the case for the existing Admin Menu module.

@infograf768
Member

Hmm... I was thinking of a specific button always present in the menu bar that would force display an admin menu with all existing menus, but just discovered that one can unpublish the existing admin menu and even delete it... which is rather weird.

Even worse than that, the Administrator Menu can be uninstalled. It is not even protected...

@izharaazmi
Contributor
@Hackwar
Member
Hackwar commented Dec 19, 2016

How does this work for third party components? Does this work for them without any changes for the moment? Otherwise we can only include this in 4.0, not in the 3.x versions.

@Hackwar
Member
Hackwar commented Dec 19, 2016

Looking at the component installer, I have the feeling that there are more issues here, too. How is decided where the components menu items are injected upon installation? This has still be done automatically and I don't see how this is set up when the menu has already been customised.

@infograf768
Member

@Hackwar
Although it is a bit complex, reading the test instructions should help you...

Where do the menu links gets created for NEW components that I install?
The menu links are created in the same way as before for every new component installation. You can create a "Heading" type menu item (say, "New Components") and set the flag "Components Root" to "Yes". This will pull all those menu items under "New Components".
Please note, that this component root is NOT required to be a Top level menu item, it can be any level down.

screen shot 2016-12-20 at 08 40 45

screen shot 2016-12-20 at 08 53 38

All this can be customised, for core as well as 3rd party components by choosing filtering by Main (protected) and Menu (Protected) and unpublishing the ones you don't want there.

menutype1
menutype2

Basically, even if you have unpublished some items, new components will display fine in such a menu.

screen shot 2016-12-20 at 09 12 39

Going on testing now.

@infograf768
Member

@izharaazmi

@infograf768 We can show a warning to the "Special" users if the current admin menu does not have links to "Module Manager" or "Menu Manager" defined at all. From there we allow something in line with your idea, like "index.php?recover_menu=1" that would set "preset menu" to be shown under a special "Menu Item Root" This option can persist for the entire session or until user goes to "index.php?recover_menu=0"

This looks like a good idea.

@izharaazmi
Contributor

@infograf768 I thought to put this check in mod_menu itself. However, in case the mod_menu is unpublished or deleted we won't be able to show that message.

Should we consider such cases? If yes, can you suggest some other suitable place to put this code?

@infograf768
Member
infograf768 commented Dec 20, 2016 edited

A few issues:

A. The dropdown for menus should differentiate between site and admin menus.
Maybe with a separator.

screen shot 2016-12-20 at 09 17 39
menutype1

B. When multilingual is on, the Associations Tab should not display for admin menu items.
In the manager as well as when creating/editing such menu items

In the manager, one would use:
<?php if ($assoc && $this->state->get('filter.client_id') == 0) : ?>
For individual menu items, add clientId to conditional line 161
<?php if ($this->item->type !== 'alias' && $this->item->type !== 'url' && $this->item->type !== 'separator' && $this->item->type !== 'heading' && $clientId !== 1) : ?>

C. When in multilanguage and using associations, filtering by site or admin should not be accepted in the popup. It should always be site only,

Will go on testing later.

@infograf768
Member
infograf768 commented Dec 21, 2016 edited

@izharaazmi
Concerning C. above, we can patch this way in /administrator/components/com_menus/views/items/view.html.php
Change from line 232 to

		else
		{
			// In menu items associations modal we need to remove language filter if forcing a language.
			if ($forcedLanguage = JFactory::getApplication()->input->get('forcedLanguage', '', 'CMD'))
			{
				// If the language is forced we can't allow to select the language, so transform the language selector filter into an hidden field.
				$languageXml = new SimpleXMLElement('<field name="language" type="hidden" default="' . $forcedLanguage . '" />');
				$this->filterForm->setField($languageXml, 'filter', true);
				// Admin menus should not be proposed 
				$this->filterForm->setFieldAttribute('menutype', 'clientid', '0');
				// Client should always be site
				$this->filterForm->removeField('client_id');
				// Also, unset the active language filter so the search tools is not open by default with this filter.
				unset($this->activeFilters['language']);
			}
		}

and we will get
screen shot 2016-12-21 at 09 57 54

@infograf768
Member

@izharaazmi

please correct the PR with my proposals above.
Then we will ask some other people advice concerning the alert.

izharaazmi added some commits Jan 9, 2017
@izharaazmi izharaazmi Merge joomla-cms/staging into admin-menu-manager 7d9e0bb
@izharaazmi izharaazmi Post merge fixes. 0aef9d4
@izharaazmi izharaazmi Fixes as suggested by @infograf768
1. Group menu types by client id in lists and default admin menu
2. Hide association tab for admin menu items.
3. Hide client id filter for association mapping modal.
a991b7f
@izharaazmi izharaazmi Add recovery mode for menu where the selected admin menu does not con…
…tain link to module manager and/or menu manager.
600a6aa
@izharaazmi
Contributor

Accept my apologies for not being able to attend this for so long. This year transition was too busy.

Conflicts are resolved and suggested fixes applied.

Also added recovery mode for menu where the selected admin menu does not contain link to module manager and/or menu manager. This check can be disabled from menu module configuration.

PS: Happy New Year to all fellow Joomlers, though I'm too late... 😃

@infograf768
Member

Will test later.

@ot2sen
Contributor
ot2sen commented Jan 9, 2017

Gave it a test on latest staging and had some issues in the module edit view not having menus or expected settings. Could possible be because of the missing field_id in menu_type that I added manually a step later than good was.
So will retest a little later.

The visual styling of the menus did seem to have gotten an extra navigation layer that was hard to navigate through. Is that intended or a mistake in applying this larger patch? See screenshot
09-01-2017_13036

@izharaazmi izharaazmi minor bug fix
07a9a6a
@izharaazmi
Contributor
@infograf768
Member

@izharaazmi
There are conflicts

@izharaazmi izharaazmi Merge joomla-cms/staging into admin-menu-manager
9c6f953
@izharaazmi
Contributor

@infograf768 Conflicts resolved. Thanks.

@infograf768
Member
  1. Suggestion change:
                                <field
					name="check"
					type="radio"
					label="MOD_MENU_FIELD_CHECK_LABEL"
					description="MOD_MENU_FIELD_CHECK_DESC"
				>
					<option value="1">JYES</option>
					<option value="0">JNO</option>
				</field>

To

					name="check"
					type="radio"
					label="MOD_MENU_FIELD_CHECK_LABEL"
					description="MOD_MENU_FIELD_CHECK_DESC"
					class="btn-group btn-group-yesno"
					default="1"
				>
@infograf768
Member

The warning displays even when there are menu items to Menu Manager. It disapears when there is also a link to the Modules Manager.
screen shot 2017-01-10 at 12 44 49

It looks like we do need both
therefore the string is wrong:
MOD_MENU_WARNING_IMPORTANT_ITEMS_INACCESSIBLE="The active administrator menu does not contain links to atleast one of <strong>Module Manager</strong> and <strong>Menu Manager</strong>. Click to <strong><a href='index.php?recover_menu=1'>turn on the menu recovery mode</a></strong>."

if you correct the code, also please correct typo: at least and not atleast

Or change the string to
does not contain links both <strong>Module Manager</strong> and <strong>Menu Manager</strong>.

@infograf768
Member

The association column should not be present in the Administrator Menu items Manager.
I posted the code above
Use <?php if ($assoc && $this->state->get('filter.client_id') == 0) : ?>
instead of
<?php if ($assoc) : ?>
in both places in /administrator/components/com_menus/views/items/tmpl/default.php

@infograf768
Member
infograf768 commented Jan 10, 2017 edited

To testers: not forget to make the query change.

`ALTER TABLE `#__menu_types` ADD `client_id` int(11) NOT NULL DEFAULT 0;

UPDATE `#__menu` SET `published` = 1 WHERE `menutype` = 'main' OR `menutype` = 'menu';`

as otherwise one can't get to the admin interface.

@izharaazmi izharaazmi Remove assoc column for admin menu items.
Make recovery mode message more straight forward.
Change radio to toggle buttons.
9b52f78
@izharaazmi
Contributor

@infograf768 Done!

@ot2sen
Contributor
ot2sen commented Jan 12, 2017

@izharaazmi Double navigation fixed on last check thanks. Had some other issues with this heavy patch, but will try again with the extra info about UPDATE _menu from @infograf768 mentioned above. Only did manually add the field_id and ran a db fix. Will check this important new feature again during the weekend.

@franz-wohlkoenig

After installing PR got

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 12288 bytes) in __/Joomla/administrator/modules/mod_menu/tmpl/default.php on line 16

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 12288 bytes) in __/Joomla/libraries/vendor/joomla/registry/src/Registry.php on line 85

@sanderpotjer
Member
sanderpotjer commented Jan 13, 2017 edited

Having the same issues as mentioned by @franz-wohlkoenig on a clean staging setup with this PR applied.

Edit: looks like this was caused by the patchtester 3 beta version, which was only applying 30 files. Now testing via patchtester 2 which seems to work.

@izharaazmi izharaazmi Merge 'staging' into admin-menu-manager
3f1e8c5
@izharaazmi
Contributor

I have resolved the conflicts shown up today. I also notice that the patchtester does not apply the patch correctly and still shows the success message. This could be the possible reason for the above errors.

Is it possible (and correct?) to test the branch https://github.com/izharaazmi/joomla-cms/tree/admin-menu-manager? Its upto date with staging as of now.

@mbabker
Member
mbabker commented Jan 13, 2017

Patch tester is only an aide. It's not the de facto testing tool and will never work as accurately as either applying the patch with a proper patching tool or downloading the remote branch (at least for the filesystem part of things).

@sanderpotjer
Member

@izharaazmi first of all: thanks for your PR! I do think there are quite some people that would welcome this feature in Joomla.

I have had my first testing, and here is some initial feedback:

  • Move "Menu to Show" & "Check Menu" params in mod_menu to "Module" tab instead of "Advanced", or is there a specific reason to put it under advanced
  • Is there a specific reason to move the "preset" menu layouts to the "preset" folder of mod_menu? I would recommend leaving it in the tmpl folder, this will allow people to still user template overrides for the mod_menu.
  • "Check Menu", I wonder if this even should be an option or not. Might be better to have this feature enabled by default.
  • I personally think it would be great if there would be an option to convert the default Joomla menu into the "custom admin menu", in that way you don't have to rebuild the entire menu if you just want a couple small changes
  • 3rd party components: I do think it would be great for the flexibility if you can at least create a menu item for each installed component, also the 3rd party ones. So maybe a new admin menu type "components" in which you can select the component, like "com_jce", this would create a admin menu item to index.php?option=com_jce

Possibly for the future

  • A powerful option would be to add some filter presets, so for example for the com_content articles view. If you could set the default category, state etc.. people can create backend menu items to specific filtered views

I have not seen any real errors yet, but as this is a major new feature I will continue testing over the next days and will possibly get back with some more feedback.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13036.

@izharaazmi
Contributor
izharaazmi commented Jan 13, 2017 edited
@izharaazmi
Contributor

@sanderpotjer Thanks for your valuable feedback.

  • Move "Menu to Show" & "Check Menu" params in mod_menu to "Module" tab instead of "Advanced", or is there a specific reason to put it under advanced.

Advice noted, I'll look into that. Thanks.

  • Is there a specific reason to move the "preset" menu layouts to the "preset" folder of mod_menu? I would recommend leaving it in the tmpl folder, this will allow people to still user template overrides for the mod_menu.

Sounds good. Though my plan is to offer multiple presets including custom
ones. We can discuss on this.

"Check Menu", I wonder if this even should be an option or not. Might be better to have this feature enabled by default.

In case user is ok with the said links in the admin homepage and does not
care about it in the menu, then that would be a pain.

  • I personally think it would be great if there would be an option to convert the default Joomla menu into the "custom admin menu", in that way you don't have to rebuild the entire menu if you just want a couple small changes.

In my to-do list:

  1. Clone a preset as db driven menu.
  2. Add possibility for custom presets.
  3. Export selected menu as new preset.
  • 3rd party components: I do think it would be great for the flexibility if you can at least create a menu item for each installed component, also the 3rd party ones. So maybe a new admin menu type "components" in which you can select the component, like "com_jce", this would create a admin menu item to index.php?option=com_jce

It's already possible to create menu items for all installed 3PD components. Not just root level rather sub menu too if defined so in their install manifest. B/C ok.
If you meant something else, please elaborate.

Possibly for the future

  • A powerful option would be to add some filter presets, so for example for the com_content articles view. If you could set the default category, state etc.. people can create backend menu items to specific filtered views.

Honestly, I didn't understand this right. Please explain.

@rdeutz rdeutz self-assigned this Jan 16, 2017
@ot2sen
Contributor
ot2sen commented Jan 16, 2017

I have tested this item successfully on 7d9e0bb

Tested according to the very nice testing instructions and could go through all the steps for this great new feature. Good stuff!

Good job done, thanks! :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13036.

@rdeutz rdeutz merged commit 4e156fa into joomla:staging Jan 17, 2017

2 of 3 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rdeutz
Contributor
rdeutz commented Jan 17, 2017

I have merged this because it seems to be in a good enough state to go into the alpha2 of 3.7. Smaller problems and issues can be figured out on the way to 3.7 Stable

@izharaazmi
Contributor
izharaazmi commented Jan 17, 2017 edited

Thanks @brianteeman, @infograf768, @sanderpotjer, @ot2sen, @rdeutz and everyone else for making this through into J3.7.
Excited! 😄

@izharaazmi izharaazmi deleted the izharaazmi:admin-menu-manager branch Jan 17, 2017
@rdeutz rdeutz added a commit to rdeutz/joomla-cms that referenced this pull request Jan 17, 2017
@izharaazmi @rdeutz izharaazmi + rdeutz Menu manager for Joomla Backend Menu (#13036)
* Added client id column to menu_type table.
Allow creating and editing of "menutype" records with client_id = 1
Add client_id filters in menu and menu items list views
Sync menu type filter and client_id filter allowing only menu type in the URL query parameter (B/C)
Both Lists now also filtered by client id.
Client id selection updates the menu type list options to show choices only for that client id

TBD:
Reserved menu types: main & menu

* In modal list view we currently hide client_id filter and show only site menu types, will be updated once we have more clear vision.
Menu type assignment to backend mod_menu config from both menu manager and module manager. Though that is not functional within the module itself.

* Add/edit menu item redirect with clientId from list filter.
Load menu item form based on active client id
Menu type dropdown choices limited to active client id value
Show menu-item-type choices (modal) trigger with client id parameter in the url
Switch edit layout based on client id

* Menu item type loading from component metadata xml or mvc not identifies backend and frontend application separately. Not yet able to load menu item type from backend so returns empty list. Front-end is still intact and unaffected.

* Edit menu item and create menu item set to follow client id and menu type value consistenty.
When creating menu item alias, the referenced menu must also belong to same client id.
Client id field removed from form, this should be auto-calculated from the menu type when saving.

* Adding layout metadata xml in backend to reference menu item types as it was in front-end.
Removed unnecessary admin specific layout added earlier as it is so far same as original edit.php, may be added back when needed.
Remove page specific meta data fields from backend component type menu items.
For now disable/unsupport association for backend menu items.
Disallow change of client id for existing menu items, unexpected conflicts may occur if allowed so better be safe.

Ref to #2

* Created each backend menu items using menu manager as a replica of existing Joomla backend menu. These are to be used for testing during upgrading menu module.
language keys are not yet translated. Translation will be done as we are ready with most new or modified language keys application wide.
Backend menu items does not require all those parameters as that with front-end menu items. Therefore segregated entire menu item xml for backend/frontend.

Ref #2

* [a11y] Protostar back to top (#12446)

* [a11y] Protostar - back to top link

* Oops Andre was right

* add anchor for non-js enabled browsers

* Restructure mod_menu to load preset menu items as an option (default). Other options will be the menu-type and will cause us to load from database. Ref #2

* Disallow editing and set to home of protected menu type menu items viz. 'main' and 'menu'
Allow explicit filtering by protected menu type choices in menu items list view. Not limited to #__menutypes table entries only. Unfiltered list still excludes those menu items. (B/C ok)
Menu items created during installation of a component are now saved as published. When unpublished we won't load it in customised menu's component menu container. They will still be loaded irrespective of state as previously when preset is in use. (B/C ok)
Home page can now be set one per client instead of one overall.
Menu module only loads item from 'main' and 'menu' type menu items when requested for component menu items. This filter is now required because we are now going to have other custom menu types for backend which should not be included.

Ref #2

* Load menu items from databases in correct hierarchy. Remove any extra separator type menu items created due to exclusion of certain menu items based on various conditions.
Populate menu items loaded from db into the AdminCssMenu object for final rendering.
Load new installed components menu items dynamically under the specified menu item with “components container” flag. Any unpublished menu items from the protected menutypes (viz. “main” and “menu”) will be skipped.
When loading from system preset menu items, these components menu items are all included regardless of their published state. (B/C ok).

Ref #2

* View manifests for menu item type and related language key updates. ref #2

* Minor mistake fix.

* Translate menu item titles in list view. Ref #2

* Reset the preset menu structure to be same as the current J37 branch state, dropping implicit inclusion of joomla/joomla-cms#10657 improvement. Ref #2

* Allow the existing components to leverage the menu/submenu entries in their install manifest for admin menu manager menu link types.
This provides ability to create links for then without requiring them to add layout manifests. Hence, full B/C solution. Ref #2

* Minor fix

* Remove temporary dev phase files

* Preparing for PR, database and install script updates.
Ref #2

* Minor fix

* Codestyle fix

* CS fix

* Don’t sort menu items

* Sort lang keys
Allow ‘component’ as first level alias in admin menu items
Fix lang key
Remove ‘home’ setting from admin menu items

* apply in hathor

* menu item alias check for site only

* Post merge fixes.

* Fixes as suggested by @infograf768

1. Group menu types by client id in lists and default admin menu
2. Hide association tab for admin menu items.
3. Hide client id filter for association mapping modal.

* Add recovery mode for menu where the selected admin menu does not contain link to module manager and/or menu manager.

* minor bug fix

* Remove assoc column for admin menu items.
Make recovery mode message more straight forward.
Change radio to toggle buttons.
97300cf
@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Jan 17, 2017
@izharaazmi
Contributor

I am not sure who to ask for... In the alpha2 release note my name has a missing "i".

Izhar Aazm_ should be Izhar Aazmi

@Bakual
Contributor
Bakual commented Jan 19, 2017

I am not sure who to ask for... In the alpha2 release note my name has a missing "i".
Izhar Aazm_ should be Izhar Aazmi

@rdeutz would be the person 😄

@rdeutz
Contributor
rdeutz commented Jan 19, 2017

@izharaazmi sorry, fixed

@izharaazmi
Contributor

Ah that happens. 😄 Thanks!

@brianpeat
Contributor
brianpeat commented Jan 20, 2017 edited

this brings up an interesting thought. If you can make more than one admin menu, you COULD make different views for different types of admins, except as a default, all we have for the access drop down is Special and Super Users. I'm going to mess around with adding more access levels based on say, Administrator and see if it reacts well assigned to just that.

Ha! quick way to break your admin? Accidently change the settings in Special instead of copying it.

Update: this is just beautiful. After making an access level called Manager, making a new admin menu and setting it to manager, then setting the original to Super Admin, the Manager user gets ONLY the new menu. :)

@rdeutz
Contributor
rdeutz commented Jan 20, 2017

@brianpeat thanks for the comment, good to see that merging it was a good idea

@wilsonge wilsonge pushed a commit that referenced this pull request Jan 23, 2017
@C-Lodder @dgt41 C-Lodder + dgt41 Merge from staging #8 (#306)
* tinymce 4.5.2

Version 4.5.2 - January 4, 2017

* Clean up JModelForm

* xml update version

* Catch "expects parameter 2 to be string" error

* Remove multiple parameter from user field

* Remove default value from the field params to inherit from plugin

* It's 2017. Happy New Year

* Some improvements in tests #3: (#13402)

* Some improvements in tests #3:
- call static methods correctly

* Fix T_PAAMAYIM_NEKUDOTAYIM (for all PHP 5.x)

* Remove forgotten call

* Changed a few things after conversation with @mbabker

* Fixes according to @andrepereiradasilva's comments

* Unnecessary double quotes in  /libraries/joomla (#13372)

* Replace unnecessary double quotes in /libraries/joomla

* Formatting

* CS Fix

* Fixes, based on @andrepereiradasilva's comments.

* Change remove string concatenations for some occurrences.

* Fixes, based on @andrepereiradasilva's comments.

* Fixes, based on @andrepereiradasilva's comments.

* Fixes, based on @andrepereiradasilva's comments.

* Fixing search for MySQL (#13571)

* Use $query->castAsChar instead of casting to integer

* Codestyle

* Clean up old code in cache.php file (#12183)

* Clean up in cache - part 1

* Remove old php4 style to catch exception which currently is useless.
* Add shorten version of ternary pperators.

* Add fix for contains()

* Add more email cloaking unit tests and fix email cloaking bug (#13446)

* Rsponsive article edit fields (#13586)

* Fix BS grid (#13560)

* Fixing Showon in plugins/modules/templates (#13549)

* Adding field group to JFormHelper::parseShowOnConditions and rearranged argument order.

* codestyle

* $field->assigned_cat_ids may not exist. (#13570)

* Clean up ModulesModelModule class (#13380)

* Make the calendar work in the subform field (#13153)

* [com_fields] Add Joomla loading overlay when form submit is triggered by category selector change (#13320)

* Added overlay box and message box for submit and reload form after category change

* Removed commented testing code

* Added language strings

* CS fix, added missing spaces

* Used Joomla logo spinner instead of fixed message

* Reverted changes in admin lang file

* CS

* Revert frontend lang changes

* Added Joomla loading overlay to new field form when changing field type

* Added Joomla.loadingLayer show to typeHasChanged JS method too

* PostgreSQL - return the same string each time of call __toString() on update query (#13284)

* TranslateFormat in all other forms (#13158)

* TranslateFormat in all other forms

* Revert for tracks filter bar

* Fix for issue #13531 (#13535)

* Fix for issue #13531
- [AND] and [OR] operators were not functioning correctly. Fixed.
- some cleanup of whitespaces in XML file and removal of rulers when the encapsulated fields are not showing.

* Removed $key, as it was an unused leftover

* CS Fix

* Whitespace Fix

* Whitespace Fix

* Whitespace Fix#2

* Conflict resolution (hopefully, Don't have a complete dev-environment right now.)

* Added css classes to the mod_login submit buttons (#13379)

* Added css classes to the mod_login submit buttons

* Added css classes to the mod_login submit buttons

* Changed class to login-button in both modules

* PHPMailer update (#13575)

* Correcting sidebar display LTR and RTL (replaces #13548) (#13593)

* Fix for Issue #13588 - mod_articles_categories - Fatal error: Class 'ContentHelperRoute' not found... (#13590)

* Update helper.php

Remove JLoader::register('ContentHelperRoute', JPATH_SITE . '/components/com_content/helpers/route.php');

* Update mod_articles_categories.php

* Make clear Exception messages in JTable (#13603)

* Fix issue where fields is false (#13574)

* Update jQuery Autocomplete to 1.2.27 (#13282)

* Show text "No Information Entered" in users profile when no value is set (#13589)

* Delete UCM content entries when Joomla articles are deleted (#13592)

* [com_fields] Add base list plugin class which activates the list plugin (#13546)

* Add base list plugin class

* Update fieldslistplugin.php

* Fixes #13177: Added where clause with block status (#13545)

* Menu manager for Joomla Backend Menu (#13036)

* Added client id column to menu_type table.
Allow creating and editing of "menutype" records with client_id = 1
Add client_id filters in menu and menu items list views
Sync menu type filter and client_id filter allowing only menu type in the URL query parameter (B/C)
Both Lists now also filtered by client id.
Client id selection updates the menu type list options to show choices only for that client id

TBD:
Reserved menu types: main & menu

* In modal list view we currently hide client_id filter and show only site menu types, will be updated once we have more clear vision.
Menu type assignment to backend mod_menu config from both menu manager and module manager. Though that is not functional within the module itself.

* Add/edit menu item redirect with clientId from list filter.
Load menu item form based on active client id
Menu type dropdown choices limited to active client id value
Show menu-item-type choices (modal) trigger with client id parameter in the url
Switch edit layout based on client id

* Menu item type loading from component metadata xml or mvc not identifies backend and frontend application separately. Not yet able to load menu item type from backend so returns empty list. Front-end is still intact and unaffected.

* Edit menu item and create menu item set to follow client id and menu type value consistenty.
When creating menu item alias, the referenced menu must also belong to same client id.
Client id field removed from form, this should be auto-calculated from the menu type when saving.

* Adding layout metadata xml in backend to reference menu item types as it was in front-end.
Removed unnecessary admin specific layout added earlier as it is so far same as original edit.php, may be added back when needed.
Remove page specific meta data fields from backend component type menu items.
For now disable/unsupport association for backend menu items.
Disallow change of client id for existing menu items, unexpected conflicts may occur if allowed so better be safe.

Ref to #2

* Created each backend menu items using menu manager as a replica of existing Joomla backend menu. These are to be used for testing during upgrading menu module.
language keys are not yet translated. Translation will be done as we are ready with most new or modified language keys application wide.
Backend menu items does not require all those parameters as that with front-end menu items. Therefore segregated entire menu item xml for backend/frontend.

Ref #2

* [a11y] Protostar back to top (#12446)

* [a11y] Protostar - back to top link

* Oops Andre was right

* add anchor for non-js enabled browsers

* Restructure mod_menu to load preset menu items as an option (default). Other options will be the menu-type and will cause us to load from database. Ref #2

* Disallow editing and set to home of protected menu type menu items viz. 'main' and 'menu'
Allow explicit filtering by protected menu type choices in menu items list view. Not limited to #__menutypes table entries only. Unfiltered list still excludes those menu items. (B/C ok)
Menu items created during installation of a component are now saved as published. When unpublished we won't load it in customised menu's component menu container. They will still be loaded irrespective of state as previously when preset is in use. (B/C ok)
Home page can now be set one per client instead of one overall.
Menu module only loads item from 'main' and 'menu' type menu items when requested for component menu items. This filter is now required because we are now going to have other custom menu types for backend which should not be included.

Ref #2

* Load menu items from databases in correct hierarchy. Remove any extra separator type menu items created due to exclusion of certain menu items based on various conditions.
Populate menu items loaded from db into the AdminCssMenu object for final rendering.
Load new installed components menu items dynamically under the specified menu item with “components container” flag. Any unpublished menu items from the protected menutypes (viz. “main” and “menu”) will be skipped.
When loading from system preset menu items, these components menu items are all included regardless of their published state. (B/C ok).

Ref #2

* View manifests for menu item type and related language key updates. ref #2

* Minor mistake fix.

* Translate menu item titles in list view. Ref #2

* Reset the preset menu structure to be same as the current J37 branch state, dropping implicit inclusion of joomla/joomla-cms#10657 improvement. Ref #2

* Allow the existing components to leverage the menu/submenu entries in their install manifest for admin menu manager menu link types.
This provides ability to create links for then without requiring them to add layout manifests. Hence, full B/C solution. Ref #2

* Minor fix

* Remove temporary dev phase files

* Preparing for PR, database and install script updates.
Ref #2

* Minor fix

* Codestyle fix

* CS fix

* Don’t sort menu items

* Sort lang keys
Allow ‘component’ as first level alias in admin menu items
Fix lang key
Remove ‘home’ setting from admin menu items

* apply in hathor

* menu item alias check for site only

* Post merge fixes.

* Fixes as suggested by @infograf768

1. Group menu types by client id in lists and default admin menu
2. Hide association tab for admin menu items.
3. Hide client id filter for association mapping modal.

* Add recovery mode for menu where the selected admin menu does not contain link to module manager and/or menu manager.

* minor bug fix

* Remove assoc column for admin menu items.
Make recovery mode message more straight forward.
Change radio to toggle buttons.

* Add SMS to External URL menu item type (#13615)

Allows data like sms://+15555555555 to be used instead of getting "Save Not Permitted"

* Adding the Multilanguage Associations Manager (#13537)

* Merge Associations rewrite

* updated searchtool with the new way

* udpated edit view title

* added contact associationshelper class

* temp fix

* fix for category filter

* added newsfeeds associations helper

* CAPS for params

* lang tag and added a helper function

* added land tags

* code style fix

* better title in associations view

* better title

* use the usual naming

* fix language tag, thanks to brian teeman and twitter :-)

* initial review

* on simple change

* on simple change 2

* simple

* some more helper changes

* Update associations.php

* Update associations.php

* app isn’t set a model property

* correct return value

* simplify code adn use helper method

* use typename directly

* changed the tooltip position

* Correct menu helper

* remove unreacable code

* correcting checked_out

* com_menus

* fixed not supportted message

* installation

* fix menu install

* Spaces -> tabs

* [com_associations] - mssql updates (#13617)

the missed mssql updates for #13537

* [com_fields] Improved description in the "description" tooltip Fixes #13392 (#13557)

* Fixes #13195: Added margin bottom to sidebar menu

* Fixes #13392: Changed description field tooltip

* Fixes #13392: Changed description field tooltip

* Fixes #13392: Changed description field tooltip

* sync admin menu menutype (#13618)

* Routing: Remove IDs from tags URLs, use menu item of tags view as default for tag view (#11166)

* Remove id from tags, use tags list menu item as default for tag

* Code style, remove useless code, feature: first Itemid for tags view, second Itemid for default tag view

* Updating install.xml en-GB administrator (#13623)

* run grunt
a135d31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment