Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinymce 4.5.2 #13481

Merged
merged 2 commits into from Jan 12, 2017
Merged

Update tinymce 4.5.2 #13481

merged 2 commits into from Jan 12, 2017

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Jan 5, 2017

Version 4.5.2 - January 4, 2017

  • ADDED missing keyboard shortcut description for the underline menu item in the format menu.
  • FIXED bug where external blob urls wasn't properly handled by editor upload logic. Patch contributed by David Oviedo.
  • FIXED bug where urls wasn't treated as a single word by the wordcount plugin.
  • FIXED bug where nbsp characters wasn't treated as word delimiters by the wordcount plugin.
  • FIXED bug where editor instance wasn't properly passed to the format preview logic. Patch contributed by NullQuery.
  • FIXED bug where the fake caret wasn't hidden when you moved selection to a cE=false element.
  • FIXED bug where it wasn't possible to edit existing code sample blocks.
  • FIXED bug where it wasn't possible to delete editor contents if the selection included an empty block.
  • FIXED bug where the formatter wasn't expanding words on some international characters. Patch contributed by Martin Larochelle.
  • FIXED bug where the open link feature wasn't working correctly on IE 11.
  • FIXED bug where enter before/after a cE=false block wouldn't properly padd the paragraph with an br element.
  • FIXED so font size and font family select boxes always displays a value by using the runtime style as a fallback.
  • FIXED so missing plugins will be logged to console as warnings rather than halting the initialization of the editor.
  • FIXED so splitbuttons become normal buttons in advlist plugin if styles are empty. Patch contributed by René Schleusner.
  • FIXED so you can multi insert rows/cols by selecting table cells and using insert rows/columns.

Pull Request for Issue # .

Summary of Changes

  • Update tinymce to latest version
  • Correct file permissions

Testing Instructions

Apply patch, select tinyMCE as your default editor and edit an article (try to use as much of the editor's functionality as possible)

Documentation Changes Required

None


This change is Reviewable

Version 4.5.2 - January 4, 2017
@infograf768
Copy link
Member

Version change missing in the xml

@dgrammatiko
Copy link
Contributor Author

@infograf768 thanks, I keep forgetting things...

@infograf768
Copy link
Member

Works fine here. Although some files permissions are corrected which do not concern TinyMCE.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13481.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 8, 2017
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 17821a0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13481.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 8, 2017
@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 17821a0

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13481.

@dgrammatiko
Copy link
Contributor Author

Thanks @infograf768 @anibalsanchez
RTC

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 11, 2017
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Jan 11, 2017
@wilsonge wilsonge merged commit 7a9c907 into joomla:staging Jan 12, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2017
@dgrammatiko dgrammatiko deleted the +++++++tinymce_update branch March 18, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants