Fixes the issue which causes custom menu items to be lost on component update

[izharaazmi]

Pull Request for Issue #13642.

Summary of Changes

1. Changed \JInstallerAdapterComponent::_removeAdminMenus to remove only the protected menu items, i.e. - menutype == 'main' and leave alone other menutypes.
2. Replicated \JInstallerAdapterComponent::_updateSiteMenus as \JInstallerAdapterComponent::_updateMenus to update the admin menus as well.

Testing Instructions

1. Create a custom admin menu.
2. Install any extension.
3. Create a menu link for the component in your custom menu.
4. Reinstall/update your component.

Extra: Uninstall your component. The menu item should still exist in your custom admin menu, though orphaned.

Expected result

The custom menu item in step 3 above, should still point to the same component.

Actual result

Without this patch The custom menu item in step 3 above is removed. After this patch, we get the expected result.

Documentation Changes Required

None

Pinging @rdeutz @infograf768 @Bakual

[ghost]

Tested successfully (Item not found at Issue Tracker).

Test using Sermonspeaker installing, uninstalling, reinstalling (not tested on Update). All works like described in Instructions.

[rdeutz]

It seems there is a problem with the issue tracker, I added the PR-Staging label manuell.

Could you @mbabker have a lock when you have a minute

[rdeutz]

I also tested it successfully

[mbabker]

There's already a tracking issue... joomla/jissues#939

[mbabker]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13857.}

[Kubik-Rubik]

Thank you @izharaazmi and testers!

[izharaazmi]

@rdeutz I am going to propose a little improvement tomorrow. After beta release it might not be possible to get it in 3.7. Could you please wait to atleast see it before you mark the beta release.

[rdeutz]

@izharaazmi I am preparing the beta release just now, we have a beta2 next week, if it makes sense we will add it.