[4.0] PHPUnit test fixes

[yvesh]

Summary of Changes

This should fix the unit tests in the 4.0 branch

Testing Instructions

Review & Travis

Expected result

Unit Tests should pass

Documentation Changes Required

None

[zero-24]

There was 1 error:
1) JDocumentFeedTest::testEnsureAddItemReturnsThisObject
Exception: DateTimeZone::__construct(): Unknown or bad timezone ()

/home/travis/build/joomla/joomla-cms/libraries/joomla/document/feed.php:179
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/joomla/document/feed/JDocumentFeedTest.php:32

[mbabker]

This isn't quite right. The JMediawikiHttp constructor is telling the JHttpFactory it should only allow a JHttpTransportStream object to be created, so why it's returning a JHttpTransportCurl instance needs to be investigated.

[yvesh]

@mbabker

Probably because of this line:

https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/joomla/http/factory.php#L68

string no array

https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/joomla/mediawiki/http.php#L45

[mbabker]

Look at the line above in the factory, it's supposed to be setting the default value to an array so it should be supporting both strings and arrays in theory.

[yvesh]

@mbabker Look some lines below: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/joomla/http/factory.php#L77

That can't work with a string (foreach)

if (is_string($availableAdapters))
{
     $availableAdapters = array($availableAdapters);
}

[mbabker]

https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/joomla/http/factory.php#L67 should be setting $default as an array before assigning it to $availableAdapters so if that's not happening we've got another bug on our hands.

[yvesh]

You are right, overread that line. Going to debug it tomorrow morning..

[yvesh]

Actually when i look at this test again, the whole test makes no sense.. as we are creating a new JHttp instance and not a JMediawikiHttp.. And JHttp without parameters, which takes the first available adapter.

[mbabker]

This is why I shouldn't read pull requests before ☕️.

[yvesh]

@mbabker Travis passes now, can you review?