Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing error surpressing @ in com_finder router #14323

Merged
merged 1 commit into from Mar 8, 2017

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 4, 2017

Pull Request for Issue #14301 .

Summary of Changes

This just removes the error surpressing @-sign in the router of com_finder. This is a rather dodgy way to code this.... This should only be a codereview.

@joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Mar 4, 2017

I have tested this item successfully on ccc00b9

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323.

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Mar 4, 2017

I have to apologise. I forgot the attribution. This is basically the code from @stAn47, so all praise belongs to him. 😉

@mbabker
mbabker approved these changes Mar 4, 2017
@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Mar 4, 2017

Who committed code with @ suppressors in the first instance? They should be shot!

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Mar 4, 2017

That code is the initial commit of com_finder.

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Mar 4, 2017

No comment

@alikon
Copy link
Contributor

@alikon alikon commented Mar 7, 2017

I have tested this item successfully on ccc00b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323.

@jeckodevelopment
Copy link
Member

@jeckodevelopment jeckodevelopment commented Mar 7, 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323.

@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Mar 7, 2017
@wilsonge wilsonge merged commit 2a41d60 into joomla:staging Mar 8, 2017
4 checks passed
4 checks passed
@joomla-cms-bot
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 8, 2017
jjaracz pushed a commit to jjaracz/joomla-cms that referenced this pull request Mar 9, 2017
@Hackwar Hackwar deleted the Hackwar:finder_router_fix branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants