Removing error surpressing @ in com_finder router #14323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on ccc00b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323. |
|
I have to apologise. I forgot the attribution. This is basically the code from @stAn47, so all praise belongs to him. 😉 |
mbabker
approved these changes
Mar 4, 2017
This comment was marked as abuse.
This comment was marked as abuse.
|
That code is the initial commit of com_finder. |
This comment was marked as abuse.
This comment was marked as abuse.
|
I have tested this item ✅ successfully on ccc00b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #14301 .
Summary of Changes
This just removes the error surpressing @-sign in the router of com_finder. This is a rather dodgy way to code this.... This should only be a codereview.