New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_content] - add categories filter to archived view #15184

Merged
merged 6 commits into from May 27, 2017

Conversation

Projects
@alikon
Contributor

alikon commented Apr 9, 2017

Pull Request for Issue #14923 .

Summary of Changes

try to adress

  1. In the existing archived view being able to filter to a given category.

Testing Instructions

archivedcat

Expected result

able to filter archived article on categories too

Actual result

no option to filter on categories

alikon added some commits Apr 9, 2017

[com_content] - archived view add categories filter
archived view add categories filter
[com_content] - archived view add categories filter
archived view add categories filter
@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 9, 2017

I have tested this item successfully on f066c8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

franz-wohlkoenig commented Apr 9, 2017

I have tested this item successfully on f066c8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 9, 2017

Contributor

I have restarted travis for this PR as the errors in travis were unrelated to the Pr

Contributor

brianteeman commented Apr 9, 2017

I have restarted travis for this PR as the errors in travis were unrelated to the Pr

@joomla-cms-bot joomla-cms-bot changed the title from [com_content] - add categories filter to archived view to [com_content] - add categories filter to archived view Apr 9, 2017

@joomla-cms-bot joomla-cms-bot added PR-staging and removed PR-staging labels Apr 9, 2017

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 9, 2017

Contributor

To be consistent with other menu items I would move the new category selector to directly below the Menu Item Type field on the first tab

Contributor

brianteeman commented Apr 9, 2017

To be consistent with other menu items I would move the new category selector to directly below the Menu Item Type field on the first tab

alikon added some commits Apr 10, 2017

move catid filter to 1st tab
move catid filter to 1st tab
move to 1st tab
move to 1st tab
@alikon

This comment has been minimized.

Show comment
Hide comment
@alikon

alikon Apr 10, 2017

Contributor

moved to the 1st tab

Contributor

alikon commented Apr 10, 2017

moved to the 1st tab

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 10, 2017

I have tested this item successfully on 610ad34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

franz-wohlkoenig commented Apr 10, 2017

I have tested this item successfully on 610ad34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

drone fix
drone fix i hope
@waader

This comment has been minimized.

Show comment
Hide comment
@waader

waader Apr 10, 2017

Contributor

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

Contributor

waader commented Apr 10, 2017

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Apr 10, 2017

@zero-24 zero-24 added the RTC label Apr 10, 2017

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.0 milestone Apr 10, 2017

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Apr 10, 2017

Contributor

RTC as the last commit was just a drone fix. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

Contributor

zero-24 commented Apr 10, 2017

RTC as the last commit was just a drone fix. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 10, 2017

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

franz-wohlkoenig commented Apr 10, 2017

I have tested this item successfully on 051ca9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

@joomla-cms-bot joomla-cms-bot modified the milestone: Joomla 3.7.0 Apr 10, 2017

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 10, 2017

RTC after two successful tests.

franz-wohlkoenig commented Apr 10, 2017

RTC after two successful tests.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Apr 10, 2017

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Apr 10, 2017

Contributor

@franz-wohlkoenig Please remove RTC for now.

Contributor

Quy commented Apr 10, 2017

@franz-wohlkoenig Please remove RTC for now.

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Apr 10, 2017

Contributor

A while ago the same feature was discussed: #5810 :-)

Contributor

rdeutz commented Apr 10, 2017

A while ago the same feature was discussed: #5810 :-)

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.0 milestone Apr 11, 2017

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 11, 2017

Removed RTC as said by @Quy


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

franz-wohlkoenig commented Apr 11, 2017

Removed RTC as said by @Quy


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15184.

@joomla-cms-bot joomla-cms-bot removed the RTC label Apr 11, 2017

avoid confusion
avoid confusion in implode()
@alikon

This comment has been minimized.

Show comment
Hide comment
@alikon

alikon Apr 11, 2017

Contributor

@rdeutz
reason 2) from #5810 (comment)
is not so true as we have some use cases nowadays....

Contributor

alikon commented Apr 11, 2017

@rdeutz
reason 2) from #5810 (comment)
is not so true as we have some use cases nowadays....

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Apr 11, 2017

Contributor

@alikon is wasn't true back these days anyway ;-)

Contributor

rdeutz commented Apr 11, 2017

@alikon is wasn't true back these days anyway ;-)

@alikon

This comment has been minimized.

Show comment
Hide comment
@alikon

alikon Apr 11, 2017

Contributor

@frankmayer is possible to set RTC again (cause last commit is only CS fix) so we can have another chance to be re-evaluated from mantainers ?

Contributor

alikon commented Apr 11, 2017

@frankmayer is possible to set RTC again (cause last commit is only CS fix) so we can have another chance to be re-evaluated from mantainers ?

@rdeutz rdeutz added the RTC label Apr 11, 2017

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Apr 11, 2017

Contributor

For me it looks good

Contributor

rdeutz commented Apr 11, 2017

For me it looks good

@joomla-cms-bot joomla-cms-bot removed the RTC label Apr 11, 2017

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Apr 11, 2017

@zero-24 zero-24 added the RTC label Apr 11, 2017

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.0 milestone Apr 11, 2017

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Apr 11, 2017

@wilsonge wilsonge modified the milestones: Joomla 3.8.0, Joomla 3.7.0 Apr 11, 2017

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Apr 11, 2017

Contributor

Given we are at RC status on 3.7 and this is a feature I'm moving it to the 3.8 milestone

Contributor

wilsonge commented Apr 11, 2017

Given we are at RC status on 3.7 and this is a feature I'm moving it to the 3.8 milestone

@mbabker mbabker added this to Testing/Review in [3.8] General Apr 27, 2017

@mbabker mbabker changed the base branch from staging to 3.8-dev May 27, 2017

@mbabker mbabker merged commit c6ca5ac into joomla:3.8-dev May 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-3.8-dev and removed RTC labels May 27, 2017

@mbabker mbabker moved this from Testing/Review to Completed in [3.8] General May 27, 2017

@alikon alikon deleted the alikon:patch-84 branch May 28, 2017

@csthomas

This comment has been minimized.

Show comment
Hide comment
@csthomas

csthomas Oct 2, 2017

Contributor

I added an issue related to this PR at #18186

Contributor

csthomas commented Oct 2, 2017

I added an issue related to this PR at #18186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment