Fix b/c break in JMenuItem #15553

Merged
merged 3 commits into from Apr 27, 2017

Conversation

Projects
None yet
7 participants
@wilsonge
Contributor

wilsonge commented Apr 25, 2017

Pull Request for Issue https://twitter.com/joovlaki/status/856913614367752196 (because apparently we can only take issues submitted over twitter now).

Summary of Changes

Fixes a b/c break in JMenuItem when checking if params is set

Testing Instructions

Run isset(\JFactory::getApplication()->getMenu()->getActive()->params) on pages with and without a active menu item

Expected result

Code gives the correct result

Actual result

It doesn't

Documentation Changes Required

None

@wilsonge wilsonge requested a review from mbabker Apr 25, 2017

@dgrammatiko

This comment has been minimized.

Show comment
Hide comment
@dgrammatiko

dgrammatiko Apr 25, 2017

Member

I have tested this item successfully on 867d283


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

Member

dgrammatiko commented Apr 25, 2017

I have tested this item successfully on 867d283


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

libraries/cms/menu/item.php
+ *
+ * @return boolean
+ *
+ * @since 3.7.0

This comment has been minimized.

@laoneo

laoneo Apr 26, 2017

Member

Should this not be __DEPLOY_VERSION__?

@laoneo

laoneo Apr 26, 2017

Member

Should this not be __DEPLOY_VERSION__?

This comment has been minimized.

@wilsonge

wilsonge Apr 26, 2017

Contributor

That's what comes of copy/paste code :)

@wilsonge

wilsonge Apr 26, 2017

Contributor

That's what comes of copy/paste code :)

@mbabker mbabker added this to the Joomla 3.7.1 milestone Apr 27, 2017

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Apr 27, 2017

Member

I have tested this item successfully on 08d4dc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

Member

infograf768 commented Apr 27, 2017

I have tested this item successfully on 08d4dc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.1 milestone Apr 27, 2017

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Apr 27, 2017

Member

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

Member

infograf768 commented Apr 27, 2017

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 27, 2017

@infograf768 infograf768 added this to the Joomla 3.7.1 milestone Apr 27, 2017

@rdeutz rdeutz merged commit 2bdef6f into joomla:staging Apr 27, 2017

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Apr 27, 2017

@wilsonge wilsonge deleted the wilsonge:isset-fix branch Apr 27, 2017

rdeutz added a commit to joomlajenkins/joomla-cms that referenced this pull request May 1, 2017

Fix b/c break in JMenuItem (#15553)
* Fix b/c break in JMenuItem

* Code style

* Use deploy version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment