Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix b/c break in JMenuItem #15553

Merged
merged 3 commits into from Apr 27, 2017
Merged

Fix b/c break in JMenuItem #15553

merged 3 commits into from Apr 27, 2017

Conversation

@wilsonge
Copy link
Contributor

wilsonge commented Apr 25, 2017

Pull Request for Issue https://twitter.com/joovlaki/status/856913614367752196 (because apparently we can only take issues submitted over twitter now).

Summary of Changes

Fixes a b/c break in JMenuItem when checking if params is set

Testing Instructions

Run isset(\JFactory::getApplication()->getMenu()->getActive()->params) on pages with and without a active menu item

Expected result

Code gives the correct result

Actual result

It doesn't

Documentation Changes Required

None

@wilsonge wilsonge requested a review from mbabker Apr 25, 2017
@wilsonge wilsonge force-pushed the wilsonge:isset-fix branch from 4a35ff6 to 867d283 Apr 25, 2017
@dgrammatiko
Copy link
Contributor

dgrammatiko commented Apr 25, 2017

I have tested this item successfully on 867d283


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

*
* @return boolean
*
* @since 3.7.0

This comment has been minimized.

Copy link
@laoneo

laoneo Apr 26, 2017

Member

Should this not be __DEPLOY_VERSION__?

This comment has been minimized.

Copy link
@wilsonge

wilsonge Apr 26, 2017

Author Contributor

That's what comes of copy/paste code :)

@mbabker mbabker added this to the Joomla 3.7.1 milestone Apr 27, 2017
@infograf768
Copy link
Member

infograf768 commented Apr 27, 2017

I have tested this item successfully on 08d4dc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.1 milestone Apr 27, 2017
@infograf768
Copy link
Member

infograf768 commented Apr 27, 2017

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 27, 2017
@infograf768 infograf768 added this to the Joomla 3.7.1 milestone Apr 27, 2017
@rdeutz rdeutz merged commit 2bdef6f into joomla:staging Apr 27, 2017
4 checks passed
4 checks passed
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Apr 27, 2017
@wilsonge wilsonge deleted the wilsonge:isset-fix branch Apr 27, 2017
rdeutz added a commit to joomlajenkins/joomla-cms that referenced this pull request May 1, 2017
* Fix b/c break in JMenuItem

* Code style

* Use deploy version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.