Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove empty locked cache file if callback function terminate process #15592
Pull Request for Issue #15544
Summary of Changes
Remove empty locked file at shutdown script if cache
This is my second PR (previous #15558)
To save a cache file joomla requires lock method.
Take a look at the issue.
Documentation Changes Required
May be the best way would be to not block other processes to create a cache data but only block on save the data to cache file.
Old version does not create a lock for not existed cache files.
I've just tried this fix on PHP 5.5.9 and it is now not saving any page cache files. I was suffering from the "zero length cache file" problem for pages which the page cache plugin ignored. This fix is now removing all cache files.
We're using a custom page cache plugin based on the Joomla one. It was working fine on 3.6.x. I'll also check that there aren't any changes to the 3.7 page cache plugin we should be considering.
Can you test on memcache(-d) or redis?
Wow, that was a headache. Seriously, can someone put memcached configurations into docs.joomla.org?
Anyway, I can confirm that there are no problems with memcache, it is caching the correct locations and has no problems on locations where our plugin skips caching.
I've got the following:
But it's not helping. There are still no files ending up in cache
OK, it's working now. It looks like it was trouble at my end which occurred at the exact same time I applied this patch.
It seems that the cache/page folder was recreated in some way, probably via an rsync action, while my terminal's CWD was in that folder. So, when I
Sorry to waste your time and thank you for your efforts to sort this out.