[JFilterInput] add some test cases with unicode chars #15914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you add this tests to let the system fail for the issue #15673 Have done it local but all test run successfully |
|
@rdeutz This PR is intended to pass. These are just some base cases that currently work for multibyte characters but are not included in tests to verify that they work. Adding these will help avoid regressions. |
|
Ok, thanks for explaining. |
|
merged on review |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
May 16, 2017
* try some cases with unicode chars * try fixing path 6 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue add some test cases with unicode chars.
Summary of Changes
adds some test cases with unicode chars (does not cover all cases just makes improvements in the test cases)
Testing Instructions
code review / unit tests pass
Documentation Changes Required
none