New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calendar] B/C Setting weeknumbers to display per default #16117

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
10 participants
@infograf768
Member

infograf768 commented May 19, 2017

Pull Request replacing #16104

Summary of Changes

As title says.

Testing Instructions

Patch and make sure all calendar fields display weeknumbers.

Expected result

screen shot 2017-05-18 at 11 48 37

@infograf768 infograf768 added this to the Joomla 3.7.2 milestone May 19, 2017

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 May 19, 2017

Member

Setting to 3.7.2 as it is a B/C issue.

Member

infograf768 commented May 19, 2017

Setting to 3.7.2 as it is a B/C issue.

@ot2sen

This comment has been minimized.

Show comment
Hide comment
@ot2sen

ot2sen May 19, 2017

Contributor

I have tested this item successfully on 35d352b

Works. Weeknumbers now shown in modules and also in the 3 article settings for start/finish/created.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16117.

Contributor

ot2sen commented May 19, 2017

I have tested this item successfully on 35d352b

Works. Weeknumbers now shown in modules and also in the 3 article settings for start/finish/created.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16117.

@rdeutz

rdeutz approved these changes May 19, 2017

looks good

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 May 19, 2017

Member

Note: as explained in #16104
It would now be a voluntary act to NOT display it for a 3rd party by adding weeknumbers="false" in their xmls or any user in the layout (/layouts/joomla/form/field/calendar.php)

Member

infograf768 commented May 19, 2017

Note: as explained in #16104
It would now be a voluntary act to NOT display it for a 3rd party by adding weeknumbers="false" in their xmls or any user in the layout (/layouts/joomla/form/field/calendar.php)

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig May 19, 2017

I have tested this item successfully on 35d352b

Tests on Articles and Modules.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16117.

franz-wohlkoenig commented May 19, 2017

I have tested this item successfully on 35d352b

Tests on Articles and Modules.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16117.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.2 milestone May 19, 2017

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig May 19, 2017

RTC after two successful tests.

franz-wohlkoenig commented May 19, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label May 19, 2017

@infograf768 infograf768 added this to the Joomla 3.7.2 milestone May 19, 2017

@wilsonge wilsonge merged commit 88a5993 into joomla:staging May 19, 2017

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels May 19, 2017

@dgrammatiko

This comment has been minimized.

Show comment
Hide comment
@dgrammatiko

dgrammatiko May 19, 2017

Contributor

Really?
B/C break to have a calendar without the confusing week number?
Joomla will never, ever get a good UI/UX.-

Contributor

dgrammatiko commented May 19, 2017

Really?
B/C break to have a calendar without the confusing week number?
Joomla will never, ever get a good UI/UX.-

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz May 19, 2017

Contributor

No it is not a b/c break it is just different as it was before

Contributor

rdeutz commented May 19, 2017

No it is not a b/c break it is just different as it was before

@dgrammatiko

This comment has been minimized.

Show comment
Hide comment
@dgrammatiko

dgrammatiko May 19, 2017

Contributor

There was a reason for this change: most calendars don't display week numbers (for most users this is confusing and just a cluttered display). One user complains and we ruin the UI/UX for the majority to satisfy the minority?
I give up...

Contributor

dgrammatiko commented May 19, 2017

There was a reason for this change: most calendars don't display week numbers (for most users this is confusing and just a cluttered display). One user complains and we ruin the UI/UX for the majority to satisfy the minority?
I give up...

@C-Lodder

This comment has been minimized.

Show comment
Hide comment
@C-Lodder

C-Lodder May 19, 2017

Member

Why on earth would we need to display the week number by default? It's just cluttering up the calendar display and making the click space for the dates smaller. THAT is bad UX

Member

C-Lodder commented May 19, 2017

Why on earth would we need to display the week number by default? It's just cluttering up the calendar display and making the click space for the dates smaller. THAT is bad UX

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman May 19, 2017

Contributor
Contributor

brianteeman commented May 19, 2017

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz May 19, 2017

Contributor

I have read the original issue and I don't see that there was an agreement that removing the week numbers is the way to go. So in this cases I go with "how it was in the past".

I see arguments for and against enabled by default and I don't know what is the majority and what the minority. So further discussion here will lead to nowhere. There is always the option to open a PR, discuss the topic, come to an agreement and then go from there.

Contributor

rdeutz commented May 19, 2017

I have read the original issue and I don't see that there was an agreement that removing the week numbers is the way to go. So in this cases I go with "how it was in the past".

I see arguments for and against enabled by default and I don't know what is the majority and what the minority. So further discussion here will lead to nowhere. There is always the option to open a PR, discuss the topic, come to an agreement and then go from there.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual May 19, 2017

Contributor

Actually, it's easier for the user to hide the weeknumbers (could be done with CSS) than to add them (needs a JLayout or JS override).

Contributor

Bakual commented May 19, 2017

Actually, it's easier for the user to hide the weeknumbers (could be done with CSS) than to add them (needs a JLayout or JS override).

@infograf768 infograf768 deleted the infograf768:calendar_weeknumbers branch May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment