New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B/C] Page filtering missing for Modules manager #16118

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
5 participants
@infograf768
Member

infograf768 commented May 19, 2017

Pull Request for Issue #15621

Summary of Changes

showon does not work for search Tools filters.
Solution: unsetting the page filter when filtering by administrator

After patch one should get

module_page_filter

@infograf768

This comment has been minimized.

Member

infograf768 commented May 19, 2017

Setting to 3.7.2 milestone as this is a B/C break

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented May 19, 2017

I have tested this item successfully on 3cf21f4

After PR applied search by Page is shown in "Site".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16118.

@AlexRed

This comment has been minimized.

Contributor

AlexRed commented May 19, 2017

I have tested this item successfully on 3cf21f4

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16118.

@infograf768

This comment has been minimized.

Member

infograf768 commented May 19, 2017

Note: as we do not use language when filtering by admin, after this patch is merged, I will make a specific PR to take off language from the filters and the list. That one could wait 3.7.3 except if I am told otherwise.

@infograf768 infograf768 removed the PR-staging label May 19, 2017

@infograf768

This comment has been minimized.

Member

infograf768 commented May 19, 2017

RTC. Thanks for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16118.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.2 milestone May 19, 2017

@joomla-cms-bot joomla-cms-bot added the RTC label May 19, 2017

@infograf768 infograf768 added this to the Joomla 3.7.2 milestone May 19, 2017

@infograf768

This comment has been minimized.

Member

infograf768 commented May 19, 2017

@rdeutz
Please merge so that I make a mew PR for language

@rdeutz rdeutz merged commit be80ed1 into joomla:staging May 19, 2017

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment