New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Allow multiple values for the integer field #16153

Merged
merged 2 commits into from May 22, 2017

Conversation

Projects
None yet
6 participants
@PhilETaylor
Contributor

PhilETaylor commented May 20, 2017

Summary of Changes

Before this PR it was impossible to render multiple integer values, but the field allows you to select multiple integer values. This is a bug in com_fields

Testing Instructions

Create a custom integerfield
make sure Multiple = Yes
Edit content, select several integers in the custom field

Expected result

When rendered you see all the integers you selected in a comma separated string (this is what the com_fields/integer field was designed to do with multiples, Im not changing the "feature" Im fixing the bug.)

Actual result

A single integer is rendered because integer.php casts the resultant comma separated string to a (int)

After this PR a correctly rendered comma separated string is rendered

Documentation Changes Required

None

@PhilETaylor PhilETaylor changed the title from Allow multiple values for the integer field to [com_fields] Allow multiple values for the integer field May 20, 2017

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy May 20, 2017

Contributor

Warning: implode(): Invalid arguments passed in C:\xampp\htdocs\joomla371\plugins\fields\integer\tmpl\integer.php on line 21

Contributor

Quy commented May 20, 2017

Warning: implode(): Invalid arguments passed in C:\xampp\htdocs\joomla371\plugins\fields\integer\tmpl\integer.php on line 21

@PhilETaylor

This comment has been minimized.

Show comment
Hide comment
@PhilETaylor

PhilETaylor May 21, 2017

Contributor

Doh...

Contributor

PhilETaylor commented May 21, 2017

Doh...

@PhilETaylor

This comment has been minimized.

Show comment
Hide comment
@PhilETaylor

PhilETaylor May 21, 2017

Contributor

@Quy fixed :)

Contributor

PhilETaylor commented May 21, 2017

@Quy fixed :)

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy May 21, 2017

Contributor

I have tested this item successfully on 591bdb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16153.

Contributor

Quy commented May 21, 2017

I have tested this item successfully on 591bdb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16153.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig May 22, 2017

I have tested this item successfully on 591bdb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16153.

franz-wohlkoenig commented May 22, 2017

I have tested this item successfully on 591bdb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16153.

@joomla-cms-bot joomla-cms-bot added RTC and removed RTC labels May 22, 2017

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig May 22, 2017

RTC after two successful tests.

franz-wohlkoenig commented May 22, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label May 22, 2017

@rdeutz rdeutz modified the milestones: Joomla 3.7.3, Joomla 3.7.2 May 22, 2017

@rdeutz rdeutz merged commit 49738ec into joomla:staging May 22, 2017

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label May 22, 2017

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo May 22, 2017

Member

Thanks

Member

laoneo commented May 22, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment