New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css class option to image element of menu items #16456

Merged
merged 12 commits into from Jun 29, 2017

Conversation

Projects
None yet
7 participants
@mattiaverga
Contributor

mattiaverga commented Jun 3, 2017

Pull Request for Issue #16447 .

Summary of Changes

Currently we can set a custom class only for anchor element of a menu item.
This change add the option to set a custom class also for the image element associated to the menu item (if any). This way css sprites can be easily used to build menus with icons instead of using many single images, thus reducing overhead.

Testing Instructions

Simply add a new menu element and notice the presence of "Image CSS style" option under the "Link options" tab.

Expected result

Adding a class name under "Image CSS style" will apply a custom class to the img element of menu link item.

Actual result

It's not possible to add a custom class to the img element.

mattiaverga added some commits Jun 3, 2017

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jun 3, 2017

Contributor

I have tested this item 🔴 unsuccessfully on d484d88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

Contributor

brianteeman commented Jun 3, 2017

I have tested this item 🔴 unsuccessfully on d484d88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jun 3, 2017

Contributor

The language strings are not named the same in the xml as in the ini

COM_MENUS_ITEM_FIELD_MENU_IMAGE_CSS_LABEL

COM_MENUS_ITEM_FIELD_IMAGE_CSS_LABEL

Contributor

brianteeman commented Jun 3, 2017

The language strings are not named the same in the xml as in the ini

COM_MENUS_ITEM_FIELD_MENU_IMAGE_CSS_LABEL

COM_MENUS_ITEM_FIELD_IMAGE_CSS_LABEL

@mattiaverga

This comment has been minimized.

Show comment
Hide comment
@mattiaverga

mattiaverga Jun 3, 2017

Contributor

Yeah, LABEL and DESC were also inverted. Fixed.

Contributor

mattiaverga commented Jun 3, 2017

Yeah, LABEL and DESC were also inverted. Fixed.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jun 4, 2017

I have tested this item successfully on 28a1d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

franz-wohlkoenig commented Jun 4, 2017

I have tested this item successfully on 28a1d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

mattiaverga and others added some commits Jun 5, 2017

@mattiaverga

This comment has been minimized.

Show comment
Hide comment
@mattiaverga

mattiaverga Jun 22, 2017

Contributor

Should I correct something more?

Contributor

mattiaverga commented Jun 22, 2017

Should I correct something more?

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jun 22, 2017

I have tested this item successfully on aac7e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

franz-wohlkoenig commented Jun 22, 2017

I have tested this item successfully on aac7e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jun 22, 2017

@mattiaverga in Case no more Changes needed this PR needs next a second successfully Test.

franz-wohlkoenig commented Jun 22, 2017

@mattiaverga in Case no more Changes needed this PR needs next a second successfully Test.

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Jun 24, 2017

Contributor

I have tested this item successfully on aac7e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

Contributor

Quy commented Jun 24, 2017

I have tested this item successfully on aac7e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16456.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jun 24, 2017

RTC after two successful tests.

franz-wohlkoenig commented Jun 24, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 24, 2017

@rdeutz rdeutz added this to the Joomla 3.8.0 milestone Jun 25, 2017

@rdeutz rdeutz added the New Feature label Jun 25, 2017

@mbabker mbabker changed the base branch from staging to 3.8-dev Jun 29, 2017

@mbabker mbabker merged commit 048d545 into joomla:3.8-dev Jun 29, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-3.8-dev and removed RTC labels Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment