New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com_tags. Respect Browser Page Title in view Tagged Items #16773

Merged
merged 5 commits into from Jun 21, 2017

Conversation

Projects
None yet
5 participants
@ghost

ghost commented Jun 19, 2017

Pull Request for Issue #13365

Testing Instructions

  • See comment 1 in issue please #13365 (comment)
  • Apply patch
  • Test again
  • Please test also with other com_tags menu item types concerning conflicts because com_tags "is a little bit strange".
@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 19, 2017

I have tested this item successfully on 3065e59

Test with all 3 com_tags-Menu Item Types.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16773.

Quy and others added some commits Jun 19, 2017

Merge pull request #2 from Quy/patch-4
Remove unneccessary parentheses
@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 19, 2017

I have tested this item successfully on f8a4bec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16773.

Quy and others added some commits Jun 19, 2017

Merge pull request #3 from Quy/patch-5
Use elvis operator to simplify code
@ghost

This comment has been minimized.

ghost commented Jun 19, 2017

Sorry but because of some pedantry you have to test again...

@Quy

This comment has been minimized.

Contributor

Quy commented Jun 19, 2017

I have tested this item successfully on 1c2c611


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16773.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 20, 2017

@ghost couldn't test cause "Error: The patch could not be applied because the repository is missing" in Patchtester.

@Quy

This comment has been minimized.

Contributor

Quy commented Jun 20, 2017

The user deleted his Git account/branch. You will have to manually patch under Files changed to test.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 20, 2017

@Quy thanks for Info. Will wait for @ghost to append branch again for Test.

@Quy

This comment has been minimized.

Contributor

Quy commented Jun 20, 2017

ghost is a Git deleted user account. For more information:
http://help.github.com/articles/deleting-your-user-account

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 20, 2017

@Quy bad News, no Branch coming. Will look if i figure out to manually apply changed Files.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 21, 2017

I have tested this item successfully on 1c2c611 by manually patch view.html.php.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16773.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Jun 21, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 21, 2017

@rdeutz rdeutz merged commit 373bda8 into joomla:staging Jun 21, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot removed the RTC label Jun 21, 2017

@rdeutz rdeutz added this to the Joomla 3.7.3 milestone Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment