New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Fixes #16794

Merged
merged 3 commits into from Jun 21, 2017

Conversation

Projects
None yet
8 participants
@dgrammatiko
Contributor

dgrammatiko commented Jun 21, 2017

Pull Request for Issue #16590 .

Summary of Changes

List of changes:

  • Make all comparisons strict
  • fix the bottom buttons (clear, today, close)
  • Clear button disappeared if today button was disabled
  • Fix the inconsistency of manual input (enter, tab, etc)

Testing Instructions

Create a new article and fill the publishing fields with different methods (manual using the UI)
save the article
Edit again the fields (try clearing the filed with backspace, the clear button) and also change the values manually and using the UI
Report any remaining inconsistencies, if any

Expected result

Consistent behaviour

Actual result

Inconsistent behaviour

Documentation Changes Required

Calling @farhadst to crash test the Jallali calendar

if (ev.shiftKey) {
ev.preventDefault();
this.cellClick(self._nav_now, ev);
self.close()

This comment has been minimized.

@houndci-bot

houndci-bot Jun 21, 2017

Missing semicolon.

@infograf768

This comment has been minimized.

Member

infograf768 commented Jun 21, 2017

Please @farzadtaheri also test this in Persian

@infograf768

This comment has been minimized.

Member

infograf768 commented Jun 21, 2017

I have tested this item successfully on 9fd1e06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16794.

@infograf768 infograf768 added this to the Joomla 3.7.3 milestone Jun 21, 2017

@rdeutz rdeutz merged commit 78d8f9d into joomla:staging Jun 21, 2017

4 of 5 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@rdeutz rdeutz removed the release-blocker label Jun 21, 2017

@dgrammatiko

This comment has been minimized.

Contributor

dgrammatiko commented Jun 26, 2017

@farzadtaheri @farhadst can you please test Joomla 3.7.3 RC! This is really important, thank you

PS you can get the installable here: https://github.com/joomla/joomla-cms/releases/tag/3.7.3-rc1

@farzadtaheri

This comment has been minimized.

farzadtaheri commented Jun 27, 2017

@dgt41 i have this issue yet: #16628 in Joomla 3.7.3 RC!

@dgrammatiko

This comment has been minimized.

Contributor

dgrammatiko commented Jun 27, 2017

@farzadtaheri your solution Joomla.submitform('field.storeform', element.form); needs to be merged, can you do a PR for that?

@farzadtaheri

This comment has been minimized.

farzadtaheri commented Jun 27, 2017

@dgt41 please check #16721.

@farzadtaheri

This comment has been minimized.

farzadtaheri commented Jun 27, 2017

my solution Joomla.submitform('field.storeform', element.form); is work, but there is another problem after this change!
calendar fields time shift after each category field value change, when i set Asia/Tehran time zone (or another time zones) in configuration!
please see this issue #16665

@farhadst

This comment has been minimized.

farhadst commented Jun 27, 2017

@dgt41 I have test joomla 3.7.3 RC!
problem for select date by popup calendar fix and not reset but after set manual time and date and save it, time and date reset to today.

@dgrammatiko

This comment has been minimized.

Contributor

dgrammatiko commented Jun 28, 2017

time and date reset to today.

  • What was your input?
  • If what you entered was invalid the calendar falls back to today!
@infograf768

This comment has been minimized.

Member

infograf768 commented Jun 29, 2017

@dgt41
I confirm the issue

I copied a date in the future from an existing article publishing date and pasted it in an article just created.

Entering the date in the future (equivalent of 2017-09-29 10:57:00) :
screen shot 2017-06-29 at 10 59 59

After save
screen shot 2017-06-29 at 11 00 26

It works perfectly in Gregorian.

@infograf768

This comment has been minimized.

Member

infograf768 commented Jun 29, 2017

Equivalent in en-GB

screen shot 2017-06-29 at 11 07 22

@farhadst

This comment has been minimized.

farhadst commented Jun 29, 2017

@dgt41
I entered valid calendar like 1396-04-03 11:10:19 or by Persian number like ۱۳۹۶-۰۴-۰۳ ۱۱:۱۰:۱۹
In both cases after save calendar reset to current time and date

in Gregorian calendar every things is ok, type calendar by manual or popup calendar is fine

@infograf768

This comment has been minimized.

Member

infograf768 commented Jun 29, 2017

@farhadst
On it now. As soon as there is a patch we let you know

@infograf768

This comment has been minimized.

Member

infograf768 commented Jun 30, 2017

@farzadtaheri @farhadst Please test #16922 urgently

@drewgg

This comment has been minimized.

Contributor

drewgg commented Jul 19, 2017

Some of these issues may be related to #17171. I made some changes that fix those issues ( #17183 ) but it involves removing a conditional that I don't fully understand the purpose of (that conditional was added in this pull request).

@dgt41, could you weight in on the the purpose of the if (typeof calObj.dateClicked === 'undefined') { conditional and why the false path is needed?

Originally, instead of removing it, I changed it to if (typeof calObj.dateClicked === 'undefined' || !calObj.dateClicked) { which fixed it for all cases except when using the "today" button (which results in calObj.dateClicked = true causing the else path to be taken).

@dgrammatiko dgrammatiko deleted the dgrammatiko:#######CAL_PERSIAN branch Jul 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment