New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a fatal error for PHP 5.3 and a multilanguage side #16966

Merged
merged 2 commits into from Jul 4, 2017

Conversation

Projects
None yet
5 participants
@rdeutz
Contributor

rdeutz commented Jul 4, 2017

Pull Request for Issue #16965.

Summary of Changes

This reverts the last change form #13257

Testing Instructions

Test a multilanguage side under PHP 5.3.29. After applying the patch the fatal error should be gone.

@SniperSister

This comment has been minimized.

Show comment
Hide comment
@SniperSister

SniperSister Jul 4, 2017

Contributor

I have tested this item successfully on c13c78a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16966.

Contributor

SniperSister commented Jul 4, 2017

I have tested this item successfully on c13c78a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16966.

Show outdated Hide outdated libraries/cms/router/router.php
@@ -636,7 +636,7 @@ protected function processBuildRules(&$uri, $stage = self::PROCESS_DURING)
foreach ($this->_rules['build' . $stage] as $rule)
{
$rule($this, $uri);
- call_user_func_array($rule, array(&$this, &$uri));

This comment has been minimized.

@Quy

Quy Jul 4, 2017

Contributor

Remove - and tabs.

@Quy

Quy Jul 4, 2017

Contributor

Remove - and tabs.

This comment has been minimized.

@rdeutz

rdeutz Jul 4, 2017

Contributor

thanks

@rdeutz

rdeutz Jul 4, 2017

Contributor

thanks

@mbabker

mbabker approved these changes Jul 4, 2017

@mbabker mbabker merged commit 13182c3 into joomla:staging Jul 4, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@rdeutz rdeutz deleted the rdeutz:fix_16965 branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment