New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items list parent filter #17060

Merged
merged 17 commits into from Jul 25, 2017

Conversation

Projects
None yet
10 participants
@tonypartridge
Contributor

tonypartridge commented Jul 10, 2017

Pull Request for Issue #16882 .

Summary of Changes

Removes duplicate state filter
Added parent_id filtering

Testing Instructions

Install patch, view list of menu items. Select search tools to show more search options and a new filter is on the right. called '- Select Parent Menu Item -'.

Tony Partridge - xtech86
Tony Partridge - xtech86

@tonypartridge tonypartridge changed the title from Staging menu items parent filter to Menu items list parent filter Jul 10, 2017

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Jul 11, 2017

Contributor

Cool thank you :) Will test it asap

Contributor

coolcat-creations commented Jul 11, 2017

Cool thank you :) Will test it asap

@GeraintEdwards

This comment has been minimized.

Show comment
Hide comment
@GeraintEdwards

GeraintEdwards Jul 11, 2017

Contributor

Test failed :(

Select 'Site Map' as parent_id and the list does indeed filter to show the correct subitems but the 'search tools disappear' - you need to add parent_id and a.parent_id to $config['filter_fields'] in the model constructor otherwise the 'search tools' disappear when you select a parent filter (with no other filters enabled).

Additionally it would be good for the parent item list to be filtered based on the main 'menu filter'.

Contributor

GeraintEdwards commented Jul 11, 2017

Test failed :(

Select 'Site Map' as parent_id and the list does indeed filter to show the correct subitems but the 'search tools disappear' - you need to add parent_id and a.parent_id to $config['filter_fields'] in the model constructor otherwise the 'search tools' disappear when you select a parent filter (with no other filters enabled).

Additionally it would be good for the parent item list to be filtered based on the main 'menu filter'.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jul 11, 2017

@GeraintEdwards i altered your unsuccessfully Test at issue Tracker.

franz-wohlkoenig commented Jul 11, 2017

@GeraintEdwards i altered your unsuccessfully Test at issue Tracker.

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 11, 2017

Contributor

Thanks @GeraintEdwards now resolved.

Contributor

tonypartridge commented Jul 11, 2017

Thanks @GeraintEdwards now resolved.

@GeraintEdwards

This comment has been minimized.

Show comment
Hide comment
@GeraintEdwards

GeraintEdwards Jul 11, 2017

Contributor

I have tested this item successfully on ad24cdb

Menu items are filtered correctly and the filter remains visible in the 'search tools'


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.

Contributor

GeraintEdwards commented Jul 11, 2017

I have tested this item successfully on ad24cdb

Menu items are filtered correctly and the filter remains visible in the 'search tools'


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.

Added new field filter for menu items which is filter dynamically by …
…Menu Type if is filtered by Menu Type.
@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 11, 2017

Contributor

Now updated @coolcat-creations @GeraintEdwards to include a custom field type which dynamically filters the menu items by menu type if the menu items in the list are already filter by type.

Contributor

tonypartridge commented Jul 11, 2017

Now updated @coolcat-creations @GeraintEdwards to include a custom field type which dynamically filters the menu items by menu type if the menu items in the list are already filter by type.

tonypartridge added some commits Jul 11, 2017

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 11, 2017

Contributor

@rdeutz jenkis php70 docker isn't connecting?

Contributor

tonypartridge commented Jul 11, 2017

@rdeutz jenkis php70 docker isn't connecting?

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Jul 11, 2017

Contributor

I have tested this item successfully on 0b3ed6f

Thank you, it works! Great improvement for large sites :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.

Contributor

coolcat-creations commented Jul 11, 2017

I have tested this item successfully on 0b3ed6f

Thank you, it works! Great improvement for large sites :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig commented Jul 11, 2017

@GeraintEdwards can you please retest?

@GeraintEdwards

This comment has been minimized.

Show comment
Hide comment
@GeraintEdwards

GeraintEdwards Jul 11, 2017

Contributor

I have tested this item successfully on 0b3ed6f

Filtering by menu type is a big functional improvement - thanks for adding it in.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.

Contributor

GeraintEdwards commented Jul 11, 2017

I have tested this item successfully on 0b3ed6f

Filtering by menu type is a big functional improvement - thanks for adding it in.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jul 11, 2017

RTC after two successful tests.

franz-wohlkoenig commented Jul 11, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 11, 2017

@rdeutz rdeutz added this to the Joomla 3.8.0 milestone Jul 11, 2017

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Jul 12, 2017

Contributor

@tonypartridge you don't need to care about the new jenkins setup, we are still in testing mode

Contributor

rdeutz commented Jul 12, 2017

@tonypartridge you don't need to care about the new jenkins setup, we are still in testing mode

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 12, 2017

Contributor
Contributor

tonypartridge commented Jul 12, 2017

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Jul 12, 2017

Contributor

travis and drone are required

Contributor

rdeutz commented Jul 12, 2017

travis and drone are required

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 12, 2017

Contributor

Made some slight changes as per @Quy 's request. Should not need retesting, nothing has changed apart from code style.

Contributor

tonypartridge commented Jul 12, 2017

Made some slight changes as per @Quy 's request. Should not need retesting, nothing has changed apart from code style.

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Jul 12, 2017

Contributor

Actually, the lines should be moved after line 39.

Contributor

Quy commented Jul 12, 2017

Actually, the lines should be moved after line 39.

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 17, 2017

Contributor

@rdeutz has someone changed AppVeyor? This passed last week without issue, all I have done is moved language strings around in the .xml for @Quy ?

Contributor

tonypartridge commented Jul 17, 2017

@rdeutz has someone changed AppVeyor? This passed last week without issue, all I have done is moved language strings around in the .xml for @Quy ?

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Jul 17, 2017

Contributor

@tonypartridge it's nothing you can really count on, if they have failed I look into it and most of the time it is simply a wrong test result

Contributor

rdeutz commented Jul 17, 2017

@tonypartridge it's nothing you can really count on, if they have failed I look into it and most of the time it is simply a wrong test result

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 19, 2017

Contributor
Contributor

tonypartridge commented Jul 19, 2017

@mbabker mbabker merged commit 66c9057 into joomla:staging Jul 25, 2017

3 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/drone/pr this build is pending
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot removed the RTC label Jul 25, 2017

@tonypartridge

This comment has been minimized.

Show comment
Hide comment
@tonypartridge

tonypartridge Jul 25, 2017

Contributor
Contributor

tonypartridge commented Jul 25, 2017

roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jul 26, 2017

Merge branch 'staging' into redo-7259-modal-for-quicker-edit
* staging: (274 commits)
  Add JCryptCipherSodium to support libsodium (#16754)
  Performance 2 (libraries/legacy) (#12220)
  Performance 6 (templates) (#12233)
  Fixed typehint (#16425)
  Fix for: Repeatable field is no longer rendered with Chosen layout (#16471)
  Fix the path for the ajax-loader.gif (#16701)
  Menu items list parent filter (#17060)
  Text Filters layout (#17113)
  mod_login showon option (#17153)
  com_banners incorret tooltip (#17157)
  fix joomla.content.options_default (#17123)
  remove the never working limitstart call (#17184)
  Update phpDocumentor build
  set 3.8.0 Dev State
  Prepare 3.7.4 Stable Release
  fixed a logic change in #12294, thanks @Hoffi1
  Update sv-SE.ini
  Update pt-BR.ini
  Update lv-LV.ini
  Update fa-IR.ini
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment