Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable show_email_copy per default for new installations #17848

Merged
merged 3 commits into from Sep 5, 2017

Conversation

Projects
None yet
8 participants
@zero-24
Copy link
Contributor

zero-24 commented Sep 3, 2017

Summary of Changes

Disable show_email_copy per default for new installations. cc @SniperSister

Testing Instructions

Expected result

per default a new form on a new install does not have show_email_copy enabled

Actual result

per default a new form have show_email_copy enabled

@@ -38,7 +38,7 @@
<div class="control-label"><?php echo $this->form->getLabel('contact_message'); ?></div>
<div class="controls"><?php echo $this->form->getInput('contact_message'); ?></div>
</div>
<?php if ($this->params->get('show_email_copy')){ ?>
<?php if ($this->params->get('show_email_copy', '0')){ ?>

This comment has been minimized.

Copy link
@Quy

Quy Sep 3, 2017

Contributor

Change { to :
Change } to endif;

This comment has been minimized.

Copy link
@zero-24

zero-24 Sep 3, 2017

Author Contributor

this is a feature PR not a codestyle PR ;) I'm happy to do this in the next batches. ;)

@@ -129,7 +129,7 @@ public function submit()
if (!$params->get('custom_reply'))
{
$sent = $this->_sendEmail($data, $contact, $params->get('show_email_copy'));
$sent = $this->_sendEmail($data, $contact, $params->get('show_email_copy', '0'));

This comment has been minimized.

Copy link
@n9iels

n9iels Sep 3, 2017

Contributor

Should this not be a integer 0? (Not meant as code style)

@n9iels

This comment has been minimized.

Copy link
Contributor

n9iels commented Sep 3, 2017

I have tested this item successfully on fb14433


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17848.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Sep 3, 2017

finally - ;)

@SniperSister

This comment has been minimized.

Copy link
Contributor

SniperSister commented Sep 4, 2017

I have tested this item successfully on fb14433


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17848.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

franz-wohlkoenig commented Sep 4, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Sep 4, 2017

@zero-24 zero-24 added this to the Joomla 3.8.0 milestone Sep 4, 2017

@mbabker mbabker merged commit cc90941 into joomla:staging Sep 5, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot removed the RTC label Sep 5, 2017

@zero-24 zero-24 deleted the zero-24:copymail branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.