New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery Autocomplete to 1.4.7 #18113

Merged
merged 2 commits into from Dec 18, 2017

Conversation

Projects
None yet
6 participants
@viocassel
Contributor

viocassel commented Sep 25, 2017

Summary of Changes

This PR updates jQuery Autocomplete library to version 1.4.3 for com_finder and mod_finder.

Testing Instructions

  1. Apply patch
  2. Test the com_finder and mod_finder typing any word in search field (for example, joomla)
  3. Make sure there are no JS errors and the list dropdown displayed correctly.

Result

com_finder
com_finder

mod_finder
mod_finder

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Sep 26, 2017

I have tested this item 🔴 unsuccessfully on a9e3f62


Test on Module "Smart Search" and Menu "Smart Search > Search" got Notice:

bildschirmfoto 2017-09-26 um 08 54 17


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18113.
@C-Lodder

This comment has been minimized.

Member

C-Lodder commented Sep 26, 2017

@franz-wohlkoenig - This is only a notice and not an error, so it should not result in an unsuccessful test

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Sep 26, 2017

I have tested this item successfully on a9e3f62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18113.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Oct 22, 2017

This is an easy Test. Needs a second successfully Test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18113.

@Quy

This comment has been minimized.

Contributor

Quy commented Oct 24, 2017

How do you enable Autocomplete? I don't get the dropdown choices.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Oct 24, 2017

@Quy have you indexed the Articles?

@Quy

This comment has been minimized.

Contributor

Quy commented Oct 24, 2017

Yes indexed under Smart Search >Indexed Content, but still no suggestions dropdown.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Oct 25, 2017

@ Tested again, it works:

  • Module "Smart Search": Type "joo" and Dropdown is showing
  • Menu "Smart Search": Type "joo" and Dropdown is showing
@Quy

This comment has been minimized.

Contributor

Quy commented Dec 11, 2017

It is now up to v1.4.6.

Update jQuery Autocomplete to 1.4.7
Updated jQuery Autocomplete to 1.4.7

Please test...
@viocassel

This comment has been minimized.

Contributor

viocassel commented Dec 11, 2017

Updated jQuery Autocomplete to 1.4.7

Please test...

@viocassel viocassel changed the title from Update jQuery Autocomplete to 1.4.3 to Update jQuery Autocomplete to 1.4.7 Dec 11, 2017

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 11, 2017

@Quy

This comment has been minimized.

Contributor

Quy commented Dec 11, 2017

I have tested this item successfully on ca69b89


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18113.

1 similar comment
@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 12, 2017

I have tested this item successfully on ca69b89


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18113.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.4 milestone Dec 12, 2017

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 12, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 12, 2017

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 18, 2017

@mbabker mbabker merged commit e72493d into joomla:staging Dec 18, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Dec 18, 2017

@viocassel viocassel deleted the viocassel:update-jquery-autocomplete branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment