New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menu.php #18156

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Projects
None yet
7 participants
@Webdongle
Contributor

Webdongle commented Sep 29, 2017

Checking view level of menu item in the admin components menu is not needed. Display of those menu items is controlled by the Permissions in component options not by User Group view level. Corrects error causing #18000 (comment)

Pull Request for Issue # .
#18000

Summary of Changes

Deleted lines that checked view levels in admin menu items

Testing Instructions

  • Set Global Config > Default Access Level --> Guest
  • Install a 3rd party component

Expected result

Menu item for the 3rd party component should be seen

Actual result

Menu item for the 3rd party component is not seen because it is 'Guest' level and SU is not in 'Guest' user group.

Extra tests

Create a test user and set as Administrator
In the Menu item for the 3rd party component's Options set the Administrator Permissions for 'Access Administration Interface ' as 'Denied'
Login with the Test user and make sure the Permission settings are being honoured.

Documentation Changes Required

Update menu.php
Checking view level of menu item in the admin components menu is not needed.  Display of those menu items is controlled by the Permissions in component options not  by User Group view level.  Corrects error causing #18000 (comment)
@izharaazmi

This comment has been minimized.

Show comment
Hide comment
@izharaazmi

izharaazmi Sep 29, 2017

Contributor

If first point in my #18000 (comment) is right then this fix is correct. Not because this fixes the issue we are talking of, rather because of the nature of viewing access levels.

Contributor

izharaazmi commented Sep 29, 2017

If first point in my #18000 (comment) is right then this fix is correct. Not because this fixes the issue we are talking of, rather because of the nature of viewing access levels.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Sep 29, 2017

Contributor

I have tested this item successfully on bd1d805

Patch ok for me.
Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18156.

Contributor

AlexRed commented Sep 29, 2017

I have tested this item successfully on bd1d805

Patch ok for me.
Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18156.

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Sep 29, 2017

Member

I have tested this item successfully on bd1d805

Looks OK to me here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18156.
Member

infograf768 commented Sep 29, 2017

I have tested this item successfully on bd1d805

Looks OK to me here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18156.
@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Sep 29, 2017

RTC after two successful tests.

franz-wohlkoenig commented Sep 29, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Sep 29, 2017

@mbabker mbabker added this to the Joomla 3.8.1 milestone Sep 30, 2017

@mbabker mbabker merged commit 3e87e32 into joomla:staging Sep 30, 2017

4 of 5 checks passed

continuous-integration/drone/pr this build is pending
Details
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Sep 30, 2017

@Webdongle Webdongle deleted the Webdongle:patch-1 branch Sep 30, 2017

Denitz added a commit to Denitz/joomla-cms that referenced this pull request Oct 3, 2017

Remove view access level checks from admin menu (#18156)
Checking view level of menu item in the admin components menu is not needed.  Display of those menu items is controlled by the Permissions in component options not  by User Group view level.  Corrects error causing joomla#18000 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment