New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChangeItem] - the check query should return array instead of object - PHP 7.2 #18443

Merged
merged 2 commits into from Jan 3, 2018

Conversation

Projects
None yet
6 participants
@alikon
Contributor

alikon commented Oct 30, 2017

Pull Request for Issue #18437.

Summary of Changes

from object loadObject() to array loadRowList(0)

Testing Instructions

see #18437 with php 7.2
test that Database check works as before

@ghazal

This comment has been minimized.

Contributor

ghazal commented Dec 7, 2017

This change helped me solve a restoration pb with Akeeba with PHP 7.2.0.
Same error as in issue #18437 after restoration from a server with PHP 7.1.7 to the one with
PHP 7.2.0.
I had to delete the file 2.5.0-2011-12-24.sql though.

Well, it seems that this has not been implemented yet in the most recent distribution. ???

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 7, 2017

@ghazal this Pull Request has not 2 successfully Tests.

@ghazal

This comment has been minimized.

Contributor

ghazal commented Dec 7, 2017

I have tested this item successfully on 502c62c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.

@alikon alikon changed the title from [ChangeItem] - the check query should return array instead of object to [ChangeItem] - the check query should return array instead of object - PHP 7.2 Dec 7, 2017

@ghazal

This comment has been minimized.

Contributor

ghazal commented Dec 7, 2017

Quick check with J!3.8.3.RC - a fresh install - on a PHP 7.2.0 environment.
Same pb.
Same solution.
No surprise.

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 11, 2017

@Quy

This comment has been minimized.

Contributor

Quy commented Dec 24, 2017

Tested with PR #19134.

Do you know why this was detected?
Table 'ch56a_menu' does not have index 'idx_client_id_parent_id_alias_language'. (From file 2.5.0-2011-12-24.sql.)
which resulted:
Duplicate key name 'idx_client_id_parent_id_alias_language'

without this PR:

    Database schema version (3.8.2-2017-10-14) does not match CMS version (3.9.0-2017-12-22).
    Table 'zcag2_content' does not have column 'note'. (From file 3.9.0-2017-12-22.sql.)

with this PR:

    Database schema version (3.8.2-2017-10-14) does not match CMS version (3.9.0-2017-12-22).
    Table 'ch56a_menu' does not have index 'idx_client_id_parent_id_alias_language'. (From file 2.5.0-2011-12-24.sql.)
    Table 'ch56a_content' does not have column 'note'. (From file 3.9.0-2017-12-22.sql.)
@alikon

This comment has been minimized.

Contributor

alikon commented Dec 29, 2017

i'll look at it....

@alikon

This comment has been minimized.

Contributor

alikon commented Dec 29, 2017

@Quy can you re-check ?
@ghazal please re-test

@Quy

This comment has been minimized.

Contributor

Quy commented Dec 29, 2017

I have tested this item successfully on 86c4cc8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.

1 similar comment
@ghazal

This comment has been minimized.

Contributor

ghazal commented Dec 29, 2017

I have tested this item successfully on 86c4cc8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.4 milestone Dec 29, 2017

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 29, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 29, 2017

@alikon

This comment has been minimized.

Contributor

alikon commented Dec 29, 2017

can someone re-add the 3.8.4 milestone ?

@mbabker mbabker added this to the Joomla 3.8.4 milestone Jan 3, 2018

@mbabker mbabker merged commit cd1852c into joomla:staging Jan 3, 2018

4 of 5 checks passed

continuous-integration/drone/pr the build failed
Details
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot removed the RTC label Jan 3, 2018

@alikon alikon deleted the alikon:patch-96 branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment