New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin menu module - fix preset modern for postgresql #18537

Merged
merged 1 commit into from Nov 24, 2017

Conversation

Projects
None yet
5 participants
@csthomas
Contributor

csthomas commented Nov 9, 2017

Summary of Changes

Fix sql error in postgresql database in admin menu.

Testing Instructions

Error exists only on postgresql.

Before patch

jpeek0

After patch

jpeek1

@joomla-cms-bot joomla-cms-bot added PR-staging and removed PR-staging labels Nov 9, 2017

@alikon

This comment has been minimized.

Show comment
Hide comment
@alikon

alikon Nov 9, 2017

Contributor

I have tested this item successfully on 1471f13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18537.

Contributor

alikon commented Nov 9, 2017

I have tested this item successfully on 1471f13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18537.

@csthomas

This comment has been minimized.

Show comment
Hide comment
@csthomas

csthomas Nov 16, 2017

Contributor

As my change is equal to the same line in

sql_group="a.id, m.language, l.image"

another test may be done by code review or by test on mysql only.

Contributor

csthomas commented Nov 16, 2017

As my change is equal to the same line in

sql_group="a.id, m.language, l.image"

another test may be done by code review or by test on mysql only.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Nov 19, 2017

I have tested this item successfully on 1471f13

System information

3.8.3-dev
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • PHP 7.0.22
  • MySQLi 5.6.35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18537.

franz-wohlkoenig commented Nov 19, 2017

I have tested this item successfully on 1471f13

System information

3.8.3-dev
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • PHP 7.0.22
  • MySQLi 5.6.35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18537.
@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Nov 19, 2017

Ready to Commit after two successful tests.

franz-wohlkoenig commented Nov 19, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 19, 2017

@mbabker mbabker added this to the Joomla 3.8.3 milestone Nov 24, 2017

@mbabker mbabker merged commit 9b479c9 into joomla:staging Nov 24, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Nov 24, 2017

@csthomas csthomas deleted the csthomas:pgsql_admin_menu_modern branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment