New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemirror updated to 5.33.0 #18880

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
5 participants
@okonomiyaki3000
Contributor

okonomiyaki3000 commented Nov 27, 2017

Pull Request for Issue # .

Summary of Changes

http://codemirror.net/doc/releases.html

Testing Instructions

Use CodeMirror

Expected result

It should work as usual.

Actual result

It works.

Documentation Changes Required

No

@okonomiyaki3000

This comment has been minimized.

Contributor

okonomiyaki3000 commented Dec 4, 2017

The check is wrong. This does not fail.

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 11, 2017

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Dec 21, 2017

could you update this to 5.33 please and then i can test it

@okonomiyaki3000

This comment has been minimized.

Contributor

okonomiyaki3000 commented Dec 22, 2017

And don't forget these other fine CodeMirror PRs:

#12542
#17042
#18881

@joomla-cms-bot joomla-cms-bot changed the title from Codemirror updated to 5.32.0 to Codemirror updated to 5.33.0 Dec 23, 2017

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.4 milestone Dec 23, 2017

@Quy

This comment has been minimized.

Contributor

Quy commented Dec 23, 2017

I have tested this item successfully on 79008a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18880.

@okonomiyaki3000

This comment has been minimized.

Contributor

okonomiyaki3000 commented Jan 18, 2018

Really, still? These usually merge right away...

@mbabker mbabker added this to the Joomla 3.8.4 milestone Jan 18, 2018

@mbabker mbabker merged commit df37e78 into joomla:staging Jan 18, 2018

4 of 5 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
@okonomiyaki3000

This comment has been minimized.

Contributor

okonomiyaki3000 commented Jan 18, 2018

Thanks!

@okonomiyaki3000 okonomiyaki3000 deleted the okonomiyaki3000:CodeMirror-Update branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment