New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#18964] Tag filter in blog category with pagination selects wrong page on start of new user session #18965

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
6 participants
@kanich
Contributor

kanich commented Dec 3, 2017

[#18964] - Tag filter in blog category with pagination selects wrong page on start of new user session

The wrong page selection appears by very specific conditions for anonymous users when they have not yet assigned user session. Direct request to second or any later page for blog category opens each time first page of given blog category.

Especially annoying is this bug in case when is used page caching and external crawlers visit the site without keeping session variables. Then in some time are all pages of blog category filled by first page content.
Steps to reproduce the issue

Create category e.g. 'News'
Create tag e.g. 'Science'
Create 4 articles for category 'News' with tag 'Science'
Create new menu item 'Science' for blog category 'News' with assigned tag 'Science' and 2 articles in 1 column per page
Disable any Joomla caching (global as well as page one).
Now on frontend are available for menu item 'Science' two pages (each with 2 articles and pagination buttons), select second page (with start=2) and assign it as bookmark in the browser. In browser assign blank page as initial page, delete all cookies for given site and close browser.
Open browser, click on prepared link for the second page of 'Science'.

Expected result

response is SECOND page of tagged blog category with pagination having more pages
Actual result

response is FIRST page of tagged blog category with pagination having more pages
Additional comments

Solution for issue #17711 #17711 is good but it did not cover solution for described bug.

Update category.php
[#18964] - Tag filter in blog category with pagination selects wrong page on start of new user session

@joomla-cms-bot joomla-cms-bot changed the title from Tag filter in blog category with pagination selects wrong page on start of new user session - issue [#18964] to Tag filter in blog category with pagination selects wrong page on start of new user session Dec 3, 2017

@joomla-cms-bot joomla-cms-bot added PR-staging and removed PR-staging labels Dec 3, 2017

@joomla-cms-bot joomla-cms-bot changed the title from Tag filter in blog category with pagination selects wrong page on start of new user session to [#18964] Tag filter in blog category with pagination selects wrong page on start of new user session Dec 3, 2017

@rpbikker

This comment has been minimized.

rpbikker commented Dec 3, 2017

I have tested this item successfully on c0f201e

I can confirm issue #18964 and that this PR apparently solves it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18965.

@ladyjer

This comment has been minimized.

Contributor

ladyjer commented Dec 4, 2017

I have tested this item successfully on c0f201e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18965.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 4, 2017

Ready to Commit after two successful tests.

Thanks for Tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 4, 2017

@mbabker mbabker added this to the Joomla 3.8.3 milestone Dec 5, 2017

@mbabker mbabker merged commit 71bfb8f into joomla:staging Dec 5, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment