New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filepath to PHPMailer language file #19072

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
7 participants
@mbabker
Member

mbabker commented Dec 14, 2017

Partial Pull Request for Issue #19071

Summary of Changes

From what I can tell, after PHPMailer/PHPMailer@6a6165f introduced in PHPMailer 5.2.17 our language file loading has been broken for the library. This fixes it.

Testing Instructions

Whatever it takes to get language strings out of PHPMailer should now be translated with Joomla's strings versus the hardcoded English that'll be loading now.

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 14, 2017

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Dec 14, 2017

I tested this in j4 against the issue i reported in 19071. the problem is that it solves the issue of the message appearing incorrectly that I reported then but now I cant create an error to test that the message is now correct. So I am guessing the previous error message was completely incorrect and that by fixing the bug here it has resolved that

@mbabker

This comment has been minimized.

Member

mbabker commented Dec 14, 2017

No idea to be honest. I didn't even actually test mail sending, I went straight for the "language file not loading correctly" thing since that can be debugged/fixed without sending mail and traced through that until I had a correct file name/path.

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Dec 15, 2017

I have tested this item successfully on 113cb20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.

1 similar comment
@Quy

This comment has been minimized.

Contributor

Quy commented Dec 15, 2017

I have tested this item successfully on 113cb20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.4 milestone Dec 15, 2017

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 15, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Dec 15, 2017

@Anu1601CS

This comment has been minimized.

Contributor

Anu1601CS commented Dec 16, 2017

I have tested this item successfully on 113cb20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Dec 16, 2017

@Anu1601CS thanks for Test. As this is a Pull Request (PR) which is set "Ready to Commit" (RTC) its not necessary to test again.

Maybe you can list on Issue Tracker PR having one Test and need a second one (click st "Search Tools" then "Tests" > "Needs one")?

@Anu1601CS

This comment has been minimized.

Contributor

Anu1601CS commented Dec 16, 2017

ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19072.

@infograf768

This comment has been minimized.

Member

infograf768 commented Dec 17, 2017

What is the impact of this for non-en-GB languages?

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Dec 17, 2017

The untranslated strings from phpmailer will be correctly translated by joomla

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 18, 2017

@mbabker mbabker merged commit 66ae9cb into joomla:staging Dec 18, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Dec 18, 2017

@mbabker mbabker deleted the mbabker:fix-mailer-language-path branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment