From 00567a1d4aa927b8110cf4d3fde8761d852c0be8 Mon Sep 17 00:00:00 2001
From: Quy <quy@fluxbb.org>
Date: Mon, 4 Jun 2018 20:44:43 -0700
Subject: [PATCH] Display 404 page if banner not found

---
 components/com_banners/models/banner.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/components/com_banners/models/banner.php b/components/com_banners/models/banner.php
index d0e8ee1624f8a..8685433ed5305 100644
--- a/components/com_banners/models/banner.php
+++ b/components/com_banners/models/banner.php
@@ -35,6 +35,13 @@ class BannersModelBanner extends JModelLegacy
 	 */
 	public function click()
 	{
+		$item = $this->getItem();
+
+		if (empty($item))
+		{
+			throw new Exception(JText::_('JERROR_PAGE_NOT_FOUND'), 404);
+		}
+
 		$id = $this->getState('banner.id');
 
 		// Update click count
@@ -55,8 +62,6 @@ public function click()
 			JError::raiseError(500, $e->getMessage());
 		}
 
-		$item = $this->getItem();
-
 		// Track clicks
 		$trackClicks = $item->track_clicks;