Skip to content

[3.9] Add Argon2id Password Support - #20855

Merged
mbabker merged 4 commits into
joomla:3.9-devfrom
zero-24:argon2id
Aug 28, 2018
Merged

mbabker merged 4 commits into
joomla:3.9-devfrom
zero-24:argon2id

Conversation

@zero-24

@zero-24 zero-24 commented Jun 24, 2018

Copy link
Copy Markdown
Contributor

Pull Request for Issue #20826

Summary of Changes

Per https://wiki.php.net/rfc/argon2_password_hash_enhancements Argon2id password hashes will be supported in PHP 7.3. We should add support for this alongside our existing Argon2i logic.

Testing Instructions

review

Expected result

Argon2id PW supported

Actual result

Argon2id PW NOT supported

Documentation Changes Required

@mbabker can you tell me where you documented the Argon2i support?

@HLeithner

Copy link
Copy Markdown
Member

I think this will not work.
You have to check for "$argon2id" before checking for "$argon2i" in the if Statement because strpos "$argon2i" will already be true for "$argon2id"

@zero-24

zero-24 commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

fixed by the last commit thanks @HLeithner

@mbabker

mbabker commented Jun 24, 2018

Copy link
Copy Markdown
Contributor

can you tell me where you documented the Argon2i support?

It's not really documented anywhere. We don't have a place covering this part of the API AFAIK.

@zero-24 zero-24 added this to the Joomla 3.9.0 milestone Jun 24, 2018
@HLeithner

Copy link
Copy Markdown
Member

J4i the rfc has been accepted and is already implemented in php 7.3.

@HLeithner

Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on c09b09d

Successfully on PHP 7.3.0alpha4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20855.

@zero-24
zero-24 deleted the argon2id branch August 29, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants