[3.9] Add Argon2id Password Support #20855
Merged
Conversation
I think this will not work. |
fixed by the last commit thanks @HLeithner |
It's not really documented anywhere. We don't have a place covering this part of the API AFAIK. |
J4i the rfc has been accepted and is already implemented in php 7.3. |
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20855. |
e8652f7
into
joomla:3.9-dev
3 of 5 checks passed
3 of 5 checks passed
Hound
No violations found. Woof!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pull Request for Issue #20826
Summary of Changes
Per https://wiki.php.net/rfc/argon2_password_hash_enhancements Argon2id password hashes will be supported in PHP 7.3. We should add support for this alongside our existing Argon2i logic.
Testing Instructions
review
Expected result
Argon2id PW supported
Actual result
Argon2id PW NOT supported
Documentation Changes Required
@mbabker can you tell me where you documented the Argon2i support?