Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSearch implementation #20937

Merged
merged 1 commit into from Jul 7, 2018

Conversation

Projects
None yet
5 participants
@Hackwar
Copy link
Member

Hackwar commented Jun 30, 2018

OpenSearch allows you to (for example) add your site search to the search engines of your browser. Right now, this does not work and has been broken for about a year (See 00d8bac)

This PR fixes the OpenSearchDescription.

How to test

  • Open your site in Firefox and go to a page with mod_search displayed.
  • In the address bar, there is a menu (the three horizontal dots). In that menu, you have an entry "Add searchengine" (The last menuitem) Click that and see that it throws an error message shortly after that it couldn't install the search engine.
  • Apply patch and click the link again and see, that it works now.

I discovered this issue while working on com_finder for 4.0 and I also fixed the issue there, too. So while you are at it, it would be really nice if you could test #20936 also. 馃槃

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Jun 30, 2018

I have tested this item successfully on fb3e3f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20937.

@franz-wohlkoenig

This comment has been minimized.

Copy link

franz-wohlkoenig commented Jul 2, 2018

I have tested this item successfully on fb3e3f7

System information

  • 3.8.11-dev
  • Template: Protostar
  • macOS Sierra, 10.13.5
  • Firefox 61 (64-bit)

CloudAccess.net

@franz-wohlkoenig

This comment has been minimized.

Copy link

franz-wohlkoenig commented Jul 2, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Jul 2, 2018

@mbabker mbabker added this to the Joomla 3.8.11 milestone Jul 7, 2018

@mbabker mbabker merged commit a010e1c into joomla:staging Jul 7, 2018

4 of 5 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.