Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_articles_category] Showon #20950

Merged
merged 3 commits into from Jul 7, 2018
Merged

[mod_articles_category] Showon #20950

merged 3 commits into from Jul 7, 2018

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jul 2, 2018

Pull Request for Issue # .

Summary of Changes

This adds showon attribute to form fields in Articles - Category module.

Testing Instructions

Code review. Or create Articles - Category module and try different options. Check that fields are shown/hidden correctly.

Documentation Changes Required

Option from Dynamic Mode Options moved to Module tab. Update help page? https://docs.joomla.org/Help38:Extensions_Module_Manager_Articles_Category

@SharkyKZ SharkyKZ requested a review from brianteeman as a code owner Jul 2, 2018
@SharkyKZ SharkyKZ changed the title Mod articles category showon [mod_articles_category] Showon Jul 2, 2018
@@ -52,7 +53,7 @@ MOD_ARTICLES_CATEGORY_FIELD_MODE_DESC="Please select the mode you would like to
MOD_ARTICLES_CATEGORY_FIELD_MODE_LABEL="Mode"
MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC="Please enter in a valid date format. See: http://php.net/date for formatting information."
MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_LABEL="Month and Year Display Format"
MOD_ARTICLES_CATEGORY_FIELD_RELATIVEDATE_DESC="If Relative Date is selected above, please enter in a numeric day value. Results will be retrieved relative to the current date and the value you enter."
MOD_ARTICLES_CATEGORY_FIELD_RELATIVEDATE_DESC="Please enter in a numeric day value. Results will be retrieved relative to the current date and the value you enter."

This comment has been minimized.

@brianteeman

brianteeman Jul 2, 2018
Member

==> "Please enter a numeric value"

>
<option value="krsort">MOD_ARTICLES_CATEGORY_OPTION_DESCENDING_VALUE</option>
<option value="ksort">MOD_ARTICLES_CATEGORY_OPTION_ASCENDING_VALUE</option>
</field>

<field

This comment has been minimized.

@brianteeman

brianteeman Jul 2, 2018
Member

Why is this field removed?

This comment has been minimized.

@SharkyKZ

SharkyKZ Jul 2, 2018
Author Contributor

It's moved above.

This comment has been minimized.

@brianteeman

brianteeman Jul 2, 2018
Member

I need more coffee ;)

Copy link
Member

@brianteeman brianteeman left a comment

approve language string changes

@ghost
Copy link

@ghost ghost commented Jul 2, 2018

I have tested this item successfully on 35e8db5

Test using "Modules: Articles - Category", works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20950.

@Quy
Copy link
Contributor

@Quy Quy commented Jul 2, 2018

I have tested this item successfully on 35e8db5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20950.

@Quy
Copy link
Contributor

@Quy Quy commented Jul 2, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20950.

@mbabker mbabker added this to the Joomla 3.8.11 milestone Jul 7, 2018
@mbabker mbabker merged commit bf4c7dc into joomla:staging Jul 7, 2018
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
@joomla-cms-bot
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Jul 7, 2018
@SharkyKZ SharkyKZ deleted the SharkyKZ:modArticlesCategoryShowon branch Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants