New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW FEATURE] Adding Edit Associations Toolbar #21022
Conversation
Looks like this needs some cs corrections to make drone happy... |
} | ||
else | ||
{ | ||
if ($data['language'] === '*') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion. Lines 1579-1596 don’t need to be in the else statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, will correct.
@@ -281,6 +281,7 @@ JGLOBAL_ARTICLE_ORDER_DESC="The order that articles will show in." | |||
JGLOBAL_ARTICLE_ORDER_LABEL="Article Order" | |||
JGLOBAL_ARTICLES="Articles" | |||
JGLOBAL_ASSOC_NOT_POSSIBLE="To define associations, please make sure the item language is not set to 'All'." | |||
JGLOBAL_ASSOCIATIONS_NEW_ITEM_WARNING="To edit associations, first save the item." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
==> To create an association, first save the item.
But can this actually be displayed as the button isnt presnt until you have saved the item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a security warning in case something goes wrong. Will change string as indeed when not saved one can't edit any assoc.
@@ -924,6 +925,7 @@ JTOOLBAR_DELETE_ALL="Delete All" | |||
JTOOLBAR_DISABLE="Disable" | |||
JTOOLBAR_DUPLICATE="Duplicate" | |||
JTOOLBAR_EDIT="Edit" | |||
JTOOLBAR_EDIT_ASSOCIATIONS="Edit Associations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is both edit and create so let's just say "Associations"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been wondering about that. The issue is that we already have an Associations Tab.
Other than my language string comments - this works well |
hmm |
I have tested this item 🔴 unsuccessfully on f4e6698 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022. |
The issue is interesting as we have the same behavior when using the associations Tab (through js). |
@brianteeman |
Note: the multilingual manager may not show the item once target is saved and Close button has been used. But the item IS saved with the selected language and correctly associated to the target. Just select the right type of item and language. |
same return, in fact that a great addition ! we win a lot of time thanks ! |
@micker |
@brianteeman |
Tested its ok for me This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022. |
at Issue Tracker Test of @micker is shown as successfully. I altered it too but it isn't shown here. |
Yes, I had marked it as successful as he did not do it really, but we have an issue. |
The issue I reported has been resolved. BUT I found another one when "editing" associations. When I open an item that is already associated and then select "edit associations" I expected to be redirected to com_associations with the item AND its association open but it is not. Thinking about solving this I can see that on a bilingual site what I described would be the expected behaviour but it wouldnt be possible on a site with more than two languages. So it can only be resolved, imho, by changing the expectation of clicking on the button "edit associations". Perhaps just saying "associations" on the button will do that. |
@brianteeman
It is obviously impossible to do the same if we have more than 2 content languages @micker |
@infograf768 awesome. If not already merged I will test tomorrow |
$lang_code[] = $language->lang_code; | ||
} | ||
|
||
$refLang = array($data['language']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove spaces before =
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. thanks.
I have tested this item ✅ successfully on 0db5e28 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022. |
@jreys Thanks for testing. Needs one more test. @micker @brianteeman |
tested ✅ successfully on 0db5e28 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022. |
Ready to Commit after two successful tests. |
why was successfully Test of @micker not shown at Issue Tracker (have altered Test now)? |
@franz-wohlkoenig sorry i am a newbie on tracker how i can do this |
@micker this was not to you, it was a Question on People knowing more than me how this could be (as similar happen a few Days ago). On your Question as Example of this PR: Please mark your Test as successfully:
|
@micker before i forget: Thanks for your Work. |
Pull Request for Issue #21003
Summary of Changes
Adding a new toolbar for items which can be associated.
The toolbar button redirects to the side by side Multilingual associations component.
Changes include new methods in FormController as in AdminModel.
And the new toolbar button for each view concerned.
Testing Instructions
Install a multilngual site. Make sure Associations are set.
Edit any
Click on the new
Edit Associations
Toolbar button. Example:You should be redirected to the side by side.
If the item is set to ALL languages, a Notice will display.
Documentation Changes Required
I guess so. Target is 3.9.x
@Bakual @rdeutz @alikon