Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_tags] All Tags default layout #21031

Merged
merged 1 commit into from Aug 21, 2018
Merged

[com_tags] All Tags default layout #21031

merged 1 commit into from Aug 21, 2018

Conversation

SharkyKZ
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This fixes the issue of default all tags layout setting not being respected. Also removes some misplaced code.

Testing Instructions

Create an alternative All Tags layout (in /components/com_tags/views/tags/tmpl/ or /templates/protostar/html/com_tags/tags/).
Go to com_tags configuration and select new layout under Default List All Tags Layout setting.
Enter all tags view directly (index.php?option=com_tags&view=tags).

Expected result

Selected layout is used.

Actual result

Selected layout not used.

Documentation Changes Required

No.

@ghost
Copy link

ghost commented Jul 11, 2018

Can't get this PR working:

As wroting in Test Instructions created an alternative All Tags layout:

bildschirmfoto 2018-07-11 um 16 03 23

In "Tag Options" selected the new Layout:

bildschirmfoto 2018-07-11 um 16 05 19

Entered all tags view directly (index.php?option=com_tags&view=tags) but get with and -out PR same Result:

bildschirmfoto 2018-07-11 um 16 02 05

System information

  • 3.8.11-dev
  • Template: Protostar
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

  • PHP 7.0.28
  • MySQLi 5.7.18-cll-lve

@ghost
Copy link

ghost commented Jul 11, 2018

I have tested this item 🔴 unsuccessfully on 9be6cfc

as described above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

@SharkyKZ
Copy link
Contributor Author

@franz-wohlkoenig did you make any changes to custom layout? You need something to tell the two layouts apart.

@ghost
Copy link

ghost commented Jul 12, 2018

I have tested this item successfully on 9be6cfc

Thanks for Info, @SharkyKZ

I changed the Size of Tag-Title from h3 up to h1; using PR at "index.php?option=com_tags&view=tags" Title is shown in h1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

@fancyFranci
Copy link
Contributor

I have tested this item successfully on 9be6cfc

My test layout has a new paragraph and I can see it only after applying this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

@ghost
Copy link

ghost commented Aug 17, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2018
@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 18, 2018
@mbabker mbabker merged commit 1ae34d0 into joomla:staging Aug 21, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Aug 21, 2018
@SharkyKZ SharkyKZ deleted the comTagsAllTagsLayout branch August 21, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants