New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_tags] All Tags default layout #21031

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
5 participants
@SharkyKZ
Contributor

SharkyKZ commented Jul 10, 2018

Pull Request for Issue # .

Summary of Changes

This fixes the issue of default all tags layout setting not being respected. Also removes some misplaced code.

Testing Instructions

Create an alternative All Tags layout (in /components/com_tags/views/tags/tmpl/ or /templates/protostar/html/com_tags/tags/).
Go to com_tags configuration and select new layout under Default List All Tags Layout setting.
Enter all tags view directly (index.php?option=com_tags&view=tags).

Expected result

Selected layout is used.

Actual result

Selected layout not used.

Documentation Changes Required

No.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jul 11, 2018

Can't get this PR working:

As wroting in Test Instructions created an alternative All Tags layout:

bildschirmfoto 2018-07-11 um 16 03 23

In "Tag Options" selected the new Layout:

bildschirmfoto 2018-07-11 um 16 05 19

Entered all tags view directly (index.php?option=com_tags&view=tags) but get with and -out PR same Result:

bildschirmfoto 2018-07-11 um 16 02 05

System information

  • 3.8.11-dev
  • Template: Protostar
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

  • PHP 7.0.28
  • MySQLi 5.7.18-cll-lve

franz-wohlkoenig commented Jul 11, 2018

Can't get this PR working:

As wroting in Test Instructions created an alternative All Tags layout:

bildschirmfoto 2018-07-11 um 16 03 23

In "Tag Options" selected the new Layout:

bildschirmfoto 2018-07-11 um 16 05 19

Entered all tags view directly (index.php?option=com_tags&view=tags) but get with and -out PR same Result:

bildschirmfoto 2018-07-11 um 16 02 05

System information

  • 3.8.11-dev
  • Template: Protostar
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

  • PHP 7.0.28
  • MySQLi 5.7.18-cll-lve
@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jul 11, 2018

I have tested this item 🔴 unsuccessfully on 9be6cfc

as described above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

franz-wohlkoenig commented Jul 11, 2018

I have tested this item 🔴 unsuccessfully on 9be6cfc

as described above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

@SharkyKZ

This comment has been minimized.

Show comment
Hide comment
@SharkyKZ

SharkyKZ Jul 12, 2018

Contributor

@franz-wohlkoenig did you make any changes to custom layout? You need something to tell the two layouts apart.

Contributor

SharkyKZ commented Jul 12, 2018

@franz-wohlkoenig did you make any changes to custom layout? You need something to tell the two layouts apart.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jul 12, 2018

I have tested this item successfully on 9be6cfc

Thanks for Info, @SharkyKZ

I changed the Size of Tag-Title from h3 up to h1; using PR at "index.php?option=com_tags&view=tags" Title is shown in h1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

franz-wohlkoenig commented Jul 12, 2018

I have tested this item successfully on 9be6cfc

Thanks for Info, @SharkyKZ

I changed the Size of Tag-Title from h3 up to h1; using PR at "index.php?option=com_tags&view=tags" Title is shown in h1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

@FPerisa

This comment has been minimized.

Show comment
Hide comment
@FPerisa

FPerisa Aug 16, 2018

I have tested this item successfully on 9be6cfc

My test layout has a new paragraph and I can see it only after applying this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

FPerisa commented Aug 16, 2018

I have tested this item successfully on 9be6cfc

My test layout has a new paragraph and I can see it only after applying this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 17, 2018

Ready to Commit after two successful tests.

franz-wohlkoenig commented Aug 17, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 17, 2018

@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 18, 2018

@mbabker mbabker merged commit 1ae34d0 into joomla:staging Aug 21, 2018

4 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Aug 21, 2018

@SharkyKZ SharkyKZ deleted the SharkyKZ:comTagsAllTagsLayout branch Aug 21, 2018

ReLater added a commit to ReLater/joomla-cms that referenced this pull request Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment