Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for MySQL 8 workaround #21339

Merged
merged 5 commits into from Aug 6, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion installation/language/en-GB/en-GB.ini
Expand Up @@ -64,7 +64,7 @@ INSTL_DATABASE_PASSWORD_DESC="Either a password you created or a password provid
INSTL_DATABASE_PREFIX_DESC="Enter a table prefix or use the randomly generated one."
INSTL_DATABASE_TYPE_DESC="Select the database type."
INSTL_DATABASE_USER_DESC="Either a username you created or a username provided by your host."
INSTL_DATABASE_VALIDATION_ERROR="Check your database credentials, database type, database name or hostname"
INSTL_DATABASE_VALIDATION_ERROR="Check your database credentials, database type, database name or hostname. If may have MySQL 8 installed then please read this <a href="https://docs.joomla.org/Joomla_and_MySQL_8#Workaround_to_get_Joomla_working_with_MySQL_8">wiki</a> for more information."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you not if may ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppsss....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BilalReffas Reminder to fix text.

INSTL_INSTALL_JOOMLA="Install Joomla"
INSTL_CONNECT_DB="Setup Database Connection"

Expand Down
2 changes: 1 addition & 1 deletion installation/language/en-US/en-US.ini
Expand Up @@ -64,7 +64,7 @@ INSTL_DATABASE_PASSWORD_DESC="Either a password you created or a password provid
INSTL_DATABASE_PREFIX_DESC="Enter a table prefix or use the randomly generated one."
INSTL_DATABASE_TYPE_DESC="Select the database type."
INSTL_DATABASE_USER_DESC="Either a username you created or a username provided by your host."
INSTL_DATABASE_VALIDATION_ERROR="Check your database credentials, database type, database name or hostname"
INSTL_DATABASE_VALIDATION_ERROR="Check your database credentials, database type, database name or hostname. If may have MySQL 8 installed then please read this <a href="https://docs.joomla.org/Joomla_and_MySQL_8#Workaround_to_get_Joomla_working_with_MySQL_8">wiki</a> for more information."
INSTL_INSTALL_JOOMLA="Install Joomla"
INSTL_CONNECT_DB="Setup Database Connection"

Expand Down