Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing com_installer database view version compare #2147

Merged
merged 2 commits into from Feb 13, 2014

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Oct 5, 2013

Here is the bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32179

I don't know if this needs to be fixed in the fix() task of the installer, too.

@wilsonge

This comment has been minimized.

This looks like it should also be !=0 rather than ==-1 as the original string is checking if they are not equal

@Hackwar

This comment has been minimized.

Copy link
Owner Author

@Hackwar Hackwar commented on 02d9c87 Oct 6, 2013

I'll fix it. :-)

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Dec 5, 2013

So these two are still open? No wonder people get missing update notices... Could we please merge this? Thanks.

@Bakual
Copy link
Contributor

@Bakual Bakual commented Dec 5, 2013

Reason is that we don't have sufficient testing yet.

I'm sure you agree that we should not merge untested code 😉

infograf768 added a commit that referenced this pull request Feb 13, 2014
Fixing com_installer database view version compare
@infograf768 infograf768 merged commit 8491778 into joomla:2.5.x Feb 13, 2014
@Hackwar Hackwar deleted the Hackwar:inst_version_comp_25 branch Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants