[4.0] Fix workflow state submenu #21508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bembelimen
requested review from
brianteeman,
laoneo,
mbabker,
rdeutz,
wilsonge and
zero-24
as code owners
bembelimen
changed the title
|
I have tested this item ✅ successfully on 9aca034 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21508. |
|
I have tested this item ✅ successfully on 9aca034 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21508. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21508. |
|
Thanks! |
geetanshu-m
added a commit
to geetanshu-m/joomla-cms
that referenced
this pull request
Aug 18, 2018
* [4.0] Pagination [a11y] admin (joomla#21293) * [4.0] Pagination [a11y] * Update default.php * Update modal.php * Update modal.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * Update default.php * tabs * Remove registering form paths for paths that no longer exist (joomla#21279) * Remove random number from code comment * [4.0] Separate sources from the distributable assets (joomla#21328) * I like to move it, move it 🕺 * Fix overflow of submenu despite being closed (joomla#21316) * [4.0] Fixed the translation of the view type in menuitem (joomla#21324) * Fixed the path to the XML-File of a layout in a view of a component. * Add the path to layout schema for Joomla! 3 component * fixed coding standard * fixed more coding standard * fixed the path to layout shema for old Joomla! version * Codestyle * 4.0 check for valid session before messing with ini (joomla#21337) * Added checks for an active PHP session before trying to change ini values. * Revert "Added checks for an active PHP session before trying to change ini values." This reverts commit 54aab95. * Added checks for an active PHP session before trying to change ini values. * Changed check to isActive() as suggested by @wilsonge . * Remove tabs/blank line (joomla#21346) * Update the cli nom commands (joomla#21350) * Ooops * Update package.json * Update compile-es6.js * remove the automated part here * Adjusted the batch-language.js to hide the batch move/copy options by default. (joomla#21340) * [4.0] Article batch operation fixes (joomla#21325) * some changes in ArticleModel * Undefined class warnings resolved * Commented out code removed * few style changes * few more style changes * Removed the function which caused an error because it wasn't declared anywhere * [4.0] Improving menu item workflow (joomla#21357) * created new branch * formatted code * fixed modal id variable loaded language file for modal title * formatted code and ajusted comments * fixed javascript error due to modal not closing * code style * code style * Codestyle * [4.0] CSS codestyle offline.css (joomla#21379) * Sans Serif to sans-serif + newline * cs * New version of Joomla * [4.0] update the custom elements (joomla#21204) * update joomla-custom-elements + polyfills * REMOVE * [4.0] Fixed the parent item dropdown (joomla#21348) * Fixed the parent item dropdown * fixed code style * Fix 2nd level menu (atum template) not showing (joomla#21367) * fixed button description to language string (joomla#21387) * [4.0] RTL frontend login (joomla#21402) * [4.0] Fix joomla#21357 when multilanguage is implemented (joomla#21391) * [4.0] Fix: Associations tab should display only one Notice when item edited is set to ALL languages * correcting my local branch * [4.0] Fix 21357 when multilang is implemented * [4.0] ES6 conversion of select-colour.js (joomla#21406) * select-colour * make sure we always compare numbers * correction: event name * [40] ES6 batch language script and move it to the right place (joomla#21405) * batch language * correction: event name * [4.0] Accessing property without checking the object state causing Joomla installer non-responsive (joomla#21413) * Bug fix for joomla#21412 After installing Joomla, go to customization and select language say Hindi for installation. If the language cannot be installed, the server will not return any value, and the value is null. But the below code is accessing its properties without checking the data is null or not. * Update LanguagesModel.php * Remove extra space * Remove extra tabs * [4.0] ES6 multiselect.js (joomla#21409) * multiselect * hound * this needs to be in a higher element * drop this * [4.0] Simplifying lang load (joomla#21415) * [4.0] Update readme.md (joomla#21392) Remove reference to jenkins * es6 please (joomla#21341) * Better error message for MySQL 8 workaround (joomla#21339) * Better error message for MySQL 8 workaround * change error message * error message typo in en-US * Fix typo in en-GB * [4.0] DRY for warning pages (joomla#21331) * DRY * Update package.json * Update restore_finalisation.php (joomla#21332) * [4.0] [a11y] Pagination site (joomla#21306) * [4.0] [a11y] Pagination * drone * cs * template css etc * woof woof * jtext * correct scss to highlight current * hound * fix link styles * hound * conflicts * revert joomla#18533 and move back to the stable state (joomla#18558) * [4.0] ES6 please, validate.js (joomla#21417) * validate * missing class * [4.0] Fix: Associations tab should display only one Notice when item edited is set to ALL languages (joomla#21362) * [4.0] Fix: Associations tab should display only one Notice when item edited is set to ALL languages * correcting my local branch * [4.0] Fix: Associations tab should display only one Notice when item edited is set to ALL languages * [4.0]namespace administrator components com_languages (joomla#21058) * com_languages * Update edit.php * Update StringsModel.php * Update OverridesModel.php * [4.0]namespace administrator components com_installer (joomla#21056) * com_installer * Update InstallModel.php * Update UpdateModel.php * jupdatecheck (joomla#21421) * bug in the regex (joomla#21427) * [4.0] Split the configuration of the session service on a per-application basis, restructure session GC command (joomla#19594) * Split the configuration of the session service on a per-application basis, restructure session GC command * Make a session factory, move handler creation into it * Expand comments on session service key aliasing * Apparently this is our PHPCS style? * Change to a less than readable variant of the signature because our PHPCS rules suck * Fix container reference * PHPCS fixes * Inject Session class options into factory, validate option presence * [4.0] Cleanup error handling in the installer on failed DB Connections (joomla#20334) * Cleanup of messages in installation error cases * Implement feedback * Code cleanup * Remove invalid character from cache namespace declaration * com_wrapper ES6 (joomla#21430) * Fix namespace code style of com_admin * Fix namespace code style of com_associations * [4.0] ES6 com_tags (joomla#21432) * com_tags * mute the dog * [4.0] ES6 com_languages overrider (joomla#21434) * overrider * woof * grrr * [4.0] ES6 please, tinyMCE (joomla#21428) * tinyMCE * mute the dog * remove the es5 files * No console errors on the BS and tiny sourcemaps * [4.0] ES6 please, sampledata.js (joomla#21422) * sampledata * mute the dog * [4.0] Change com_cpanel to services (joomla#21419) * Change com_cpanel to services * dispatcher * fields (joomla#21440) * [4.0] ES6 please, com newsfeed (joomla#21433) * com_newsfeed * woof * woof ? * [4.0] Install discover 500 (joomla#21443) Wrong namespace change - my bad * com_mailTo (joomla#21442) * [4.0] ES6 please, com_finder (joomla#21438) * finder * hound * These were supposed to be ES6 * woof * [4.0] Update build.js (joomla#21446) The installation template was missing from the watch and build scrippts * [4.0]Archive view (joomla#21449) Fix the missing endif to the title * Change content history to services (joomla#21418) * use the class keyword * plg_stats (joomla#21455) * [4.0] ES6 please, com_contacts (joomla#21453) * com_contacts * cleanup * [4.0] ES6 Please com_contenthistory (joomla#21454) * history * woof * Installer library - use parameterized queries (joomla#21459) * [4.0] Installer library qn/q (joomla#21461) Change the usage of q and qn to quote and quoteName in this recently merged code * [4.0] ES6 please: core+keepLive (joomla#21404) * core+keepLive * Ooops, missing things here * CS * fixes * [4.0] Password eye button (joomla#21462) Changed the class in the layout and the js * [4.0] ES6 please, com media edit (joomla#21444) * media edit * edit * woof * oops * hmm * really? * [4.0] Admin Pagination [a11y] (joomla#21424) * [4.0] Admin Pagination [a11y] Similar to joomla#21306 but for the admin The aim of this PR is to make the pagination seen in list views in the front end accessible - there are no visual changes - Wrap the pagination in a nav and add a role (needed for IE) and an aria-label - Ensure font icons have aria-hidden=true - Add aria-current to the selected page - Add aria-title to the active links eg Go to page 1 Note 1 that the disabled links will not be announced to a screen reader which is the intended behaviour Note 2 the list is an unordered list which appears to be the standard as otherwise the links would be announced as Link 1 go to page 2 etc which is nonsense ### Changes **administrator\templates\atum\html\pagination.php** removed - we dont need an override **layouts\joomla\pagination\links.php** Made similar to list and set showlimitbox to false (looks like legacy code to me) ** administrator\templates\atum\scss\blocks\_layout.css new file with just the styling used in the front end ### Testing Should be testable with patchtester but make sure that the template override has been deleted * cs * update joomla-browser [CLEAR CACHE] * move rebuild cache step before the tests * [4.0] ES6 please, com menu (joomla#21463) * com_menus * woof * Check that custom session path exists, create if not, if can't create then use default (joomla#19431) * Destroy session on deleting installation folder (joomla#20426) * xml codestyle * [a11y] Joomla logo is a decorative image only so should not have an alt description * Remove duplicate system-message-container div - important so we have unique id * fonrawesome is include in the template.css by the sccs - no need to load it again * update code comment it is super user not supr admin etc * use quote and quotename not q and qn * namespace - JText * Namespace JHtml * Help Docs link - add a link to the docs site and meaningful text for screenreaders to the "lightbulb" [a11y] * change section role=main to just <main> * [a11y] Add h1 to the page * You can not use a custom element to display the noscript message - obviously that's not going to work because the custom element is javascript - inception * [a11y] Move message about installing languages to be a caption [a11y] add scope to languages table * [a11y] contrast on language version number * [a11y] Section headings not nested correctly h1->h3 now h1->h2 * Namespace JFile * Namespace Jfolder * target blank on mysql8 link to docs * [a11y] footer link color and hover fixes joomla#21359 * Validate name of database fixes joomla#15583 * remove all references to switcher - not being used and it breaks scss compile * template.css after running npm build:css [note this hadn't been run for a while as it was missing from the build scripts] * forgot to save * quoteName * hound * missing semicolon in original code * aria-hidden * quote issue reported by @Quy * aria-hidden * fix regex - thank @ggppdk * regex again * [4.0] Remove Exception-catching from JMail (joomla#21320) * Updated the Mail.php file to the changes in PR joomla#12179 * Added Exception Handling for the Mails that get send after sending private messages in the Backend * Update Mass-Mail Function to handle the Exceptions from the JMail class * Update the update notification plugin to handle the new Exceptions from the JMail class * Update the Contact-Module to handle the exceptions thrown by the JMail class * Update joomla.php When you create a user and the creation email cant be sent, the thrown exception from the JMail class is handled * Update DisplayController.php When you try to forward an article via email and it fails the exception os caught and handled * Update RemindModel.php When you try to send a reminder email because you forgot your username and the mail can not be sent the exception is caught and handled. * Update ResetModel.php When you try to send a reset email because you forgot your password and the mail can not be sent the exception is caught and handled. * Update RegistrationModel.php When you try to try to register a new User account in the frontend, and the registration-mail can not be sent the exception is caught and handled. * Updated multiple files to better handle the new exceptions thrown by the JMail class and still display the correct messages. * Updated MessageModel.php to better handle the Exceptions thrown in the JMail class. Added new Error Message to translation file. * Removed unnecessary redirect from DisplayController.php * Improved Exception handling in the joomla.php that is used when creating users in the backend. * Updated translation file * Fixed a code-style issue * fixed a twice used class * [4.0] Feature/New Publishing Workflow (joomla#20381) Thanks @bembelimen @Didldu-Florian @puneet0191 @priiish @brianteeman and @chmst * [4.0] Constant usage (joomla#18504) * CONSTANT usage * Revert change in one case, as it might be useful to have the extra info there. * U Can't Touch This! * Fix conflicts and remove some replacements due to possible b/c break * By default categories use the default workflow * [4.0] [a11y] com_users icons (joomla#21468) While testing joomla#21441 (which is not related to this pr) I spotted that we missed three icons that should have aria-hidden applied to them The three icons can be seen in the admin when listing users - icon to add a note for the user. - icon to filter the notes list. You will need to create some notes first - number of notes for the user. You will need to create some notes first * [4.0] ES6 please, com modules (joomla#21465) * com_modules * woof * [4.0] ES6 please, searchtools (joomla#21467) * searchtools * haha * Fix namespace code style of com_banners * Fix namespace code style of com_cache * Fix namespace code style of com_categories * Fix namespace code style of com_checkin * Fix namespace code style of com_config * Fix namespace code style of com_contact * Fix namespace code style of com_content * Fix namespace code style of com_contenthistory * Fix namespace code style of com_cpanel * Fix namespace code style of com_csp * Fix namespace code style of com_fields * [4.0] workflow namespace (joomla#21471) * [4.0] workflow namepsace Quick pr to namespaace jtext and jtml * oops * [4.0] Workflows - fix xml codestyle (joomla#21470) fix various codestyle issues * Add missing doc block * [4.0] MVC mot Mvc (joomla#21478) * [4.0] MVC mot Mvc Codestyle * oops * [4.0] Workflow - too (joomla#21480) * [4.0] Workflow - too many In english it is "too many" when you refer to more than. You use "to" when you refer to travelling from A to B * Revert "[4.0] Workflow - too many" This reverts commit cd2058e. * too many * [4.0] Use the new hasField() in JTable (joomla#21479) * [4.0] Move JTable property_exists to hasField method Move JTable property_exists to hasField method * asset table * CoreContent * Extension * Nested * [4.0] Workflow namespace 2 (joomla#21484) * jroute * Jsession * jfactory * Jlayouthelper * jtext * Bump Composer dependencies (joomla#21490) * [4.0] Workflow [a11y] (joomla#21488) Remove th and scope=col from the checkall cell Add th and scope=row to the title cell * [4.0] Installer - precheck css (joomla#21482) * [4.0] Installer - precheck css PR for joomla#20773 ### Before ### After ### Testing You will probably need to force an error on your system or to edit the file installation\src\Model\ChecksModel.php and change some of the lines with option->state to $option->state = count($available); * woof * [4.0] Workflow unused variable (joomla#21486) Remove unused variable - probably remnant from removing the tfoot * [4.0] Workflows commented (joomla#21483) Remove 1 block of commented out code Expose 1 block of commented out code * [4.0] Workflow remove copy/paste code (joomla#21489) Can only assume that this id is from some other code that was copy pasted here without thought as it makes no sense to have this id * Fix namespace imports in workflow Controller * Codestyle fix * [4.0] Workflows language (joomla#21493) * [4.0] Workflows language en-gb and codestyle * oops * Remove unused import * Fix namespace * [4.0] Use the new hasField() (joomla#21494) * [4.0] Use the new hasField() * use the new hasField() * use the new hasField() * Codestyle and use whereIn from db driver * [4.0] c/p error in com_installer namespace commit (joomla#21492) JVERSION is a string for translation. * I need to setup my IDE * Array -> integer * Use namespaced class * Cleanup return type * Fix code comments * use function not property * Fix docblocks * [4.0] Fix npm script on windows (joomla#21505) * Fix compile-es6 script on Windows machines. * Adding back .min.js * [4.0] Fix workflow state submenu (joomla#21508) * Fix redirect for state checkin * Clean up * Fix broken multilingual handling (joomla#21512) * Fix workflows.xml (joomla#21511) * Fix namespace code style of com_finder * Fix namespace code style of com_installer * Fix namespace code style of com_joomlaupdate * Fix namespace code style of com_languages * Fix namespace code style of com_login * Fix namespace code style of com_menus * Fix namespace code style of com_messages * Fix namespace code style of com_modules * Fix namespace code style of com_newsfeeds * Fix namespace code style of com_plugins * Fix namespace code style of com_postinstall * Fix namespace code style of com_redirect * Fix namespace code style of com_search * Fix namespace code style of com_tags * Fix namespace code style of com_templates * Fix namespace code style of com_users * com_templates ES6 (joomla#21431) * Merge artcle title, alias, category to one column (joomla#21503) * [WIP][4.0] - workwflow mysql schema (joomla#21499) * [4.0] - workwflow mysql schema [wip] * extension field consistent make the extension field consistent with the current schema ie varchar(50) * Fix joomla#21517 * Namespaced class/docblock * Codestyle * Improve docblocks * Use namespaced code * Use namespaced table class * use a newer version of joomla-browser with higer timeout * [4.0] Fields redo, switcher (joomla#21227) * do not recreate child elements on node move * Change span to fieldset to properly adapt focus * label for sould targeting the fieldset * one more try * again * aria-labeledby * Remove wrongly committed file * [4.0] layout missing from joomla#21424 (joomla#21561) * [4.0] layout missing from joomla#21424 * hound * [4.0] State to stage (joomla#21544) * Change "state" to "stage" * article-model * Change "state" to "stage" * Spelling correction controler/controller * Fix typos * Revert renaming of workflowstate * Revert renaming of workflowstate * Fix Language-key and String, rename the e-mail param, revert change of the classname * Fix typos * Some more state-stage changes * Email without hyphen * Language string copied * Fix errors in renaming state to stage for workflow (joomla#21563) * Fix errors in renaming state to stage for workflow * Fix table * [4.0] Use the new hasField() (joomla#21496) * [4.0] Use the new hasField() * use hasField() * use the new hasField() * use the new hasField() * use hasField() * oops * [4.0] FIX searchtools (joomla#21562) * Clean up and alpha-order imports (joomla#21577) Signed-off-by: Roland Dalmulder <contact@rolandd.com> merged with trust in phpstorm * Add back package lock file missing * Fix joomla#21177 * [4.0] Revert helper (joomla#21523) * Remove readded core.js * Remove outdated ContentHelper::filterText method * Remove outdated ContentHelper::getContexts method * Remove outdated ContentHelper::validateSection method * Update countTagItems * Readd initial archive condition for further use * Remove blank lines * Align "=" * Revert line * [4.0] Install database name validation (joomla#21583) Correct the regex on the database name to prevent _ as the first character * [4.0] Installation error message (joomla#21572) Make the error messages on field validation red * [4.0] ES6 please show on (joomla#21568) * showon * woof * 🐶 * Fix joomla#21304 Fix conflicting class import * Lowercase for consistency * [4.0] It was a diffenent factory (joomla#21587) * I was a diffenent factory * lowercase keyword * [4.0] Normalise display of searchtools specific fields for menu items (joomla#21581) and multilingual associations * added params to the installation script * update to 4.8.2 remove temp patch (joomla#21588) * [4.0] State to stage fixes (joomla#21566) * [4.0] Stage (joomla#21589) * [4.0] Stage Quick PR to make the column header "From..." match the column header "To..." and the associated message * cs * [4.0][Workflow] Lowercase Workflowstage JHtml and Field (joomla#21597) * Rename Workflow_S_tageField * Rename JHtmlWorkflowStage to JHtmlWorkflowstage * [4.0] Empty Trash (joomla#21602) Makes the empty-trash button red just as the delete button is * [4.0] Workflow copy paste (joomla#21607) Fix some copy paste errors in the doc blocks * [4.0] Webcomponent tab.js typo (joomla#21606) oriendation ==> orientation * [4.0] Moved style to the CSS file (backend - system template) (joomla#21569) * Moved style to the CSS file * Move style to the CSS file * Removing trailing spaces Thanks @Quy * [4.0] [WORKFLOW] Modifying Toolbar constant (joomla#21591) * [4.0] [a11y] Modal button colour (joomla#21605) Make sure the secondary button passes the color contrast check ### Before ### After (Does not need npm to test) * remove redundant code (joomla#21609) * [4.0] State to Stage (joomla#21571) * State to Stage * Update en-GB.plg_content_joomla.ini * Update joomla.xml * Update joomla.php * [4.0] - Workflow mysql/postgresql schema (joomla#21520) * [WIP][4.0] - workwflow mysql schema -idx prefix - removed ENUM field type * postgresql schema update workflow * fix mysql install 4 workflow * workflow mysql install review * now() * lost hypen * workflow postgresql schema * the state alter * the state alter * state2stage * state2stage * mysql 5.5 * mysql 5.5 * mysql 5.5 consistency * mysql 5.5 consistency * missed quote * remove duplicated tables * revert state change on #__content * revert state field change * revert start field change * revert start field change * Self contain webcomponent SCSS (joomla#21615) * [4.0] Rules (joomla#21616) Obvious error missing - Non functional change * Enable detectDebug in HTMLHelper::webcomponent by default (joomla#21617) * Fix namespace code style of mod_feed * Fix namespace code style of mod_logged * Fix namespace code style of mod_login * Fix namespace code style of mod_menu * Fix namespace code style of mod_popular * Fix namespace code style of mod_version * Fix namespace code style of com_banners * Fix namespace code style of com_contact * Fix namespace code style of com_content * Fix namespace code style of com_contenthistory * Fix namespace code style of com_fields * Fix namespace code style of com_finder * Fix namespace code style of com_mailto * Fix namespace code style of com_modules * Fix namespace code style of com_newsfeeds * Fix namespace code style of com_search * Fix namespace code style of com_tags * Fix namespace code style of com_users * Fix namespace code style of com_wrapper * Fix namespace code style of mod_banners * [4.0] allow jdoc:include type=message to load assets (joomla#21558) * dry * allow modules to enqueMessages * [4.0] - [workflow] fix undefined condition (joomla#21621) * [4.0] - [workflow] fix undefined condition * undefined condition * [4.0][workflow] - undefinded property on modal (joomla#21622) * Fix the imports in the archive model (joomla#21620) * [4.0] drop jQuery (joomla#21575) * Drop jQuery (again 😃) * typo * cs * remove redundant code * Update default.php * Update default.php * Update default.php * Update default.php * fix dos (joomla#21627) * [4.0][workflow] remove workflow from user menu (joomla#21626) * [4.0][workflow] remove workflow from user menu * remove content field item from user menu * [4.0] [a11y] Set login page title (joomla#21603) * [4.0] [a11y] Set login page title a11y rules says that every page should have a meaningfu title This PR adds the title "Administrator Login - sitename" to the title on the login page * save before commit * reverse * composer and npm install * [4.0] [workflow] - notice on edit plugin (joomla#21623) * [4.0] [workflow] - notice on edit plugin * conservative * don't kill empy lines * [4.0] com_workflow: Missing Value for "Count States" - fixes joomla#21634 (joomla#21635) * [4.0][workflow] - batch change stage (joomla#21625) * [4.0][worflow] - batch change stage * stage line 840 * build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21491 .
Summary of Changes
Fix disappearing of left column
Testing Instructions
See: #21491
Expected result
Menu column is still visible
Actual result
Menu column disappear.