New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by archived in Redirect Manager #21673

Merged
merged 2 commits into from Aug 21, 2018

Conversation

Projects
None yet
6 participants
@wilsonge
Contributor

wilsonge commented Aug 17, 2018

Summary of Changes

Allows filtering by the archived state in the redirect component.

Testing Instructions

In search tools of the redirect component there is now an archived option in the dropdown which allows filtering by archived options

Documentation Changes Required

n/a

wilsonge added some commits Aug 17, 2018

@wilsonge wilsonge changed the title from Filter/archived redirect comp to Allow filtering by article in Redirect Manager Aug 17, 2018

@wilsonge wilsonge changed the title from Allow filtering by article in Redirect Manager to Allow filtering by archived in Redirect Manager Aug 17, 2018

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 17, 2018

Contributor

I created a pr some time ago to remove the archived state from com_redirects as it has no purpose that I could see

Contributor

brianteeman commented Aug 17, 2018

I created a pr some time ago to remove the archived state from com_redirects as it has no purpose that I could see

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Aug 17, 2018

Contributor

That's fine. But as it's currently still there it should work properly :)

Contributor

wilsonge commented Aug 17, 2018

That's fine. But as it's currently still there it should work properly :)

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 17, 2018

Contributor

or just merge mine to remove it ;)

there is no function in setting a redirect to archived so better to remove a useless function than to add features to a broken function

Contributor

brianteeman commented Aug 17, 2018

or just merge mine to remove it ;)

there is no function in setting a redirect to archived so better to remove a useless function than to add features to a broken function

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 18, 2018

mentioned Pull Requests are #17417 (j3) and #17586 (j4)

franz-wohlkoenig commented Aug 18, 2018

mentioned Pull Requests are #17417 (j3) and #17586 (j4)

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 18, 2018

I have tested this item successfully on efbce0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.

franz-wohlkoenig commented Aug 18, 2018

I have tested this item successfully on efbce0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 18, 2018

Contributor

I still dont see any reason to have the archive state for redirects as they have no function - so no need to filter etc

Contributor

brianteeman commented Aug 18, 2018

I still dont see any reason to have the archive state for redirects as they have no function - so no need to filter etc

@ReLater

This comment has been minimized.

Show comment
Hide comment
@ReLater

ReLater Aug 18, 2018

Contributor

to remove a useless function

as discussed in #17417 that's your private opinion because you don't accept workflows of other users.

I still see no reason to remove archived status. Don't use it if you don't want to. Use it if you want to.

Contributor

ReLater commented Aug 18, 2018

to remove a useless function

as discussed in #17417 that's your private opinion because you don't accept workflows of other users.

I still see no reason to remove archived status. Don't use it if you don't want to. Use it if you want to.

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Aug 19, 2018

Member

Provide examples of valid workflows where a distinction between a published and an archived redirect link should be supported. As pointed out in that issue, what you are using archived for is exactly what unpublished is, archived is not a "we've reviewed this link and decided to not redirect it anywhere" state. If anything, if archived is going to exist as a state it should be consistent with the state as used in other core components (i.e. archived in com_redirect and com_content should have a loosely similar definition).

Member

mbabker commented Aug 19, 2018

Provide examples of valid workflows where a distinction between a published and an archived redirect link should be supported. As pointed out in that issue, what you are using archived for is exactly what unpublished is, archived is not a "we've reviewed this link and decided to not redirect it anywhere" state. If anything, if archived is going to exist as a state it should be consistent with the state as used in other core components (i.e. archived in com_redirect and com_content should have a loosely similar definition).

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Aug 20, 2018

Contributor

I have tested this item successfully on efbce0c

As discussed I still think it is wrong to have an archived state which does nothing but this PR does do what it aims to do


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.

Contributor

brianteeman commented Aug 20, 2018

I have tested this item successfully on efbce0c

As discussed I still think it is wrong to have an archived state which does nothing but this PR does do what it aims to do


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Aug 20, 2018

Ready to Commit after two successful tests.

franz-wohlkoenig commented Aug 20, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 20, 2018

@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 21, 2018

@mbabker mbabker merged commit a497887 into staging Aug 21, 2018

8 checks passed

Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mbabker mbabker deleted the filter/archived-redirect-comp branch Aug 21, 2018

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Aug 21, 2018

ReLater added a commit to ReLater/joomla-cms that referenced this pull request Sep 1, 2018

Allow filtering by archived in Redirect Manager (#21673)
* Allow filtering by archived state in redirect component

* Fix spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment