Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by archived in Redirect Manager #21673

Merged
merged 2 commits into from Aug 21, 2018

Conversation

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Aug 17, 2018

Summary of Changes

Allows filtering by the archived state in the redirect component.

Testing Instructions

In search tools of the redirect component there is now an archived option in the dropdown which allows filtering by archived options

Documentation Changes Required

n/a

wilsonge added 2 commits Aug 17, 2018
@wilsonge wilsonge changed the title Filter/archived redirect comp Allow filtering by article in Redirect Manager Aug 17, 2018
@wilsonge wilsonge changed the title Allow filtering by article in Redirect Manager Allow filtering by archived in Redirect Manager Aug 17, 2018
@brianteeman
Copy link
Member

@brianteeman brianteeman commented Aug 17, 2018

I created a pr some time ago to remove the archived state from com_redirects as it has no purpose that I could see

@wilsonge
Copy link
Contributor Author

@wilsonge wilsonge commented Aug 17, 2018

That's fine. But as it's currently still there it should work properly :)

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Aug 17, 2018

or just merge mine to remove it ;)

there is no function in setting a redirect to archived so better to remove a useless function than to add features to a broken function

@ghost
Copy link

@ghost ghost commented Aug 18, 2018

mentioned Pull Requests are #17417 (j3) and #17586 (j4)

@ghost
Copy link

@ghost ghost commented Aug 18, 2018

I have tested this item successfully on efbce0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Aug 18, 2018

I still dont see any reason to have the archive state for redirects as they have no function - so no need to filter etc

@ReLater
Copy link
Contributor

@ReLater ReLater commented Aug 18, 2018

to remove a useless function

as discussed in #17417 that's your private opinion because you don't accept workflows of other users.

I still see no reason to remove archived status. Don't use it if you don't want to. Use it if you want to.

@mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 19, 2018

Provide examples of valid workflows where a distinction between a published and an archived redirect link should be supported. As pointed out in that issue, what you are using archived for is exactly what unpublished is, archived is not a "we've reviewed this link and decided to not redirect it anywhere" state. If anything, if archived is going to exist as a state it should be consistent with the state as used in other core components (i.e. archived in com_redirect and com_content should have a loosely similar definition).

@brianteeman
Copy link
Member

@brianteeman brianteeman commented Aug 20, 2018

I have tested this item successfully on efbce0c

As discussed I still think it is wrong to have an archived state which does nothing but this PR does do what it aims to do


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.

@ghost
Copy link

@ghost ghost commented Aug 20, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC label Aug 20, 2018
@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 21, 2018
@mbabker mbabker merged commit a497887 into staging Aug 21, 2018
8 checks passed
8 checks passed
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mbabker mbabker deleted the filter/archived-redirect-comp branch Aug 21, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.