Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_actionlogs] - log cache actions #22739

Merged
merged 15 commits into from Mar 7, 2019
Merged

[com_actionlogs] - log cache actions #22739

merged 15 commits into from Mar 7, 2019

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 20, 2018

Pull Request for Issue #22703 only for cache

Summary of Changes

keep track of cache actions

Testing Instructions

with cache enbled
delete some/all cached items

Expected result

screenshot from 2018-10-20 08-42-57

Actual result

not logged

Documentation Changes Required

Copy link
Contributor

@brianteeman brianteeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve language strings

brianteeman and others added 4 commits October 20, 2018 19:39
Co-Authored-By: alikon <optimus4joomla@gmail.com>
@@ -261,6 +261,10 @@ public function clean($group = '')
{
return false;
}

Factory::getApplication()->triggerEvent('onAfterPurge', array($group));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be an array?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be an array.

public function triggerEvent($event, array $args = null)

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on d146463

I have tested this successfully on Joomla! 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on d146463


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@Quy
Copy link
Contributor

Quy commented Feb 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 3, 2019
@HLeithner
Copy link
Member

if we get another test we the updated code I would be happy.

@roland-d
Copy link
Contributor

roland-d commented Mar 7, 2019

I have tested this item ✅ successfully on b872e5c

After applying the patch the deletion of caches are logged in the action logs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@roland-d
Copy link
Contributor

roland-d commented Mar 7, 2019

@HLeithner Tested this.

@HLeithner HLeithner merged commit 2d2a756 into joomla:staging Mar 7, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2019
@HLeithner
Copy link
Member

Thx

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Mar 7, 2019
@alikon alikon deleted the patch-116 branch March 8, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants