Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_actionlogs] - log cache actions #22739

Merged
merged 15 commits into from Mar 7, 2019

Conversation

Projects
None yet
10 participants
@alikon
Copy link
Contributor

alikon commented Oct 20, 2018

Pull Request for Issue #22703 only for cache

Summary of Changes

keep track of cache actions

Testing Instructions

with cache enbled
delete some/all cached items

Expected result

screenshot from 2018-10-20 08-42-57

Actual result

not logged

Documentation Changes Required

alikon added some commits Oct 20, 2018

@brianteeman
Copy link
Contributor

brianteeman left a comment

approve language strings

brianteeman and others added some commits Oct 20, 2018

cached
Co-Authored-By: alikon <optimus4joomla@gmail.com>
doc
@@ -261,6 +261,10 @@ public function clean($group = '')
{
return false;
}
Factory::getApplication()->triggerEvent('onAfterPurge', array($group));

This comment has been minimized.

@Quy

Quy Oct 23, 2018

Contributor

Should not be an array?

This comment has been minimized.

@SharkyKZ

SharkyKZ Nov 10, 2018

Contributor

Must be an array.

public function triggerEvent($event, array $args = null)

alikon added some commits Nov 11, 2018

@tecpromotion

This comment has been minimized.

Copy link
Contributor

tecpromotion commented Jan 31, 2019

I have tested this item successfully on d146463

I have tested this successfully on Joomla! 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@viocassel

This comment has been minimized.

Copy link
Contributor

viocassel commented Feb 3, 2019

I have tested this item successfully on d146463


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Feb 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@joomla-cms-bot joomla-cms-bot added the RTC label Feb 3, 2019

alikon added some commits Feb 10, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Mar 7, 2019

if we get another test we the updated code I would be happy.

@roland-d

This comment has been minimized.

Copy link
Contributor

roland-d commented Mar 7, 2019

I have tested this item successfully on b872e5c

After applying the patch the deletion of caches are logged in the action logs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22739.

@roland-d

This comment has been minimized.

Copy link
Contributor

roland-d commented Mar 7, 2019

@HLeithner Tested this.

@HLeithner HLeithner merged commit 2d2a756 into joomla:staging Mar 7, 2019

3 of 4 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 7, 2019

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Mar 7, 2019

Thx

@HLeithner HLeithner added this to the Joomla 3.9.4 milestone Mar 7, 2019

@alikon alikon deleted the alikon:patch-116 branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.